From 27b5658affba5b12b396048d2cc598c70719bfc5 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Tue, 31 Jan 2012 00:56:53 +0000 Subject: [PATCH] Remove no-longer-useful dyn_casts and pals. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149307 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/InlineFunction.cpp | 31 ++++++++----------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/lib/Transforms/Utils/InlineFunction.cpp b/lib/Transforms/Utils/InlineFunction.cpp index f89e1b1c537..fa7f30dbd33 100644 --- a/lib/Transforms/Utils/InlineFunction.cpp +++ b/lib/Transforms/Utils/InlineFunction.cpp @@ -276,10 +276,7 @@ namespace { UnwindDestPHIValues.push_back(PHI->getIncomingValueForBlock(InvokeBB)); } - // FIXME: With the new EH, this if/dyn_cast should be a 'cast'. - if (LandingPadInst *LPI = dyn_cast(I)) { - CallerLPad = LPI; - } + CallerLPad = cast(I); } /// The outer unwind destination is the target of unwind edges @@ -507,13 +504,12 @@ static bool HandleCallsInBlockInlinedThroughInvoke(BasicBlock *BB, for (BasicBlock::iterator BBI = BB->begin(), E = BB->end(); BBI != E; ) { Instruction *I = BBI++; - if (LPI) // FIXME: New EH - This won't be NULL in the new EH. - if (LandingPadInst *L = dyn_cast(I)) { - unsigned NumClauses = LPI->getNumClauses(); - L->reserveClauses(NumClauses); - for (unsigned i = 0; i != NumClauses; ++i) - L->addClause(LPI->getClause(i)); - } + if (LandingPadInst *L = dyn_cast(I)) { + unsigned NumClauses = LPI->getNumClauses(); + L->reserveClauses(NumClauses); + for (unsigned i = 0; i != NumClauses; ++i) + L->addClause(LPI->getClause(i)); + } // We only need to check for function calls: inlined invoke // instructions require no special handling. @@ -930,11 +926,8 @@ bool llvm::InlineFunction(CallSite CS, InlineFunctionInfo &IFI) { I != E; ++I) if (const InvokeInst *II = dyn_cast(I->getTerminator())) { const BasicBlock *BB = II->getUnwindDest(); - // FIXME: This 'if/dyn_cast' here should become a normal 'cast' once - // the new EH system is in place. - if (const LandingPadInst *LP = - dyn_cast(BB->getFirstNonPHI())) - CalleePersonality = LP->getPersonalityFn(); + const LandingPadInst *LP = BB->getLandingPadInst(); + CalleePersonality = LP->getPersonalityFn(); break; } @@ -946,11 +939,7 @@ bool llvm::InlineFunction(CallSite CS, InlineFunctionInfo &IFI) { I != E; ++I) if (const InvokeInst *II = dyn_cast(I->getTerminator())) { const BasicBlock *BB = II->getUnwindDest(); - // FIXME: This 'isa' here should become go away once the new EH system - // is in place. - if (!isa(BB->getFirstNonPHI())) - continue; - const LandingPadInst *LP = cast(BB->getFirstNonPHI()); + const LandingPadInst *LP = BB->getLandingPadInst(); // If the personality functions match, then we can perform the // inlining. Otherwise, we can't inline. -- 2.34.1