From 18c7ec1344b14c9a483b89f7ee73fba1cbdb2a38 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Thu, 1 Dec 2011 20:58:30 +0000 Subject: [PATCH] Fix unreachable return & simplify some branches. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@145627 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/APInt.cpp | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/Support/APInt.cpp b/lib/Support/APInt.cpp index 55cb433d893..506225f0640 100644 --- a/lib/Support/APInt.cpp +++ b/lib/Support/APInt.cpp @@ -1440,15 +1440,11 @@ APInt APInt::sqrt() const { APInt nextSquare((x_old + 1) * (x_old +1)); if (this->ult(square)) return x_old; - else if (this->ule(nextSquare)) { - APInt midpoint((nextSquare - square).udiv(two)); - APInt offset(*this - square); - if (offset.ult(midpoint)) - return x_old; - else - return x_old + 1; - } else - llvm_unreachable("Error in APInt::sqrt computation"); + assert(this->ule(nextSquare) && "Error in APInt::sqrt computation"); + APInt midpoint((nextSquare - square).udiv(two)); + APInt offset(*this - square); + if (offset.ult(midpoint)) + return x_old; return x_old + 1; } -- 2.34.1