From 08828a979a9c3b57e54af9b97d83e348e128b441 Mon Sep 17 00:00:00 2001 From: Tim Northover Date: Wed, 6 Aug 2014 11:13:06 +0000 Subject: [PATCH] ARM-MachO: materialize callee address correctly on v4t. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214958 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMISelLowering.cpp | 5 ++++- test/CodeGen/ARM/none-macho-v4t.ll | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 test/CodeGen/ARM/none-macho-v4t.ll diff --git a/lib/Target/ARM/ARMISelLowering.cpp b/lib/Target/ARM/ARMISelLowering.cpp index 3e53af42b89..618e39a1aec 100644 --- a/lib/Target/ARM/ARMISelLowering.cpp +++ b/lib/Target/ARM/ARMISelLowering.cpp @@ -1666,7 +1666,10 @@ ARMTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI, if (isStub && Subtarget->isThumb1Only() && !Subtarget->hasV5TOps()) { assert(Subtarget->isTargetMachO() && "WrapperPIC use on non-MachO?"); Callee = DAG.getNode(ARMISD::WrapperPIC, dl, getPointerTy(), - DAG.getTargetGlobalAddress(GV, dl, getPointerTy())); + DAG.getTargetGlobalAddress(GV, dl, getPointerTy(), + 0, ARMII::MO_NONLAZY)); + Callee = DAG.getLoad(getPointerTy(), dl, DAG.getEntryNode(), Callee, + MachinePointerInfo::getGOT(), false, false, true, 0); } else if (Subtarget->isTargetCOFF()) { assert(Subtarget->isTargetWindows() && "Windows is the only supported COFF target"); diff --git a/test/CodeGen/ARM/none-macho-v4t.ll b/test/CodeGen/ARM/none-macho-v4t.ll new file mode 100644 index 00000000000..4c6e68e0632 --- /dev/null +++ b/test/CodeGen/ARM/none-macho-v4t.ll @@ -0,0 +1,21 @@ +; RUN: llc -mtriple=thumb-none-macho -mcpu=arm7tdmi %s -o - | FileCheck %s +; RUN: llc -mtriple=thumb-none-macho -mcpu=arm7tdmi %s -filetype=obj -o /dev/null + +declare void @callee() + +define void @test_call() { + ; BX can only take a register before v5t came along, so we must materialise + ; the address properly. +; CHECK-LABEL: test_call: +; CHECK: ldr r[[CALLEE_STUB:[0-9]+]], [[LITPOOL:LCPI[0-9]+_[0-9]+]] +; CHECK: [[PC_LABEL:LPC[0-9]+_[0-9]+]]: +; CHECK-NEXT: add r[[CALLEE_STUB]], pc +; CHECK: ldr [[CALLEE:r[0-9]+]], [r[[CALLEE_STUB]]] +; CHECK: mov lr, pc +; CHECK: bx [[CALLEE]] + +; CHECK: [[LITPOOL]]: +; CHECK-NEXT: .long L_callee$non_lazy_ptr-([[PC_LABEL]]+4) + call void @callee() + ret void +} -- 2.34.1