From 054eb6cba689feca3c5883c6e0548d4b76b9845d Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Thu, 11 Dec 2014 20:51:54 +0000 Subject: [PATCH] AsmParser: Don't crash on an ill-formed MDNodeVector git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224056 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AsmParser/LLParser.cpp | 4 ++-- test/Assembler/invalid-mdnode-vector2.ll | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 test/Assembler/invalid-mdnode-vector2.ll diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index ae007ce3693..9e699d1ed3f 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -2968,8 +2968,8 @@ bool LLParser::ParseMetadataAsValue(ValID &ID, PerFunctionState *PFS) { /// ::= !{...} /// ::= !"string" bool LLParser::ParseMetadata(Metadata *&MD, PerFunctionState *PFS) { - assert(Lex.getKind() == lltok::exclaim); - Lex.Lex(); + if (ParseToken(lltok::exclaim, "expected '!' here")) + return true; // MDNode: // !{ ... } diff --git a/test/Assembler/invalid-mdnode-vector2.ll b/test/Assembler/invalid-mdnode-vector2.ll new file mode 100644 index 00000000000..3b577bba6cf --- /dev/null +++ b/test/Assembler/invalid-mdnode-vector2.ll @@ -0,0 +1,4 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +!0 = metadata !{metadata +; CHECK: expected '!' here -- 2.34.1