8 years agoAdd a check to configure that the libstdc++ selected by Clang isn't
Chandler Carruth [Wed, 15 Jan 2014 10:31:15 +0000 (10:31 +0000)]
Add a check to configure that the libstdc++ selected by Clang isn't
libstdc++v4.6. This is quite hard to test directly, so we test for it by
checking a known missing feature in that version that was added in v4.7.

This should prevent users from upgrading Clang but not GCC and hosting
with a too-old GCC's libstdc++ and getting strange and hard to debug
errors when we switch to C++11 by default.

Also, switch several of the macros I introduced to use AC_LANG_SOURCE
rather than AC_LANG_PROGRAM as we don't need configure's help writing
our main function (and we don't need such a function at all for most of
the tests).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199313 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoWinCOFF: Transform IR expressions featuring __ImageBase into image relative relocations
David Majnemer [Wed, 15 Jan 2014 09:16:42 +0000 (09:16 +0000)]
WinCOFF: Transform IR expressions featuring __ImageBase into image relative relocations

MSVC on x64 requires that we create image relative symbol
references to refer to RTTI data. Seeing as how there is no way to
explicitly make reference to a given relocation type in LLVM IR, pattern
match expressions of the form &foo - &__ImageBase.

Differential Revision: http://llvm-reviews.chandlerc.com/D2523

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199312 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert 199262 - MCJIT remote still failing on ARM
Renato Golin [Wed, 15 Jan 2014 09:09:46 +0000 (09:09 +0000)]
Revert 199262 - MCJIT remote still failing on ARM

Disabling remote MCJIT tests on ARM again, as they're still failing when
self-hosting on ARM, despite all my tests. At least now we have more info
on what message it's breaking and what is going on. Investigating.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199310 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRe-disable MCJIT remote tests on ARM
Renato Golin [Wed, 15 Jan 2014 09:09:39 +0000 (09:09 +0000)]
Re-disable MCJIT remote tests on ARM

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199309 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoWhitespace.
NAKAMURA Takumi [Wed, 15 Jan 2014 08:21:38 +0000 (08:21 +0000)]

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199305 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoreplace LeakSanitizerIsTurnedOffForTheCurrentProcess with __lsan_is_turned_off, but...
Kostya Serebryany [Wed, 15 Jan 2014 07:59:37 +0000 (07:59 +0000)]
replace LeakSanitizerIsTurnedOffForTheCurrentProcess with __lsan_is_turned_off, but this time hide it under __has_feature(address_sanitizer); also include <sanitizer/lsan_interface.h>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199303 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFixed identation.
Elena Demikhovsky [Wed, 15 Jan 2014 07:18:11 +0000 (07:18 +0000)]
Fixed identation.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199301 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix PR18449: SCEV needs more precise max BECount for multi-exit loop.
Andrew Trick [Wed, 15 Jan 2014 06:42:11 +0000 (06:42 +0000)]
Fix PR18449: SCEV needs more precise max BECount for multi-exit loop.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199299 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd OpSize16 to the two byte forms of INC/DEC that we only use in 64-bit mode and...
Craig Topper [Wed, 15 Jan 2014 05:20:59 +0000 (05:20 +0000)]
Add OpSize16 to the two byte forms of INC/DEC that we only use in 64-bit mode and a 64-bit only LEA. Even though we'll not be in 16-bit mode when we use them it makes their tables consistent with their 32-bit counterparts.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199297 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFor AArch64, lowering sext_inreg and generate optimized code by using SXTL.
Jiangning Liu [Wed, 15 Jan 2014 05:08:01 +0000 (05:08 +0000)]
For AArch64, lowering sext_inreg and generate optimized code by using SXTL.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199296 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoSimplify x86 disassembler table handling of when to use TYPE_Rv/TYPE_R16/TYPE_R32...
Craig Topper [Wed, 15 Jan 2014 05:02:02 +0000 (05:02 +0000)]
Simplify x86 disassembler table handling of when to use TYPE_Rv/TYPE_R16/TYPE_R32 now that HasOpSizePrefix only means 16-bit instructions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199295 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoSwitch-to-lookup tables: set threshold to 3 cases
Hans Wennborg [Wed, 15 Jan 2014 05:00:27 +0000 (05:00 +0000)]
Switch-to-lookup tables: set threshold to 3 cases

There has been an old FIXME to find the right cut-off for when it's worth
analyzing and potentially transforming a switch to a lookup table.

The switches always have two or more cases. I could not measure any speed-up
by transforming a switch with two cases. A switch with three cases gets a nice
speed-up, and I couldn't measure any compile-time regression, so I think this
is the right threshold.

In a Clang self-host, this causes 480 new switches to be transformed,
and reduces the final binary size with 8 KB.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199294 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoCheck the error code and save a call to sys::fs::exists.
Rafael Espindola [Wed, 15 Jan 2014 04:49:50 +0000 (04:49 +0000)]
Check the error code and save a call to sys::fs::exists.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199293 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoLoopVectorize: Only strip casts from integer types when replacing symbolic
Arnold Schwaighofer [Wed, 15 Jan 2014 03:35:46 +0000 (03:35 +0000)]
LoopVectorize: Only strip casts from integer types when replacing symbolic

Fixes PR18480.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199291 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix uninitialized variable.
Rafael Espindola [Wed, 15 Jan 2014 03:27:26 +0000 (03:27 +0000)]
Fix uninitialized variable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199288 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoOnly mark functions as micromips.
Rafael Espindola [Wed, 15 Jan 2014 03:07:12 +0000 (03:07 +0000)]
Only mark functions as micromips.

The GNU as behavior is a bit different and very strange. It will mark any
label that contains an instruction. We can implement that, but using the
type looks more natural since gas will not mark a function if a .word is
used to output the instructions!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199287 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoLangRef.rst: fix LangRef data layout text about m specifier, take 2
Hans Wennborg [Wed, 15 Jan 2014 02:49:17 +0000 (02:49 +0000)]
LangRef.rst: fix LangRef data layout text about m specifier, take 2

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199286 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoLangRef: attempt to fix line breaks
Hans Wennborg [Wed, 15 Jan 2014 02:30:37 +0000 (02:30 +0000)]
LangRef: attempt to fix line breaks

The line breaks around the "m:<mangling>" text in the Data Layout section
look weird. Let's see if this helps.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199285 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoPR 18466: Fix ARM Pseudo Expansion
Weiming Zhao [Wed, 15 Jan 2014 01:32:12 +0000 (01:32 +0000)]
PR 18466: Fix ARM Pseudo Expansion

When expanding neon pseudo stores, it may miss the implicit uses of sub
regs, which may cause post RA scheduler reorder instructions that
breakes anti dependency.

For example:
  VST1d64QPseudo %R0<kill>, 16, %Q9_Q10, pred:14, pred:%noreg
  will be expanded to
    VST1d64Q %R0<kill>, 16, %D18, pred:14, pred:%noreg;

An instruction that defines %D20 may be scheduled before the store by

This patches adds implicit uses for such case. For the example above, it
  VST1d64Q %R0<kill>, 8, %D18, pred:14, pred:%noreg, %Q9_Q10<imp-use>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199282 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoMake parseBitcodeFile return an ErrorOr<Module *>.
Rafael Espindola [Wed, 15 Jan 2014 01:08:23 +0000 (01:08 +0000)]
Make parseBitcodeFile return an ErrorOr<Module *>.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199279 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoMake sure we emit a relocation to the debug_ranges section in the
Eric Christopher [Wed, 15 Jan 2014 00:04:29 +0000 (00:04 +0000)]
Make sure we emit a relocation to the debug_ranges section in the
presence of CU ranges.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199276 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoReturn an error_code from materializeAllPermanently.
Rafael Espindola [Tue, 14 Jan 2014 23:51:27 +0000 (23:51 +0000)]
Return an error_code from materializeAllPermanently.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199275 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoUse error_code in Module::materializeAll.
Rafael Espindola [Tue, 14 Jan 2014 23:02:01 +0000 (23:02 +0000)]
Use error_code in Module::materializeAll.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199269 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix Remote MCJIT on Windows
Renato Golin [Tue, 14 Jan 2014 22:59:11 +0000 (22:59 +0000)]
Fix Remote MCJIT on Windows

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199268 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd testcase for r199263 forgotten in commit.
Eric Christopher [Tue, 14 Jan 2014 22:57:52 +0000 (22:57 +0000)]
Add testcase for r199263 forgotten in commit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199267 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoARM: correctly determine final tBX_LR in Thumb1 functions
Tim Northover [Tue, 14 Jan 2014 22:53:28 +0000 (22:53 +0000)]
ARM: correctly determine final tBX_LR in Thumb1 functions

The changes caused by folding an sp-adjustment into a "pop" previously
disrupted the forward search for the final real instruction in a
terminating block. This switches to a backward search (skipping debug

This fixes PR18399.

Patch by Zhaoshi.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199266 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAArch64: don't try to handle [SU]MUL_LOHI nodes
Tim Northover [Tue, 14 Jan 2014 22:53:22 +0000 (22:53 +0000)]
AArch64: don't try to handle [SU]MUL_LOHI nodes

We should set them to expand for now since there are no patterns
dealing with them. Actually, there are no instructions either so I
doubt they'll ever be acceptable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199265 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd the lld root to llvm-lit, so llvm-lit can be used
Joey Gouly [Tue, 14 Jan 2014 22:52:24 +0000 (22:52 +0000)]
Add the lld root to llvm-lit, so llvm-lit can be used
to run lld tests individually.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199264 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoEnable use of ranges for translation units in the presence of
Eric Christopher [Tue, 14 Jan 2014 22:44:17 +0000 (22:44 +0000)]
Enable use of ranges for translation units in the presence of
-ffunction-sections and update comments and TODOs about other
places that we should enable this.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199263 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRe-enable remote MCJIT tests on ARMv7
Renato Golin [Tue, 14 Jan 2014 22:43:49 +0000 (22:43 +0000)]
Re-enable remote MCJIT tests on ARMv7

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199262 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoSanitize MCJIT remote execution
Renato Golin [Tue, 14 Jan 2014 22:43:43 +0000 (22:43 +0000)]
Sanitize MCJIT remote execution

MCJIT remote execution (ChildTarget+RemoteTargetExternal) protocol was in
dire need of refactoring. It was fail-prone, had no error reporting and
implemented the same message logic on every single function.

This patch rectifies it, and makes it work on ARM, where it was randomly
failing. Other architectures shall profit from this change as well, making
their buildbots and releases more reliable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199261 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoDo pointer cast simplifications on addrspacecast
Matt Arsenault [Tue, 14 Jan 2014 20:00:45 +0000 (20:00 +0000)]
Do pointer cast simplifications on addrspacecast

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199254 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRemove a check for an illegal condition.
Matt Arsenault [Tue, 14 Jan 2014 19:56:57 +0000 (19:56 +0000)]
Remove a check for an illegal condition.

Bitcasts can't be between address spaces anymore.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199253 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd FPExt option to CCValAssign::LocInfo. When generating calling-convention
Lang Hames [Tue, 14 Jan 2014 19:56:36 +0000 (19:56 +0000)]
Add FPExt option to CCValAssign::LocInfo. When generating calling-convention
promotion code, Tablegen will now select FPExt for floating point promotions
(previously it had returned AExt, which is not valid for floating point types).

Any out-of-tree targets that were relying on AExt being returned for FP
promotions will need to update their code check for FPExt instead.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199252 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert "[AArch64] Added vselect patterns with float and double types"
Rafael Espindola [Tue, 14 Jan 2014 19:24:08 +0000 (19:24 +0000)]
Revert "[AArch64] Added vselect patterns with float and double types"

This reverts commit r199242.

It is causing CodeGen/AArch64/neon-bsl.ll to fail.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199248 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoMake nocapture analysis work with addrspacecast
Matt Arsenault [Tue, 14 Jan 2014 19:11:52 +0000 (19:11 +0000)]
Make nocapture analysis work with addrspacecast

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199246 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix a low hanging use of hasRawTextSupport.
Rafael Espindola [Tue, 14 Jan 2014 18:57:12 +0000 (18:57 +0000)]
Fix a low hanging use of hasRawTextSupport.

This also fixes the placement of the function label comment. It was being
placed next to the mips16 directive instead of next to the label.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199245 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoReapply "LTO: add API to set strategy for -internalize"
Duncan P. N. Exon Smith [Tue, 14 Jan 2014 18:52:17 +0000 (18:52 +0000)]
Reapply "LTO: add API to set strategy for -internalize"

Reapply r199191, reverted in r199197 because it carelessly broke
Other/link-opts.ll.  The problem was that calling
createInternalizePass("main") would select
createInternalizePass(bool("main")) instead of
createInternalizePass(ArrayRef<const char *>("main")).  This commit
fixes the bug.

The original commit message follows.

Add API to LTOCodeGenerator to specify a strategy for the -internalize

This is a new attempt at Bill's change in r185882, which he reverted in
r188029 due to problems with the gold linker.  This puts the onus on the
linker to decide whether (and what) to internalize.

In particular, running internalize before outputting an object file may
change a 'weak' symbol into an internal one, even though that symbol
could be needed by an external object file --- e.g., with arclite.

This patch enables three strategies:

- LTO_INTERNALIZE_FULL: the default (and the old behaviour).
- LTO_INTERNALIZE_NONE: skip -internalize.
- LTO_INTERNALIZE_HIDDEN: only -internalize symbols with hidden

LTO_INTERNALIZE_FULL should be used when linking an executable.

Outputting an object file (e.g., via ld -r) is more complicated, and
depends on whether hidden symbols should be internalized.  E.g., for
ld -r, LTO_INTERNALIZE_NONE can be used when -keep_private_externs, and
LTO_INTERNALIZE_HIDDEN can be used otherwise.  However,
LTO_INTERNALIZE_FULL is inappropriate, since the output object file will
eventually need to link with others.

lto_codegen_set_internalize_strategy() sets the strategy for subsequent
calls to lto_codegen_write_merged_modules() and lto_codegen_compile*().


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199244 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[AArch64] Added vselect patterns with float and double types
Ana Pazos [Tue, 14 Jan 2014 18:45:48 +0000 (18:45 +0000)]
[AArch64] Added vselect patterns with float and double types

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199242 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoHandle UIDs and GIDs that don't fit in 6 decimal places.
Rafael Espindola [Tue, 14 Jan 2014 17:02:09 +0000 (17:02 +0000)]
Handle UIDs and GIDs that don't fit in 6 decimal places.

Newer unix systems have 32 bit uid and gid types, but the archive format was
not updated. Fortunately, these fields are not normally used. Just truncate
the data to fit in 6 chars.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199223 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoTest case micromips-load-effective-address.s renamed to micromips-load-effective...
Zoran Jovanovic [Tue, 14 Jan 2014 16:26:47 +0000 (16:26 +0000)]
Test case micromips-load-effective-address.s renamed to micromips-load-effective-address.ll and moved to test/CodeGen/Mips.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199221 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoHandle dllexport for global aliases
Nico Rieck [Tue, 14 Jan 2014 15:23:25 +0000 (15:23 +0000)]
Handle dllexport for global aliases

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199219 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoDecouple dllexport/dllimport from linkage
Nico Rieck [Tue, 14 Jan 2014 15:22:47 +0000 (15:22 +0000)]
Decouple dllexport/dllimport from linkage

Representing dllexport/dllimport as distinct linkage types prevents using
these attributes on templates and inline functions.

Instead of introducing further mixed linkage types to include linkonce and
weak ODR, the old import/export linkage types are replaced with a new
separate visibility-like specifier:

  define available_externally dllimport void @f() {}
  @Var = dllexport global i32 1, align 4

Linkage for dllexported globals and functions is now equal to their linkage
without dllexport. Imported globals and functions must be either
declarations with external linkage, or definitions with

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199218 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAVX-512: optimized scalar compare patterns
Elena Demikhovsky [Tue, 14 Jan 2014 15:10:08 +0000 (15:10 +0000)]
AVX-512: optimized scalar compare patterns
removed AVX512SI format, since it is similar to AVX512BI.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199217 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix valgrind warning for gcc builds.
Patrik Hagglund [Tue, 14 Jan 2014 14:09:00 +0000 (14:09 +0000)]
Fix valgrind warning for gcc builds.

Sorry, I don't understand why the warning is generated (a gcc
bug?). Anyhow, the change should improve readablity. No functionality
change intended.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199214 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[X86] Fix assertion failure caused by a wrong folding of vector shifts by immediate...
Andrea Di Biagio [Tue, 14 Jan 2014 13:17:12 +0000 (13:17 +0000)]
[X86] Fix assertion failure caused by a wrong folding of vector shifts by immediate count.

This fixes a regression intruced by r198113.

Revision r198113 introduced an algorithm that tries to fold a vector shift
by immediate count into a build_vector if the input vector is a known vector
of constants.

However the algorithm only worked under the assumption that the input vector
type and the shift type are exactly the same.

This patch disables the folding of vector shift by immediate count if the
input vector type and the shift value type are not the same.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199213 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoARM: add constraint that RdLo != Rn != RdHi for v5 MLA insts.
Tim Northover [Tue, 14 Jan 2014 13:05:47 +0000 (13:05 +0000)]
ARM: add constraint that RdLo != Rn != RdHi for v5 MLA insts.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199212 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoARM: remove unused UMAALv5 node
Tim Northover [Tue, 14 Jan 2014 13:05:42 +0000 (13:05 +0000)]
ARM: remove unused UMAALv5 node

It was incorrect anyway, since it didn't have accumulator inputs and wasn't
even supported on v5.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199211 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert "Decouple dllexport/dllimport from linkage"
Nico Rieck [Tue, 14 Jan 2014 12:38:32 +0000 (12:38 +0000)]
Revert "Decouple dllexport/dllimport from linkage"

Revert this for now until I fix an issue in Clang with it.

This reverts commit r199204.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199207 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert "Handle dllexport for global aliases"
Nico Rieck [Tue, 14 Jan 2014 12:36:54 +0000 (12:36 +0000)]
Revert "Handle dllexport for global aliases"

This reverts commit r199205.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199206 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoHandle dllexport for global aliases
Nico Rieck [Tue, 14 Jan 2014 11:55:40 +0000 (11:55 +0000)]
Handle dllexport for global aliases

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199205 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoDecouple dllexport/dllimport from linkage
Nico Rieck [Tue, 14 Jan 2014 11:55:03 +0000 (11:55 +0000)]
Decouple dllexport/dllimport from linkage

Representing dllexport/dllimport as distinct linkage types prevents using
these attributes on templates and inline functions.

Instead of introducing further mixed linkage types to include linkonce and
weak ODR, the old import/export linkage types are replaced with a new
separate visibility-like specifier:

  define available_externally dllimport void @f() {}
  @Var = dllexport global i32 1, align 4

Linkage for dllexported globals and functions is now equal to their linkage
without dllexport. Imported globals and functions must be either
declarations with external linkage, or definitions with

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199204 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix fastcall mangling of dllimported symbols
Nico Rieck [Tue, 14 Jan 2014 11:53:26 +0000 (11:53 +0000)]
Fix fastcall mangling of dllimported symbols

fastcall requires @ as global prefix instead of _ but getNameWithPrefix
wrongly assumes the OutName buffer is empty and replaces at index 0.
For imported functions this buffer is pre-filled with "__imp_" resulting
in broken "@_imp_foo@0" mangling.

Instead replace at the proper index. We also never have to prepend the
@-prefix because this fastcall mangling is only used on 32-bit Windows
targets which have _ has global prefix.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199203 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert r199191, "LTO: add API to set strategy for -internalize"
NAKAMURA Takumi [Tue, 14 Jan 2014 09:40:18 +0000 (09:40 +0000)]
Revert r199191, "LTO: add API to set strategy for -internalize"

Please update also Other/link-opts.ll, in next time.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199197 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRemove stray comma in enum to satisfy -Wpedantic.
Craig Topper [Tue, 14 Jan 2014 08:07:10 +0000 (08:07 +0000)]
Remove stray comma in enum to satisfy -Wpedantic.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199194 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoSeparate the concept of 16-bit/32-bit operand size controlled by 0x66 prefix and...
Craig Topper [Tue, 14 Jan 2014 07:41:20 +0000 (07:41 +0000)]
Separate the concept of 16-bit/32-bit operand size controlled by 0x66 prefix and the current mode from the concept of SSE instructions using 0x66 prefix as part of their encoding without being affected by the mode.

This should allow SSE instructions to be encoded correctly in 16-bit mode which r198586 probably broke.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199193 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoLTO: add API to set strategy for -internalize
Duncan P. N. Exon Smith [Tue, 14 Jan 2014 06:37:26 +0000 (06:37 +0000)]
LTO: add API to set strategy for -internalize

Add API to LTOCodeGenerator to specify a strategy for the -internalize

This is a new attempt at Bill's change in r185882, which he reverted in
r188029 due to problems with the gold linker.  This puts the onus on the
linker to decide whether (and what) to internalize.

In particular, running internalize before outputting an object file may
change a 'weak' symbol into an internal one, even though that symbol
could be needed by an external object file --- e.g., with arclite.

This patch enables three strategies:

- LTO_INTERNALIZE_FULL: the default (and the old behaviour).
- LTO_INTERNALIZE_NONE: skip -internalize.
- LTO_INTERNALIZE_HIDDEN: only -internalize symbols with hidden

LTO_INTERNALIZE_FULL should be used when linking an executable.

Outputting an object file (e.g., via ld -r) is more complicated, and
depends on whether hidden symbols should be internalized.  E.g., for
ld -r, LTO_INTERNALIZE_NONE can be used when -keep_private_externs, and
LTO_INTERNALIZE_HIDDEN can be used otherwise.  However,
LTO_INTERNALIZE_FULL is inappropriate, since the output object file will
eventually need to link with others.

lto_codegen_set_internalize_strategy() sets the strategy for subsequent
calls to lto_codegen_write_merged_modules() and lto_codegen_compile*().


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199191 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAlways let value types influence register classes.
Jakob Stoklund Olesen [Tue, 14 Jan 2014 06:18:38 +0000 (06:18 +0000)]
Always let value types influence register classes.

When creating a virtual register for a def, the value type should be
used to pick the register class. If we only use the register class
constraint on the instruction, we might pick a too large register class.

Some registers can store values of different sizes. For example, the x86
xmm registers can hold f32, f64, and 128-bit vectors. The three
different value sizes are represented by register classes with identical
register sets: FR32, FR64, and VR128. These register classes have
different spill slot sizes, so it is important to use the right one.

The register class constraint on an instruction doesn't necessarily care
about the size of the value its defining. The value type determines

This fixes a problem where InstrEmitter was picking 32-bit register
classes for 64-bit values on SPARC.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199187 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoSwitch the NEON register class from QPR to DPair.
Jakob Stoklund Olesen [Tue, 14 Jan 2014 06:18:34 +0000 (06:18 +0000)]
Switch the NEON register class from QPR to DPair.

The already allocatable DPair superclass contains odd-even D register
pair in addition to the even-odd pairs in the QPR register class. There
is no reason to constrain the set of D register pairs that can be used
for NEON values. Any NEON instructions that require a Q register will
automatically constrain the register class to QPR.

The allocation order for DPair begins with the QPR registers, so
register allocation is unlikely to change much.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199186 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[PM] Fix stale header blocker, found by Duncan Smith in code review!
Chandler Carruth [Tue, 14 Jan 2014 05:50:19 +0000 (05:50 +0000)]
[PM] Fix stale header blocker, found by Duncan Smith in code review!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199185 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRemove the last weird subproject, 'privbracket'.
Chandler Carruth [Tue, 14 Jan 2014 05:05:18 +0000 (05:05 +0000)]
Remove the last weird subproject, 'privbracket'.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199183 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd checks to configure for sufficiently modern host compilers. This
Chandler Carruth [Tue, 14 Jan 2014 05:02:38 +0000 (05:02 +0000)]
Add checks to configure for sufficiently modern host compilers. This
requires Clang 3.1 or GCC 4.7. If the compiler isn't Clang or GCC, we
don't try to do any sanity checking, but this give us at least
a reasonable baseline of modern compilers.

Also, I'm not claiming that this is the best way to do compiler version
tests. I'm happy for anyone to suggest better ways of doing this test.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199182 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoReplace .mips_hack_stocg with ".set micromips" and ".set nomicromips".
Rafael Espindola [Tue, 14 Jan 2014 04:25:13 +0000 (04:25 +0000)]
Replace .mips_hack_stocg with ".set micromips" and ".set nomicromips".

This matches what gnu as does and implementing this is easier than arguing
about it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199181 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix llc to not reuse spill slots in functions that invoke setjmp()
Mark Seaborn [Tue, 14 Jan 2014 04:20:01 +0000 (04:20 +0000)]
Fix llc to not reuse spill slots in functions that invoke setjmp()

We need to ensure that StackSlotColoring.cpp does not reuse stack
spill slots in functions that call "returns_twice" functions such as
setjmp(), otherwise this can lead to miscompiled code, because a stack
slot would be clobbered when it's still live.

This was already handled correctly for functions that call setjmp()
(though this wasn't covered by a test), but not for functions that
invoke setjmp().

We fix this by changing callsFunctionThatReturnsTwice() to check for
invoke instructions.

This fixes PR18244.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199180 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoOk, really, for the last time, llvm-gcc is dead Jim.
Chandler Carruth [Tue, 14 Jan 2014 04:01:01 +0000 (04:01 +0000)]
Ok, really, for the last time, llvm-gcc is dead Jim.

Also, so is stacker, llvm-tv, etc. Wow.

But will someone please fess up to what projects/privbracket is and why
our autoconf build supports it?

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199179 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agollvm-gcc is dead. REALLY. IT'S DEAD JIM.
Chandler Carruth [Tue, 14 Jan 2014 03:46:00 +0000 (03:46 +0000)]
llvm-gcc is dead. REALLY. IT'S DEAD JIM.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199178 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoMake getTargetStreamer return a possibly null pointer.
Rafael Espindola [Tue, 14 Jan 2014 01:21:46 +0000 (01:21 +0000)]
Make getTargetStreamer return a possibly null pointer.

This will allow it to be called from target independent parts of the main
streamer that don't know if there is a registered target streamer or not. This
in turn will allow targets to perform extra actions at specified points in the
interface: add extra flags for some labels, extra work during finalization, etc.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199174 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRemove extra } in documentation comment
Duncan P. N. Exon Smith [Mon, 13 Jan 2014 23:11:48 +0000 (23:11 +0000)]
Remove extra } in documentation comment

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199162 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoClean up RUN command for Assembler/getInt.ll.
Cameron McInally [Mon, 13 Jan 2014 22:37:35 +0000 (22:37 +0000)]
Clean up RUN command for Assembler/getInt.ll.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199158 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFactor the option and checking of compiler version better. Put the
Chandler Carruth [Mon, 13 Jan 2014 22:21:34 +0000 (22:21 +0000)]
Factor the option and checking of compiler version better. Put the
option with the others in the top level CMakeLists, and put the check in
HandleLLVMOptions. This will also let it be used from the standalone
Clang builds.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199149 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRaise the minimum CMake version to 2.8.8 -- we have a report that the
Chandler Carruth [Mon, 13 Jan 2014 22:05:20 +0000 (22:05 +0000)]
Raise the minimum CMake version to 2.8.8 -- we have a report that the
compiler version checking doesn't work on 2.8.7. This feature was
documented in 2.8.10, but existed for an unknown amount of time before

I'm actually happy to revert this and remove the use of the feature if
there is anyone with a specific problem updating CMake. Please just let
me know. I don't want to re-implement this CMake functionality unless
there is a reason, and this is the only real way to find that out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199148 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix uninitialized warning in llvm/lib/IR/DataLayout.cpp.
Cameron McInally [Mon, 13 Jan 2014 22:04:55 +0000 (22:04 +0000)]
Fix uninitialized warning in llvm/lib/IR/DataLayout.cpp.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199147 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[DAG] Refactor ReassociateOps - no functional change intended.
Juergen Ributzka [Mon, 13 Jan 2014 21:49:25 +0000 (21:49 +0000)]
[DAG] Refactor ReassociateOps - no functional change intended.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199146 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAdd a check that the host compiler is modern to CMake, take 1. This is
Chandler Carruth [Mon, 13 Jan 2014 21:47:35 +0000 (21:47 +0000)]
Add a check that the host compiler is modern to CMake, take 1. This is
likely to be reverted and re-applied a few times. The minimum versions
we're aiming at:

  GCC 4.7
  Clang 3.1
  MSVC 17.0 (Visual Studio 2012)

Let me know if something breaks!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199145 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[DAG] Teach DAG to also reassociate vector operations
Juergen Ributzka [Mon, 13 Jan 2014 20:51:35 +0000 (20:51 +0000)]
[DAG] Teach DAG to also reassociate vector operations

This commit teaches DAG to reassociate vector ops, which in turn enables
constant folding of vector op chains that appear later on during custom lowering
and DAG combine.

Reviewed by Andrea Di Biagio

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199135 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoHide the pre-RA-sched= option.
Andrew Trick [Mon, 13 Jan 2014 20:08:27 +0000 (20:08 +0000)]
Hide the pre-RA-sched= option.

This is a very confusing option for a feature that will go away.

-enable-misched is exposed instead to help triage issues with the new

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199133 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix PR 18369: [Thumbv8] asserts due to inconsistent CPSR liveness of IT blocks
Weiming Zhao [Mon, 13 Jan 2014 18:47:54 +0000 (18:47 +0000)]
Fix PR 18369: [Thumbv8] asserts due to inconsistent CPSR liveness of IT blocks

The issue is caused when Post-RA scheduler reorders a bundle instruction
(IT block). However, it only flips the CPSR liveness of the bundle instruction,
leaves the instructions inside the bundle unchanged, which causes inconstancy and crashes

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199127 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoUpdate getLazyBitcodeModule to use ErrorOr for error handling.
Rafael Espindola [Mon, 13 Jan 2014 18:31:04 +0000 (18:31 +0000)]
Update getLazyBitcodeModule to use ErrorOr for error handling.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199125 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[AArch64] Fix assertion failure caused by an invalid comparison between APInt values.
Andrea Di Biagio [Mon, 13 Jan 2014 16:51:00 +0000 (16:51 +0000)]
[AArch64] Fix assertion failure caused by an invalid comparison between APInt values.

APInt only knows how to compare values with the same BitWidth and asserts
in all other cases.

With this fix, function PerformORCombine does not use the APInt equality
operator if the APInt values returned by 'isConstantSplat' differ in BitWidth.
In that case they are different and no comparison is needed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199119 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoFix indentation.
Joerg Sonnenberger [Mon, 13 Jan 2014 15:50:36 +0000 (15:50 +0000)]
Fix indentation.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199118 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[SystemZ] Flesh out stackrestore test (frame-11.ll)
Richard Sandiford [Mon, 13 Jan 2014 15:44:44 +0000 (15:44 +0000)]
[SystemZ] Flesh out stackrestore test (frame-11.ll)

...so that it does something vaguely sensible.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199117 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[SystemZ] Add "volatile" to a dead store in variable-loc.ll
Richard Sandiford [Mon, 13 Jan 2014 15:42:16 +0000 (15:42 +0000)]
[SystemZ] Add "volatile" to a dead store in variable-loc.ll

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199116 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[SystemZ] Improve risbg-01.ll test
Richard Sandiford [Mon, 13 Jan 2014 15:40:25 +0000 (15:40 +0000)]
[SystemZ] Improve risbg-01.ll test

The old mask in f24 wasn't well chosen because the lshr would always be zero.
CodeGen didn't detect this but InstCombine would.  The new mask ensures
that both shifts are needed.

f26 is specifically testing for a wrap-around mask.  The AND can be applied
to just the shift left, either before or after the shift.  Again, CodeGen
kept it in the original form but InstCombine would mask after the shift
instead.  The exact choice of NILF isn't important for the test so I just
dropped it and kept the rotate.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199115 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[SystemZ] Optimize (sext (ashr (shl ...), ...))
Richard Sandiford [Mon, 13 Jan 2014 15:17:53 +0000 (15:17 +0000)]
[SystemZ] Optimize (sext (ashr (shl ...), ...))

...into (ashr (shl (anyext X), ...), ...), which requires one fewer
instruction.  The (anyext X) can sometimes be simplified too.

I didn't do this in DAGCombiner because widening shifts isn't a win
on all targets.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199114 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agofix a -Wdocumentation warning.
Chris Lattner [Mon, 13 Jan 2014 15:10:11 +0000 (15:10 +0000)]
fix a -Wdocumentation warning.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199113 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoARM: add test for r199108. Oops.
Tim Northover [Mon, 13 Jan 2014 14:20:25 +0000 (14:20 +0000)]
ARM: add test for r199108. Oops.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199109 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoARM: constrain Thumb LDRLIT pseudo-instructions to r0-r7.
Tim Northover [Mon, 13 Jan 2014 14:19:17 +0000 (14:19 +0000)]
ARM: constrain Thumb LDRLIT pseudo-instructions to r0-r7.

Previously we only used GPR for the destination placeholder in "ldr rD, [pc,
incorrect codegen under the integrated assembler.

This should fix both issues (which probably only affect MachO targets at the


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199108 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[x86] Fix retq/retl handling in 64-bit mode
David Woodhouse [Mon, 13 Jan 2014 14:05:59 +0000 (14:05 +0000)]
[x86] Fix retq/retl handling in 64-bit mode

This finishes the job started in r198756, and creates separate opcodes for
64-bit vs. 32-bit versions of the rest of the RET instructions too.

LRETL/LRETQ are interesting... I can't see any justification for their
existence in the SDM. There should be no 'LRETL' in 64-bit mode, and no
need for a REX.W prefix for LRETQ. But this is what GAS does, and my
Sandybridge CPU and an Opteron 6376 concur when tested as follows:

asm __volatile__("pushq $0x1234\nmovq $0x33,%rax\nsalq $32,%rax\norq $1f,%rax\npushq %rax\nlretl $8\n1:");
asm __volatile__("pushq $1234\npushq $0x33\npushq $1f\nlretq $8\n1:");
asm __volatile__("pushq $0x33\npushq $1f\nlretq\n1:");
asm __volatile__("pushq $0x1234\npushq $0x33\npushq $1f\nlretq $8\n1:");

cf. PR8592 and commit r118903, which added LRETQ. I only added LRETIQ to
match it.

I don't quite understand how the Intel syntax parsing for ret
instructions is working, despite r154468 allegedly fixing it. Aren't the
explicitly sized 'retw', 'retd' and 'retq' supposed to work? I have at
least made the 'lretq' work with (and indeed *require*) the 'q'.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199106 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[PM] Split DominatorTree into a concrete analysis result object which
Chandler Carruth [Mon, 13 Jan 2014 13:07:17 +0000 (13:07 +0000)]
[PM] Split DominatorTree into a concrete analysis result object which
can be used by both the new pass manager and the old.

This removes it from any of the virtual mess of the pass interfaces and
lets it derive cleanly from the DominatorTreeBase<> template. In turn,
tons of boilerplate interface can be nuked and it turns into a very
straightforward extension of the base DominatorTree interface.

The old analysis pass is now a simple wrapper. The names and style of
this split should match the split between CallGraph and
CallGraphWrapperPass. All of the users of DominatorTree have been
updated to match using many of the same tricks as with CallGraph. The
goal is that the common type remains the resulting DominatorTree rather
than the pass. This will make subsequent work toward the new pass
manager significantly easier.

Also in numerous places things became cleaner because I switched from
re-running the pass (!!! mid way through some other passes run!!!) to
directly recomputing the domtree.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199104 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[PM][cleanup] Clean up comments and use modern doxygen in this file.
Chandler Carruth [Mon, 13 Jan 2014 13:06:58 +0000 (13:06 +0000)]
[PM][cleanup] Clean up comments and use modern doxygen in this file.
This is a precursor to breaking the pass that computes the DominatorTree
apart from the concrete DominatorTree.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199103 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoAVX-512: Embedded Rounding Control - encoding and printing
Elena Demikhovsky [Mon, 13 Jan 2014 12:55:03 +0000 (12:55 +0000)]
AVX-512: Embedded Rounding Control - encoding and printing
Changed intrinsics for vrcp14/vrcp28 vrsqrt14/vrsqrt28 - aligned with GCC.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199102 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[PM] Fix the const-correctness of the generic DominatorTreeBase to
Chandler Carruth [Mon, 13 Jan 2014 11:58:34 +0000 (11:58 +0000)]
[PM] Fix the const-correctness of the generic DominatorTreeBase to
support notionally const queries even though they may trigger DFS
numbering updates.

The updating of DFS numbers and tracking of slow queries do not mutate
the observable state of the domtree. They should be const to
differentiate them from the APIs which mutate the tree directly to do
incremental updates.

This will make it possible in a world where the DominatorTree is not
a pass but merely the result of running a pass to derive DominatorTree
from the base class as it was originally designed, removing a huge
duplication of API in DominatorTree.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199101 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[PM] Pull the generic graph algorithms and data structures for dominator
Chandler Carruth [Mon, 13 Jan 2014 10:52:56 +0000 (10:52 +0000)]
[PM] Pull the generic graph algorithms and data structures for dominator
trees into the Support library.

These are all expressed in terms of the generic GraphTraits and CFG,
with no reliance on any concrete IR types. Putting them in support
clarifies that and makes the fact that the static analyzer in Clang uses
them much more sane. When moving the Dominators.h file into the IR
library I claimed that this was the right home for it but not something
I planned to work on. Oops.

So why am I doing this? It happens to be one step toward breaking the
requirement that IR verification can only be performed from inside of
a pass context, which completely blocks the implementation of
verification for the new pass manager infrastructure. Fixing it will
also allow removing the concept of the "preverify" step (WTF???) and
allow the verifier to cleanly flag functions which fail verification in
a way that precludes even computing dominance information. Currently,
that results in a fatal error even when you ask the verifier to not
fatally error. It's awesome like that.

The yak shaving will continue...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199095 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoRevert "ReMat: fix overly cavalier attitude to sub-register indices"
Tim Northover [Mon, 13 Jan 2014 10:49:11 +0000 (10:49 +0000)]
Revert "ReMat: fix overly cavalier attitude to sub-register indices"

Very sorry, this was a premature patch that I still need to investigate and
finish off (for some reason beyond me at the moment it doesn't actually fix the
issue in all cases).

This reverts commit r199091.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199093 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoDocs: fix sign of division and increase equivocation on code generated.
Tim Northover [Mon, 13 Jan 2014 10:47:04 +0000 (10:47 +0000)]
Docs: fix sign of division and increase equivocation on code generated.

I should have been a politician.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199092 91177308-0d34-0410-b5e6-96231b3b80d8

8 years agoReMat: fix overly cavalier attitude to sub-register indices
Tim Northover [Mon, 13 Jan 2014 10:47:01 +0000 (10:47 +0000)]
ReMat: fix overly cavalier attitude to sub-register indices

There are two attempted optimisations in reMaterializeTrivialDef, trying to
avoid promoting the size of a register too much when rematerializing.
Unfortunately, both appear to be flawed. First, we see if the original register
would have worked, but this is inadequate. Consider:

    v1 = SOMETHING (v1 is QQ)
    v2:Q0 = COPY v1:Q1 (v1, v2 are QQ)
    uses of v2

In this case even though v2 *could* be used directly as the output of
SOMETHING, this would set the wrong bits of the QQ register involved. The
correct rematerialization must be:

    v2:Q0_Q1 = SOMETHING (v2 promoted to QQQ)
    uses of v2:Q1_Q2

For the second optimisation, if the correct remat is "v2:idx = SOMETHING" then
we can't necessarily expect v2 itself to be valid for SOMETHING, but we do try
to hunt for a class between v1 and v2 that works. Unfortunately, this is also

    v1 = SOMETHING (v1 is QQ)
    v2:Q0_Q1 = COPY v1 (v1 is QQ, v2 is QQQ)
    uses of v2 as a QQQ

The canonical rematerialization here is "v2:Q0_Q1 = SOMETHING". However current
logic would decide that v2 could be a QQ (no interest is taken in later uses).

This patch, therefore, always accepts the widened register class without trying
to be clever. Generally there is no penalty to this (e.g. in the common GR32 <
GR64 case, expanding the width doesn't matter because it's not like you were
going to do anything else with the high bits of a GR32 register). It can
increase register pressure in cases like the ARM VFP regs though (multiple
non-overlapping but equivalent subregisters). Hopefully this situation is rare
enough that it won't matter.

Unfortunately, no in-tree targets actually expose this as far as I can tell
(there are so few isAsCheapAsAMove instructions for it to trigger on) so I've
been unable to produce a test. It was exposed in our ARM64 SPEC tests though,
and I will be adding a test there that we should be able to contribute

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199091 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[cleanup] Re-sort the examples #include lines with my sort_includes
Chandler Carruth [Mon, 13 Jan 2014 09:58:03 +0000 (09:58 +0000)]
[cleanup] Re-sort the examples #include lines with my sort_includes

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199089 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[cleanup] Fix the includes in the examples for r199082.
Chandler Carruth [Mon, 13 Jan 2014 09:53:45 +0000 (09:53 +0000)]
[cleanup] Fix the includes in the examples for r199082.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199087 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[cleanup] Switch comments to use '\brief' style instead of '@brief'
Chandler Carruth [Mon, 13 Jan 2014 09:31:09 +0000 (09:31 +0000)]
[cleanup] Switch comments to use '\brief' style instead of '@brief'
style, and remove some unnecessary comments (the code is perfectly
self-documenting here). Also clang-format the function declarations as
they wrap cleanly now.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199084 91177308-0d34-0410-b5e6-96231b3b80d8

8 years ago[cleanup] Move the Dominators.h and Verifier.h headers into the IR
Chandler Carruth [Mon, 13 Jan 2014 09:26:24 +0000 (09:26 +0000)]
[cleanup] Move the Dominators.h and Verifier.h headers into the IR
directory. These passes are already defined in the IR library, and it
doesn't make any sense to have the headers in Analysis.

Long term, I think there is going to be a much better way to divide
these matters. The dominators code should be fully separated into the
abstract graph algorithm and have that put in Support where it becomes
obvious that evn Clang's CFGBlock's can use it. Then the verifier can
manually construct dominance information from the Support-driven
interface while the Analysis library can provide a pass which both
caches, reconstructs, and supports a nice update API.

But those are very long term, and so I don't want to leave the really
confusing structure until that day arrives.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199082 91177308-0d34-0410-b5e6-96231b3b80d8