From: Torok Edwin <edwintorok@gmail.com>
Date: Thu, 10 Dec 2009 10:01:47 +0000 (+0000)
Subject: Comparing std::string with NULL is a bad idea, so just check whether its empty.
X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=f05e45eb373a47054cd569e9bf727f71109be382

Comparing std::string with NULL is a bad idea, so just check whether its empty.

This code was crashing always with oprofile enabled, since it tried to create a StringRef
out of NULL, which run strlen on NULL.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@91046 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp b/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
index 076e5a0ce7b..52a8f71ca34 100644
--- a/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
+++ b/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
@@ -76,7 +76,7 @@ class FilenameCache {
  public:
   const char *getFilename(MDNode *Scope) {
     std::string &Filename = Filenames[Scope];
-    if (Filename == NULL) {
+    if (Filename.empty()) {
       DIScope S(Scope);
       Filename = S.getFilename();
     }