From: Benjamin Kramer Date: Sat, 28 Nov 2015 21:43:12 +0000 (+0000) Subject: [SimplifyLibCalls] Fix inverted condition that lead to an uninitialized memory read... X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=d3af7cc9d903bf272e3c318e1c0cb40c3001714b [SimplifyLibCalls] Fix inverted condition that lead to an uninitialized memory read below. Found by msan! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254238 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Utils/SimplifyLibCalls.cpp b/lib/Transforms/Utils/SimplifyLibCalls.cpp index 67e1697c7da..8389e39f7af 100644 --- a/lib/Transforms/Utils/SimplifyLibCalls.cpp +++ b/lib/Transforms/Utils/SimplifyLibCalls.cpp @@ -1454,8 +1454,8 @@ LibCallSimplifier::classifyArgUse(Value *Val, BasicBlock *BB, bool IsFloat, Function *Callee = CI->getCalledFunction(); LibFunc::Func Func; - if (Callee && (!TLI->getLibFunc(Callee->getName(), Func) || !TLI->has(Func) || - !isTrigLibCall(CI))) + if (!Callee || !TLI->getLibFunc(Callee->getName(), Func) || !TLI->has(Func) || + !isTrigLibCall(CI)) return; if (IsFloat) {