From: Jordan Rose Date: Thu, 6 Dec 2012 19:01:24 +0000 (+0000) Subject: Allow modifying an ImmutableMap without canonicalizing it immediately. X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=972f087dbbc233bff9270716f2af453b90a996d9 Allow modifying an ImmutableMap without canonicalizing it immediately. This is an alternative to the ImmutableMapRef interface where a factory should still be canonicalizing by default, but in certain cases an improvement can be made by delaying the canonicalization. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@169532 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/ADT/ImmutableMap.h b/include/llvm/ADT/ImmutableMap.h index 4883c5ba0a6..0043dc6f000 100644 --- a/include/llvm/ADT/ImmutableMap.h +++ b/include/llvm/ADT/ImmutableMap.h @@ -96,27 +96,40 @@ public: class Factory { typename TreeTy::Factory F; - const bool Canonicalize; + const bool Canonicalizing; public: Factory(bool canonicalize = true) - : Canonicalize(canonicalize) {} + : Canonicalizing(canonicalize) {} Factory(BumpPtrAllocator& Alloc, bool canonicalize = true) - : F(Alloc), Canonicalize(canonicalize) {} + : F(Alloc), Canonicalizing(canonicalize) {} ImmutableMap getEmptyMap() { return ImmutableMap(F.getEmptyTree()); } - ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D) { + ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D, + bool Canonicalize) { TreeTy *T = F.add(Old.Root, std::pair(K,D)); return ImmutableMap(Canonicalize ? F.getCanonicalTree(T): T); } - ImmutableMap remove(ImmutableMap Old, key_type_ref K) { + ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D) { + return add(Old, K, D, Canonicalizing); + } + + ImmutableMap remove(ImmutableMap Old, key_type_ref K, bool Canonicalize) { TreeTy *T = F.remove(Old.Root,K); return ImmutableMap(Canonicalize ? F.getCanonicalTree(T): T); } + ImmutableMap remove(ImmutableMap Old, key_type_ref K) { + return remove(Old, K, Canonicalizing); + } + + ImmutableMap getCanonicalMap(ImmutableMap Map) { + return ImmutableMap(F.getCanonicalTree(Map.Root)); + } + typename TreeTy::Factory *getTreeFactory() const { return const_cast(&F); }