From: Philip Reames <listmail@philipreames.com>
Date: Thu, 10 Sep 2015 00:32:56 +0000 (+0000)
Subject: [RewriteStatepointsForGC] Strengthen a confusingly weak assertion [NFC]
X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=3f0fe63960acd6d1aa5a9eae538d134931c937e0

[RewriteStatepointsForGC] Strengthen a confusingly weak assertion [NFC]

The assertion was weaker than it should be and gave the impression we're growing the number of base defining values being considered during the fixed point interation.  That's not true.  The tighter form of the assert is useful documentation.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247221 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
index 22baeddc1a5..57687def2d9 100644
--- a/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
+++ b/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
@@ -797,7 +797,7 @@ static Value *findBasePointer(Value *I, DefiningValueMapTy &cache) {
   bool progress = true;
   while (progress) {
 #ifndef NDEBUG
-    size_t oldSize = States.size();
+    const size_t oldSize = States.size();
 #endif
     progress = false;
     // We're only changing values in this loop, thus safe to keep iterators.
@@ -842,8 +842,8 @@ static Value *findBasePointer(Value *I, DefiningValueMapTy &cache) {
       }
     }
 
-    assert(oldSize <= States.size());
-    assert(oldSize == States.size() || progress);
+    assert(oldSize == States.size() &&
+           "fixed point shouldn't be adding any new nodes to state");
   }
 
 #ifndef NDEBUG