From: Chris Bieneman Date: Thu, 3 Dec 2015 22:51:08 +0000 (+0000) Subject: [CMake] set_target_properties doesn't append link flags X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=2ffa666beca8a55cafb5f0bac88671fec7645626 [CMake] set_target_properties doesn't append link flags This fixes a bug introduced in r254627, and another occurance of the same bug in this file. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254657 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/cmake/modules/AddLLVM.cmake b/cmake/modules/AddLLVM.cmake index 97ac96ed428..e121da6786d 100644 --- a/cmake/modules/AddLLVM.cmake +++ b/cmake/modules/AddLLVM.cmake @@ -667,7 +667,7 @@ function(export_executable_symbols target) if (NOT MSVC) # MSVC's linker doesn't support exporting all symbols. set_target_properties(${target} PROPERTIES ENABLE_EXPORTS 1) if (APPLE) - set_target_properties(${target} PROPERTIES + set_property(TARGET ${target} APPEND_STRING PROPERTY LINK_FLAGS "-rdynamic") endif() endif() @@ -1185,8 +1185,8 @@ function(llvm_externalize_debuginfo name) OR CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-flto") set(lto_object ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${name}-lto.o) - set_target_properties(${name} PROPERTIES - LINK_FLAGS "-Wl,-object_path_lto -Wl,${lto_object}") + set_property(TARGET ${name} APPEND_STRING PROPERTY + LINK_FLAGS " -Wl,-object_path_lto,${lto_object}") endif() add_custom_command(TARGET ${name} POST_BUILD COMMAND xcrun dsymutil $