From: Xinliang David Li Date: Wed, 18 Nov 2015 22:42:27 +0000 (+0000) Subject: Minor cleanups (from review feedback) X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=2d31815e4b04b49ebb66fe86a05acdbd246d02b1 Minor cleanups (from review feedback) 1. remove uneeded header inclusion 2. use reinterpret_cast instead of c ctyle 3. other format change git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253515 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/ProfileData/InstrProfReader.h b/include/llvm/ProfileData/InstrProfReader.h index c1d17c27158..f58000c3057 100644 --- a/include/llvm/ProfileData/InstrProfReader.h +++ b/include/llvm/ProfileData/InstrProfReader.h @@ -20,12 +20,11 @@ #include "llvm/ProfileData/InstrProf.h" #include "llvm/Support/EndianStream.h" #include "llvm/Support/ErrorOr.h" -#include "llvm/Support/raw_ostream.h" #include "llvm/Support/LineIterator.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/OnDiskHashTable.h" +#include "llvm/Support/raw_ostream.h" #include -#include namespace llvm { @@ -186,13 +185,15 @@ private: return NamesStart + Offset; } const uint8_t *getValueDataCounts(IntPtrT ValueCountsPtr) const { - ptrdiff_t Offset = (swap(ValueCountsPtr) - ValueDataDelta) / sizeof(uint8_t); + ptrdiff_t Offset = + (swap(ValueCountsPtr) - ValueDataDelta) / sizeof(uint8_t); return ValueDataStart + Offset; } // This accepts an already byte-swapped ValueDataPtr argument. const InstrProfValueData *getValueData(IntPtrT ValueDataPtr) const { ptrdiff_t Offset = (ValueDataPtr - ValueDataDelta) / sizeof(uint8_t); - return reinterpret_cast(ValueDataStart + Offset); + return reinterpret_cast(ValueDataStart + + Offset); } }; diff --git a/lib/ProfileData/InstrProfReader.cpp b/lib/ProfileData/InstrProfReader.cpp index 8a0354dc98c..fe52e1312ef 100644 --- a/lib/ProfileData/InstrProfReader.cpp +++ b/lib/ProfileData/InstrProfReader.cpp @@ -255,7 +255,8 @@ template std::error_code RawInstrProfReader::readName(InstrProfRecord &Record) { Record.Name = StringRef(getName(Data->NamePtr), swap(Data->NameSize)); if (Record.Name.data() < NamesStart || - Record.Name.data() + Record.Name.size() > (char*)ValueDataStart) + Record.Name.data() + Record.Name.size() > + reinterpret_cast(ValueDataStart)) return error(instrprof_error::malformed); return success(); } @@ -311,7 +312,8 @@ std::error_code RawInstrProfReader::readValueData( auto VDataCounts = makeArrayRef(getValueDataCounts(Data->Values), NumVSites); // Check bounds. if (VDataCounts.data() < ValueDataStart || - VDataCounts.data() + VDataCounts.size() > (const uint8_t *)ProfileEnd) + VDataCounts.data() + VDataCounts.size() > + reinterpret_cast(ProfileEnd)) return error(instrprof_error::malformed); const InstrProfValueData *VDataPtr =