From: Chris Lattner <sabre@nondot.org>
Date: Thu, 25 Feb 2010 00:03:03 +0000 (+0000)
Subject: add a fixme for an experiment that defeated me for the time being.
X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=2a1263b1e1d1bc1ef1f1cd834b6e3ca4b82daea7

add a fixme for an experiment that defeated me for the time being.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@97081 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/utils/TableGen/DAGISelMatcherGen.cpp b/utils/TableGen/DAGISelMatcherGen.cpp
index 9727c5f0dd1..c070e442dbd 100644
--- a/utils/TableGen/DAGISelMatcherGen.cpp
+++ b/utils/TableGen/DAGISelMatcherGen.cpp
@@ -490,6 +490,10 @@ void MatcherGen::EmitMatchCode(const TreePatternNode *N,
 void MatcherGen::EmitMatcherCode() {
   // If the pattern has a predicate on it (e.g. only enabled when a subtarget
   // feature is around, do the check).
+  // FIXME: This should get emitted after the match code below to encourage
+  // sharing.  This can't happen until we get an X86ISD::AddrMode node made by
+  // dag combine, eliminating the horrible side-effect-full stuff from 
+  // X86's MatchAddress.
   if (!Pattern.getPredicateCheck().empty())
     AddMatcherNode(new 
                  CheckPatternPredicateMatcherNode(Pattern.getPredicateCheck()));