From: Daniel Sanders Date: Sat, 1 Nov 2014 18:13:52 +0000 (+0000) Subject: [mips] Remove MipsCC::CCInfo. NFC. X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=commitdiff_plain;h=20dc67702180b43dcda1c858042647cce5745952 [mips] Remove MipsCC::CCInfo. NFC. Summary: It's now passed in as an argument to functions that need it. Eventually this argument will be replaced by the 'this' pointer for a MipsCCState object. Depends on D5966 Reviewers: vmedic Reviewed By: vmedic Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D5967 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@221054 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/Mips/MipsISelLowering.cpp b/lib/Target/Mips/MipsISelLowering.cpp index b61b74dfb68..8bc216021ad 100644 --- a/lib/Target/Mips/MipsISelLowering.cpp +++ b/lib/Target/Mips/MipsISelLowering.cpp @@ -2550,9 +2550,8 @@ MipsTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI, *DAG.getContext()); MipsCC MipsCCInfo(CallConv, Subtarget, CCInfo); - MipsCCInfo.analyzeCallOperands(Outs, IsVarArg, - Subtarget.abiUsesSoftFloat(), - Callee.getNode(), CLI.getArgs()); + MipsCCInfo.analyzeCallOperands(Outs, IsVarArg, Subtarget.abiUsesSoftFloat(), + Callee.getNode(), CLI.getArgs(), CCInfo); // Get a count of how many bytes are to be pushed on the stack. unsigned NextStackOffset = CCInfo.getNextStackOffset(); @@ -2837,7 +2836,7 @@ MipsTargetLowering::LowerFormalArguments(SDValue Chain, DAG.getMachineFunction().getFunction()->arg_begin(); bool UseSoftFloat = Subtarget.abiUsesSoftFloat(); - MipsCCInfo.analyzeFormalArguments(Ins, UseSoftFloat, FuncArg); + MipsCCInfo.analyzeFormalArguments(Ins, UseSoftFloat, FuncArg, CCInfo); MipsFI->setFormalArgInfo(CCInfo.getNextStackOffset(), MipsCCInfo.hasByValArg()); @@ -2943,7 +2942,7 @@ MipsTargetLowering::LowerFormalArguments(SDValue Chain, } if (IsVarArg) - writeVarArgRegs(OutChains, MipsCCInfo, Chain, DL, DAG); + writeVarArgRegs(OutChains, MipsCCInfo, Chain, DL, DAG, CCInfo); // All stores are grouped in one node to allow the matching between // the size of Ins and InVals. This only happens when on varg functions @@ -3532,16 +3531,15 @@ MipsTargetLowering::MipsCC::getSpecialCallingConv(const SDNode *Callee) const { MipsTargetLowering::MipsCC::MipsCC(CallingConv::ID CC, const MipsSubtarget &Subtarget_, CCState &Info) - : CCInfo(Info), CallConv(CC), Subtarget(Subtarget_) { + : CallConv(CC), Subtarget(Subtarget_) { // Pre-allocate reserved argument area. - CCInfo.AllocateStack(reservedArgArea(), 1); + Info.AllocateStack(reservedArgArea(), 1); } - -void MipsTargetLowering::MipsCC:: -analyzeCallOperands(const SmallVectorImpl &Args, - bool IsVarArg, bool IsSoftFloat, const SDNode *CallNode, - std::vector &FuncArgs) { +void MipsTargetLowering::MipsCC::analyzeCallOperands( + const SmallVectorImpl &Args, bool IsVarArg, + bool IsSoftFloat, const SDNode *CallNode, + std::vector &FuncArgs, CCState &State) { MipsCC::SpecialCallingConvType SpecialCallingConv = getSpecialCallingConv(CallNode); assert((CallConv != CallingConv::Fast || !IsVarArg) && @@ -3559,16 +3557,16 @@ analyzeCallOperands(const SmallVectorImpl &Args, bool R; if (ArgFlags.isByVal()) { - handleByValArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags); + handleByValArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, State); continue; } if (IsVarArg && !Args[I].IsFixed) - R = CC_Mips_VarArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, CCInfo); + R = CC_Mips_VarArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, State); else { MVT RegVT = getRegVT(ArgVT, FuncArgs[Args[I].OrigArgIndex].Ty, CallNode, IsSoftFloat); - R = FixedFn(I, ArgVT, RegVT, CCValAssign::Full, ArgFlags, CCInfo); + R = FixedFn(I, ArgVT, RegVT, CCValAssign::Full, ArgFlags, State); } if (R) { @@ -3581,9 +3579,9 @@ analyzeCallOperands(const SmallVectorImpl &Args, } } -void MipsTargetLowering::MipsCC:: -analyzeFormalArguments(const SmallVectorImpl &Args, - bool IsSoftFloat, Function::const_arg_iterator FuncArg) { +void MipsTargetLowering::MipsCC::analyzeFormalArguments( + const SmallVectorImpl &Args, bool IsSoftFloat, + Function::const_arg_iterator FuncArg, CCState &State) { unsigned NumArgs = Args.size(); unsigned CurArgIdx = 0; @@ -3594,13 +3592,13 @@ analyzeFormalArguments(const SmallVectorImpl &Args, CurArgIdx = Args[I].OrigArgIndex; if (ArgFlags.isByVal()) { - handleByValArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags); + handleByValArg(I, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, State); continue; } MVT RegVT = getRegVT(ArgVT, FuncArg->getType(), nullptr, IsSoftFloat); - if (!CC_Mips_FixedArg(I, ArgVT, RegVT, CCValAssign::Full, ArgFlags, CCInfo)) + if (!CC_Mips_FixedArg(I, ArgVT, RegVT, CCValAssign::Full, ArgFlags, State)) continue; #ifndef NDEBUG @@ -3614,7 +3612,8 @@ analyzeFormalArguments(const SmallVectorImpl &Args, void MipsTargetLowering::MipsCC::handleByValArg(unsigned ValNo, MVT ValVT, MVT LocVT, CCValAssign::LocInfo LocInfo, - ISD::ArgFlagsTy ArgFlags) { + ISD::ArgFlagsTy ArgFlags, + CCState &State) { assert(ArgFlags.getByValSize() && "Byval argument's size shouldn't be 0."); struct ByValArgInfo ByVal; @@ -3625,13 +3624,13 @@ void MipsTargetLowering::MipsCC::handleByValArg(unsigned ValNo, MVT ValVT, RegSizeInBytes * 2); if (useRegsForByval()) - allocateRegs(ByVal, ByValSize, Align); + allocateRegs(ByVal, ByValSize, Align, State); // Allocate space on caller's stack. ByVal.Address = - CCInfo.AllocateStack(ByValSize - RegSizeInBytes * ByVal.NumRegs, Align); - CCInfo.addLoc(CCValAssign::getMem(ValNo, ValVT, ByVal.Address, LocVT, - LocInfo)); + State.AllocateStack(ByValSize - RegSizeInBytes * ByVal.NumRegs, Align); + State.addLoc( + CCValAssign::getMem(ValNo, ValVT, ByVal.Address, LocVT, LocInfo)); ByValArgs.push_back(ByVal); } @@ -3651,7 +3650,7 @@ const MCPhysReg *MipsTargetLowering::MipsCC::shadowRegs() const { void MipsTargetLowering::MipsCC::allocateRegs(ByValArgInfo &ByVal, unsigned ByValSize, - unsigned Align) { + unsigned Align, CCState &State) { unsigned RegSizeInBytes = Subtarget.getGPRSizeInBytes(); const ArrayRef IntArgRegs = intArgRegs(); const MCPhysReg *ShadowRegs = shadowRegs(); @@ -3660,18 +3659,18 @@ void MipsTargetLowering::MipsCC::allocateRegs(ByValArgInfo &ByVal, "RegSizeInBytes."); ByVal.FirstIdx = - CCInfo.getFirstUnallocated(IntArgRegs.data(), IntArgRegs.size()); + State.getFirstUnallocated(IntArgRegs.data(), IntArgRegs.size()); // If Align > RegSizeInBytes, the first arg register must be even. if ((Align > RegSizeInBytes) && (ByVal.FirstIdx % 2)) { - CCInfo.AllocateReg(IntArgRegs[ByVal.FirstIdx], ShadowRegs[ByVal.FirstIdx]); + State.AllocateReg(IntArgRegs[ByVal.FirstIdx], ShadowRegs[ByVal.FirstIdx]); ++ByVal.FirstIdx; } // Mark the registers allocated. for (unsigned I = ByVal.FirstIdx; ByValSize && (I < IntArgRegs.size()); ByValSize -= RegSizeInBytes, ++I, ++ByVal.NumRegs) - CCInfo.AllocateReg(IntArgRegs[I], ShadowRegs[I]); + State.AllocateReg(IntArgRegs[I], ShadowRegs[I]); } MVT MipsTargetLowering::MipsCC::getRegVT(MVT VT, const Type *OrigTy, @@ -3834,10 +3833,10 @@ passByValArg(SDValue Chain, SDLoc DL, void MipsTargetLowering::writeVarArgRegs(std::vector &OutChains, const MipsCC &CC, SDValue Chain, - SDLoc DL, SelectionDAG &DAG) const { + SDLoc DL, SelectionDAG &DAG, + CCState &State) const { const ArrayRef ArgRegs = CC.intArgRegs(); - const CCState &CCInfo = CC.getCCInfo(); - unsigned Idx = CCInfo.getFirstUnallocated(ArgRegs.data(), ArgRegs.size()); + unsigned Idx = State.getFirstUnallocated(ArgRegs.data(), ArgRegs.size()); unsigned RegSizeInBytes = Subtarget.getGPRSizeInBytes(); MVT RegTy = MVT::getIntegerVT(RegSizeInBytes * 8); const TargetRegisterClass *RC = getRegClassFor(RegTy); @@ -3850,7 +3849,7 @@ void MipsTargetLowering::writeVarArgRegs(std::vector &OutChains, if (ArgRegs.size() == Idx) VaArgOffset = - RoundUpToAlignment(CCInfo.getNextStackOffset(), RegSizeInBytes); + RoundUpToAlignment(State.getNextStackOffset(), RegSizeInBytes); else VaArgOffset = (int)CC.reservedArgArea() - (int)(RegSizeInBytes * (ArgRegs.size() - Idx)); diff --git a/lib/Target/Mips/MipsISelLowering.h b/lib/Target/Mips/MipsISelLowering.h index a35946dac3c..1b4872528d4 100644 --- a/lib/Target/Mips/MipsISelLowering.h +++ b/lib/Target/Mips/MipsISelLowering.h @@ -362,12 +362,12 @@ namespace llvm { void analyzeCallOperands(const SmallVectorImpl &Outs, bool IsVarArg, bool IsSoftFloat, const SDNode *CallNode, - std::vector &FuncArgs); + std::vector &FuncArgs, + CCState &State); void analyzeFormalArguments(const SmallVectorImpl &Ins, bool IsSoftFloat, - Function::const_arg_iterator FuncArg); - - const CCState &getCCInfo() const { return CCInfo; } + Function::const_arg_iterator FuncArg, + CCState &State); /// hasByValArg - Returns true if function has byval arguments. bool hasByValArg() const { return !ByValArgs.empty(); } @@ -386,7 +386,7 @@ namespace llvm { private: void handleByValArg(unsigned ValNo, MVT ValVT, MVT LocVT, CCValAssign::LocInfo LocInfo, - ISD::ArgFlagsTy ArgFlags); + ISD::ArgFlagsTy ArgFlags, CCState &State); /// useRegsForByval - Returns true if the calling convention allows the /// use of registers to pass byval arguments. @@ -394,8 +394,8 @@ namespace llvm { const MCPhysReg *shadowRegs() const; - void allocateRegs(ByValArgInfo &ByVal, unsigned ByValSize, - unsigned Align); + void allocateRegs(ByValArgInfo &ByVal, unsigned ByValSize, unsigned Align, + CCState &State); /// Return the type of the register which is used to pass an argument or /// return a value. This function returns f64 if the argument is an i64 @@ -410,7 +410,6 @@ namespace llvm { SpecialCallingConvType getSpecialCallingConv(const SDNode *Callee) const; - CCState &CCInfo; CallingConv::ID CallConv; const MipsSubtarget &Subtarget; SmallVector ByValArgs; @@ -504,7 +503,8 @@ namespace llvm { /// to the stack. Also create a stack frame object for the first variable /// argument. void writeVarArgRegs(std::vector &OutChains, const MipsCC &CC, - SDValue Chain, SDLoc DL, SelectionDAG &DAG) const; + SDValue Chain, SDLoc DL, SelectionDAG &DAG, + CCState &State) const; SDValue LowerFormalArguments(SDValue Chain,