Don't call getAsUnsignedInteger directly, it fails to compile if uint64_t is not...
authorBenjamin Kramer <benny.kra@googlemail.com>
Wed, 3 Oct 2012 18:54:36 +0000 (18:54 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Wed, 3 Oct 2012 18:54:36 +0000 (18:54 +0000)
while there add more test cases.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@165140 91177308-0d34-0410-b5e6-96231b3b80d8

unittests/ADT/StringRefTest.cpp

index 59eed54f0342e0ab6c5f2ca9b1a5512a3c5c2166..e9c017babfc55e0222a79d4d02330c72dab945ce 100644 (file)
@@ -462,13 +462,17 @@ static const char* BadStrings[] = {
   , "123456789012345678901" // value way too large
   , "4t23v"                 // illegal decimal characters
   , "0x123W56"              // illegal hex characters
+  , "0b2"                   // illegal bin characters
+  , "08"                    // illegal oct characters
+  , "0o8"                   // illegal oct characters
+  , "-123"                  // negative unsigned value
 };
 
 
 TEST(StringRefTest, getAsUnsignedIntegerBadStrings) {
   uint64_t U64;
   for (size_t i = 0; i < array_lengthof(BadStrings); ++i) {
-    bool IsBadNumber = getAsUnsignedInteger(BadStrings[i], 0, U64);
+    bool IsBadNumber = StringRef(BadStrings[i]).getAsInteger(0, U64);
     ASSERT_TRUE(IsBadNumber);
   }
 }