[PGO] Simplify string parsing

Patch Suggested by Vedant.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@256785 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/ProfileData/InstrProf.cpp b/lib/ProfileData/InstrProf.cpp
index bcb248e8305b314c437a99afdb62bc81ffedaeb4..027f0f78c54616af0fa480642d091dfc07b82fae 100644 (file)
--- a/lib/ProfileData/InstrProf.cpp
+++ b/lib/ProfileData/InstrProf.cpp
@@ -245,20 +245,10 @@ int readPGOFuncNameStrings(StringRef NameStrings, InstrProfSymtab &Symtab) {
       P += UncompressedSize;
     }
     // Now parse the name strings.
       P += UncompressedSize;
     }
     // Now parse the name strings.

-    size_t NameStart = 0;
-    bool isLast = false;
-    do {
-      size_t NameStop = NameStrings.find(' ', NameStart);
-      if (NameStop == StringRef::npos)
-        NameStop = NameStrings.size();
-      if (NameStop >= NameStrings.size() - 1)
-        isLast = true;
-      StringRef Name = NameStrings.substr(NameStart, NameStop - NameStart);
+    SmallVector<StringRef, 0> Names;
+    NameStrings.split(Names, ' ');
+    for (StringRef &Name : Names)

       Symtab.addFuncName(Name);
       Symtab.addFuncName(Name);

-      if (isLast)
-        break;
-      NameStart = NameStop + 1;
-    } while (true);

 
     while (P < EndP && *P == 0)
       P++;
 
     while (P < EndP && *P == 0)
       P++;