Add assembler fatal error for undefined assembler labels in COFF writer
authorReid Kleckner <rnk@google.com>
Wed, 16 Sep 2015 16:26:29 +0000 (16:26 +0000)
committerReid Kleckner <rnk@google.com>
Wed, 16 Sep 2015 16:26:29 +0000 (16:26 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247814 91177308-0d34-0410-b5e6-96231b3b80d8

lib/MC/WinCOFFObjectWriter.cpp
test/MC/COFF/label-undefined.s [new file with mode: 0644]

index 6c696738b48bf873889038cc1d9523d17f681e87..f251942161d81bc2801fc72d0433c655044e62cb 100644 (file)
@@ -710,6 +710,11 @@ void WinCOFFObjectWriter::recordRelocation(
     Asm.getContext().reportFatalError(Fixup.getLoc(),
                                       Twine("symbol '") + A.getName() +
                                           "' can not be undefined");
+  if (A.isTemporary() && A.isUndefined()) {
+    Asm.getContext().reportFatalError(Fixup.getLoc(),
+                                      Twine("assembler label '") + A.getName() +
+                                          "' can not be undefined");
+  }
 
   MCSection *Section = Fragment->getParent();
 
diff --git a/test/MC/COFF/label-undefined.s b/test/MC/COFF/label-undefined.s
new file mode 100644 (file)
index 0000000..e5cfd3c
--- /dev/null
@@ -0,0 +1,4 @@
+// RUN: not llvm-mc -filetype=obj -triple i386-pc-win32 %s 2>&1 | FileCheck %s
+// CHECK: assembler label 'Lundefined' can not be undefined
+        .text
+        movl Lundefined, %eax