Support: Return scale from ScaledNumbers::matchScales()

This will be convenient when extracting `ScaledNumbers::getSum()`.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211552 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Support/ScaledNumber.h b/include/llvm/Support/ScaledNumber.h
index b1f6eadab8422fdf3e7970c4814b541017d159d3..caca5f731d4832ec4410f30883fc7a59e595e308 100644 (file)
--- a/include/llvm/Support/ScaledNumber.h
+++ b/include/llvm/Support/ScaledNumber.h
@@ -271,28 +271,30 @@ int compare(DigitsT LDigits, int16_t LScale, DigitsT RDigits, int16_t RScale) {
 /// losing precision only when necessary.
 ///
 /// If the output value of \c LDigits (\c RDigits) is \c 0, the output value of
-/// \c LScale (\c RScale) is unspecified.  If both \c LDigits and \c RDigits
-/// are \c 0, the output value is one of \c LScale and \c RScale; which is
-/// unspecified.
+/// \c LScale (\c RScale) is unspecified.
+///
+/// As a convenience, returns the matching scale.  If the output value of one
+/// number is zero, returns the scale of the other.  If both are zero, which
+/// scale is returned is unspecifed.
 template <class DigitsT>
-void matchScales(DigitsT &LDigits, int16_t &LScale, DigitsT &RDigits,
-                 int16_t &RScale) {
+int16_t matchScales(DigitsT &LDigits, int16_t &LScale, DigitsT &RDigits,
+                    int16_t &RScale) {
   static_assert(!std::numeric_limits<DigitsT>::is_signed, "expected unsigned");
 
-  if (LScale < RScale) {
+  if (LScale < RScale)
     // Swap arguments.
-    matchScales(RDigits, RScale, LDigits, LScale);
-    return;
-  }
-  if (!LDigits || !RDigits || LScale == RScale)
-    return;
+    return matchScales(RDigits, RScale, LDigits, LScale);
+  if (!LDigits)
+    return RScale;
+  if (!RDigits || LScale == RScale)
+    return LScale;
 
   // Now LScale > RScale.  Get the difference.
   int32_t ScaleDiff = int32_t(LScale) - RScale;
   if (ScaleDiff >= 2 * getWidth<DigitsT>()) {
     // Don't bother shifting.  RDigits will get zero-ed out anyway.
     RDigits = 0;
-    return;
+    return LScale;
   }
 
   // Shift LDigits left as much as possible, then shift RDigits right.
@@ -303,7 +305,7 @@ void matchScales(DigitsT &LDigits, int16_t &LScale, DigitsT &RDigits,
   if (ShiftR >= getWidth<DigitsT>()) {
     // Don't bother shifting.  RDigits will get zero-ed out anyway.
     RDigits = 0;
-    return;
+    return LScale;
   }
 
   LDigits <<= ShiftL;
@@ -312,6 +314,7 @@ void matchScales(DigitsT &LDigits, int16_t &LScale, DigitsT &RDigits,
   LScale -= ShiftL;
   RScale += ShiftR;
   assert(LScale == RScale && "scales should match");
+  return LScale;
 }
 
 } // end namespace ScaledNumbers

diff --git a/unittests/Support/ScaledNumberTest.cpp b/unittests/Support/ScaledNumberTest.cpp
index 550947b8ea3fcde3b624fb36fd524b317cff9c6b..08d6c68b0e06112c8dcde782bbca94eb02728743 100644 (file)
--- a/unittests/Support/ScaledNumberTest.cpp
+++ b/unittests/Support/ScaledNumberTest.cpp
@@ -336,7 +336,7 @@ TEST(ScaledNumberHelpersTest, matchScales) {
     int16_t RSx = RSIn;                                                        \
     int16_t Sy = SOut;                                                         \
                                                                                \
-    matchScales(LDx, LSx, RDx, RSx);                                           \
+    EXPECT_EQ(SOut, matchScales(LDx, LSx, RDx, RSx));                          \
     EXPECT_EQ(LDy, LDx);                                                       \
     EXPECT_EQ(RDy, RDx);                                                       \
     if (LDy)                                                                   \