name change: isPow2DivCheap -> isPow2SDivCheap
authorSanjay Patel <spatel@rotateright.com>
Thu, 21 Aug 2014 22:31:48 +0000 (22:31 +0000)
committerSanjay Patel <spatel@rotateright.com>
Thu, 21 Aug 2014 22:31:48 +0000 (22:31 +0000)
commitd1a09c47d2460a8fda09affc413c64c2eb489629
treeb920956bfa484563ec46070d64a46547945cbd32
parentbd66db27fd6f2a3e1f55c13a4c0ac0d1c8ce6e29
name change: isPow2DivCheap -> isPow2SDivCheap

isPow2DivCheap

That name doesn't specify signed or unsigned.

Lazy as I am, I eventually read the function and variable comments. It turns out that this is strictly about signed div. But I discovered that the comments are wrong:

   srl/add/sra

is not the general sequence for signed integer division by power-of-2. We need one more 'sra':

   sra/srl/add/sra

That's the sequence produced in DAGCombiner. The first 'sra' may be removed when dividing by exactly '2', but that's a special case.

This patch corrects the comments, changes the name of the flag bit, and changes the name of the accessor methods.

No functional change intended.

Differential Revision: http://reviews.llvm.org/D5010

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216237 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/Target/TargetLowering.h
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
lib/CodeGen/TargetLoweringBase.cpp
lib/Target/PowerPC/PPCISelLowering.cpp
lib/Target/R600/AMDGPUISelLowering.cpp