[MC] Attach labels to existing fragments instead of using a separate fragment
authorDerek Schuff <dschuff@google.com>
Wed, 22 Oct 2014 22:38:06 +0000 (22:38 +0000)
committerDerek Schuff <dschuff@google.com>
Wed, 22 Oct 2014 22:38:06 +0000 (22:38 +0000)
commitcdb105b62fdb911119f08cfecabfb109117aeaf2
tree37133d49cf967800d067fd9f86fa7be630efeb0c
parent545127f54dc632b2d0da38e027c58888d091ede1
[MC] Attach labels to existing fragments instead of using a separate fragment

Summary:
Currently when emitting a label, a new data fragment is created for it if the
current fragment isn't a data fragment.
This change instead enqueues the label and attaches it to the next fragment
(e.g. created for the next instruction) if possible.

When bundle alignment is not enabled, this has no functionality change (it
just results in fewer extra fragments being created). For bundle alignment,
previously labels would point to the beginning of the bundle padding instead
of the beginning of the emitted instruction. This was not only less efficient
(e.g. jumping to the nops instead of past them) but also led to miscalculation
of the address of the GOT (since MC uses a label difference rather than
emitting a "." symbol).

Fixes https://code.google.com/p/nativeclient/issues/detail?id=3982

Test Plan: regression test attached

Reviewers: jvoung, eliben

Subscribers: jfb, llvm-commits

Differential Revision: http://reviews.llvm.org/D5915

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@220439 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/MC/MCObjectStreamer.h
lib/MC/MCObjectStreamer.cpp
test/MC/X86/AlignedBundling/labeloffset.s [new file with mode: 0644]
test/MC/X86/AlignedBundling/long-nop-pad.s