Verifier: Check accessors of MDLocation
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Thu, 26 Mar 2015 22:05:04 +0000 (22:05 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Thu, 26 Mar 2015 22:05:04 +0000 (22:05 +0000)
commitc4eafd24f28b676ed7f605cda1fe42da6d34b81f
treefecc39e784c14283ab2bbd24e2ba7125719f0585
parent337bd191d23e54c34b7d3942828409d6cb2c10b7
Verifier: Check accessors of MDLocation

Check accessors of `MDLocation`, and change them to `cast<>` down to the
right types.  Also add type-safe factory functions.

All the callers that handle broken code need to use the new versions of
the accessors (`getRawScope()` instead of `getScope()`) that still
return `Metadata*`.  This is also necessary for things like
`MDNodeKeyImpl<MDLocation>` (in LLVMContextImpl.h) that need to unique
the nodes when their operands might still be forward references of the
wrong type.

In the `Value` hierarchy, consumers that handle broken code use
`getOperand()` directly.  However, debug info nodes have a ton of
operands, and their order (even their existence) isn't stable yet.  It's
safer and more maintainable to add an explicit "raw" accessor on the
class itself.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@233322 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/IR/DebugInfoMetadata.h
lib/AsmParser/LLParser.cpp
lib/Bitcode/Reader/BitcodeReader.cpp
lib/IR/AsmWriter.cpp
lib/IR/LLVMContextImpl.h
lib/IR/Verifier.cpp
test/Assembler/mdlocation.ll
test/Assembler/metadata.ll
test/Linker/Inputs/mdlocation.ll
test/Linker/mdlocation.ll
unittests/IR/MetadataTest.cpp