ARM: expand atomic ldrex/strex loops in IR
authorTim Northover <tnorthover@apple.com>
Thu, 3 Apr 2014 11:44:58 +0000 (11:44 +0000)
committerTim Northover <tnorthover@apple.com>
Thu, 3 Apr 2014 11:44:58 +0000 (11:44 +0000)
commitbadb1377291e99cea122b64ee62fa0382e9ee737
treefb4307171ce495484cea427864e5dc163d159b32
parent37e5cfa4aae0dd693ab0c35ff78d37f5ddfe177d
ARM: expand atomic ldrex/strex loops in IR

The previous situation where ATOMIC_LOAD_WHATEVER nodes were expanded
at MachineInstr emission time had grown to be extremely large and
involved, to account for the subtly different code needed for the
various flavours (8/16/32/64 bit, cmpxchg/add/minmax).

Moving this transformation into the IR clears up the code
substantially, and makes future optimisations much easier:

1. an atomicrmw followed by using the *new* value can be more
   efficient. As an IR pass, simple CSE could handle this
   efficiently.
2. Making use of cmpxchg success/failure orderings only has to be done
   in one (simpler) place.
3. The common "cmpxchg; did we store?" idiom can be exposed to
   optimisation.

I intend to gradually improve this situation within the ARM backend
and make sure there are no hidden issues before moving the code out
into CodeGen to be shared with (at least ARM64/AArch64, though I think
PPC & Mips could benefit too).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205525 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/ARM/ARM.h
lib/Target/ARM/ARMAtomicExpandPass.cpp [new file with mode: 0644]
lib/Target/ARM/ARMISelDAGToDAG.cpp
lib/Target/ARM/ARMISelLowering.cpp
lib/Target/ARM/ARMISelLowering.h
lib/Target/ARM/ARMInstrInfo.td
lib/Target/ARM/ARMTargetMachine.cpp
lib/Target/ARM/CMakeLists.txt
test/CodeGen/ARM/atomic-64bit.ll
test/CodeGen/ARM/atomic-ops-v8.ll
test/CodeGen/ARM/atomicrmw_minmax.ll