ADT: Require explicit ilist iterator/pointer conversions
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 7 Nov 2015 00:02:32 +0000 (00:02 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 7 Nov 2015 00:02:32 +0000 (00:02 +0000)
commit84cb8974bde802f860313fc7001d60ed674700ae
treef33179e4c08c94353b32e3d4cd3205dbe3f140b2
parent5013c51dfcd73ee1bcfa8e9a8b85561cf7a6d237
ADT: Require explicit ilist iterator/pointer conversions

Disallow implicit conversions between ilist iterators and element
points.  Explicit conversions still work of course.

This is the first step toward removing the undefined behaviour in
`ilist` and `iplist`:
http://lists.llvm.org/pipermail/llvm-dev/2015-October/091115.html

The motivation for removing the implicit iterators is that I came across
real bugs (that were *really* getting lucky).  More details and some
brief discussion later in that thread:
http://lists.llvm.org/pipermail/llvm-dev/2015-October/091617.html

Note: if you have out-of-tree code, it should be fairly easy to revert
this patch downstream while you update your out-of-tree call sites.
Note that these conversions are occasionally latent bugs (that may
happen to "work" now, but only because of getting lucky with UB;
follow-ups will change your luck).  When they are valid, I suggest using
`->getIterator()` to go from pointer to iterator, and `&*` to go from
iterator to pointer.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@252372 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/ADT/ilist.h