Use std::error_code instead of llvm::error_code.
authorRafael Espindola <rafael.espindola@gmail.com>
Wed, 11 Jun 2014 19:05:50 +0000 (19:05 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Wed, 11 Jun 2014 19:05:50 +0000 (19:05 +0000)
commit7acd886ecfa0adc8a14476eafe8cf1fa981cfe18
tree28c91d4858225f439de5d76169b368659cbbb448
parent9ce94d7df4acff893bf095323250b8a84663a1fd
Use std::error_code instead of llvm::error_code.

The idea of this patch is to turn llvm/Support/system_error.h into a
transitional header that just brings in the erorr_code api to the llvm
namespace. I will remove it shortly afterwards.

The cases where the general idea needed some tweaking:

* std::errc is a namespace in msvc, so we cannot use "using std::errc". I could
add an #ifdef, but there were not that many uses, so I just added std:: to
them in this patch.

* Template specialization had to be moved to the std namespace in this
patch set already.

* The msvc implementation of default_error_condition doesn't seem to
provide the same transformations as we need. Not too surprising since
the standard doesn't actually say what "equivalent" means. I fixed the
problem by keeping our old mapping and using it at error_code
construction time.

Despite these shortcomings I think this is still a good thing. Some reasons:

* The different implementations of system_error might improve over time.
* It removes 925 lines of code from llvm already.
* It removes 6313 bytes from the text segment of the clang binary when
it is built with gcc and 2816 bytes when building with clang and
libstdc++.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@210687 91177308-0d34-0410-b5e6-96231b3b80d8
37 files changed:
include/llvm/Object/Error.h
include/llvm/ProfileData/InstrProf.h
include/llvm/Support/FileOutputBuffer.h
include/llvm/Support/MemoryBuffer.h
include/llvm/Support/Program.h
include/llvm/Support/WindowsError.h [new file with mode: 0644]
include/llvm/Support/system_error.h
lib/Object/Error.cpp
lib/ProfileData/InstrProf.cpp
lib/Support/CMakeLists.txt
lib/Support/FileOutputBuffer.cpp
lib/Support/LockFileManager.cpp
lib/Support/MemoryBuffer.cpp
lib/Support/Path.cpp
lib/Support/Unix/Path.inc
lib/Support/Unix/system_error.inc [deleted file]
lib/Support/Windows/Path.inc
lib/Support/Windows/Process.inc
lib/Support/Windows/system_error.inc [deleted file]
lib/Support/WindowsError.cpp [new file with mode: 0644]
lib/Support/YAMLTraits.cpp
lib/Support/system_error.cpp [deleted file]
test/Object/directory.ll
tools/llvm-ar/llvm-ar.cpp
tools/llvm-cov/llvm-cov.cpp
tools/llvm-objdump/llvm-objdump.h
tools/llvm-readobj/Error.cpp
tools/llvm-readobj/Error.h
tools/llvm-readobj/ObjDumper.h
tools/llvm-readobj/llvm-readobj.h
tools/llvm-symbolizer/LLVMSymbolize.cpp
tools/obj2yaml/Error.cpp
tools/obj2yaml/Error.h
unittests/Support/ErrorOrTest.cpp
unittests/Support/Path.cpp
unittests/Transforms/DebugIR/DebugIR.cpp
utils/KillTheDoctor/KillTheDoctor.cpp