[lit] Fix bug where ``lit.util.which()`` would return a directory
authorDan Liew <dan@su-root.co.uk>
Fri, 13 Nov 2015 11:37:25 +0000 (11:37 +0000)
committerDan Liew <dan@su-root.co.uk>
Fri, 13 Nov 2015 11:37:25 +0000 (11:37 +0000)
commit74771a338cfb244fbd5e65431863a28b8d2271d2
tree4b16041903f75b0bdf8aa785820e2b0858b51f11
parent3e8d99c24d4a56c94821aa5cc13ca6132afaf997
[lit] Fix bug where ``lit.util.which()`` would return a directory
instead of executable if the argument was found inside a directory
contained in PATH.

An example where this could cause a problem is if there was a RUN line
that ran the ``test`` command and if the user had a directory in their
PATH that contained a directory called ``test/`` (that occured before
``/usr/bin/``). Lit would try to use the directory as the executable
which would fail with the rather cryptic message.

```
Could not create process due to [Errno 13] Permission denied
```

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253031 91177308-0d34-0410-b5e6-96231b3b80d8
utils/lit/lit/util.py