Stop uppercasing build attribute data.
authorCharlie Turner <charlie.turner@arm.com>
Thu, 27 Nov 2014 12:13:56 +0000 (12:13 +0000)
committerCharlie Turner <charlie.turner@arm.com>
Thu, 27 Nov 2014 12:13:56 +0000 (12:13 +0000)
commit72ba1af89cf6fa56f5fa499f55c8733d16067c28
treee6a6808196e16105031512aca68493ff9bfd14e3
parent578b3ccd8fb426f8fbfd497b8753a8337b61abf2
Stop uppercasing build attribute data.

The string data for string-valued build attributes were being unconditionally
uppercased. There is no mention in the ARM ABI addenda about case conventions,
so it's technically implementation defined as to whether the data are
capitialised in some way or not. However, there are good reasons not to
captialise the data.

  * It's less work.
  * Some vendors may legitimately have case-sensitive checks for these
    attributes which would fail on LLVM generated object files.
  * There could be locale issues with uppercasing.

The original reasons for uppercasing appear to have stemmed from an
old codesourcery toolchain behaviour, see

http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/87133

This patch makes the object file emitted no longer captialise string
data, it encodes as seen in the assembly source.

Change-Id: Ibe20dd6e60d2773d57ff72a78470839033aa5538

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@222882 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
test/CodeGen/ARM/build-attributes-encoding.s
test/MC/ARM/directive-arch-iwmmxt.s
test/MC/ARM/directive-arch-iwmmxt2.s
test/MC/ARM/directive-cpu.s
test/MC/ARM/directive-eabi_attribute-overwrite.s
test/MC/ARM/directive-eabi_attribute.s
test/tools/llvm-readobj/ARM/attributes.s