DebugInfo+DFSan: Ensure that debug info references to llvm::Functions remain pointing...
authorDavid Blaikie <dblaikie@gmail.com>
Tue, 7 Oct 2014 22:59:46 +0000 (22:59 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Tue, 7 Oct 2014 22:59:46 +0000 (22:59 +0000)
commit5f3c0bafeb9dcceb224d73ca3e76f875321d1ef1
tree7afc407dcdfd35556c6b5adcc6c5f51cb33bf89a
parent7106ab7ffd1eee6adb045d3bd0a3d559435e527d
DebugInfo+DFSan: Ensure that debug info references to llvm::Functions remain pointing to the underlying function when wrappers are created

This is somewhat the inverse of how similar bugs in DAE and ArgPromo
manifested and were addressed. In those passes, individual call sites
were visited explicitly, and then the old function was deleted. This
left the debug info with a null llvm::Function* that needed to be
updated to point to the new function.

In the case of DFSan, it RAUWs the old function with the wrapper, which
includes debug info. So now the debug info refers to the wrapper, which
doesn't actually have any instructions with debug info in it, so it is
ignored entirely - resulting in a DW_TAG_subprogram with no high/low pc,
etc. Instead, fix up the debug info to refer to the original function
after the RAUW messed it up.

Reviewed/discussed with Peter Collingbourne on the llvm-dev mailing
list.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@219249 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
test/Instrumentation/DataFlowSanitizer/Inputs/debuglist.txt [new file with mode: 0644]
test/Instrumentation/DataFlowSanitizer/debug.ll [new file with mode: 0644]