Fix program crashes due to alignment exceptions generated for SSE memop instructions...
authorSanjay Patel <spatel@rotateright.com>
Tue, 3 Feb 2015 17:13:04 +0000 (17:13 +0000)
committerSanjay Patel <spatel@rotateright.com>
Tue, 3 Feb 2015 17:13:04 +0000 (17:13 +0000)
commit3cf9267d4e4dbe7ebd21adfaabe4d2ce01456813
treee1061511054276c2941c06db43ce110b476cda9e
parentaeba87d6a67271a20c71a7e71a5c4a098a42433b
Fix program crashes due to alignment exceptions generated for SSE memop instructions (PR22371).

r224330 introduced a bug by misinterpreting the "FeatureVectorUAMem" bit.
The commit log says that change did not affect anything, but that's not correct.
That change allowed SSE instructions to have unaligned mem operands folded into
math ops, and that's not allowed in the default specification for any SSE variant.

The bug is exposed when compiling for an AVX-capable CPU that had this feature
flag but without enabling AVX codegen. Another mistake in r224330 was not adding
the feature flag to all AVX CPUs; the AMD chips were excluded.

This is part of the fix for PR22371 ( http://llvm.org/bugs/show_bug.cgi?id=22371 ).

This feature bit is SSE-specific, so I've renamed it to "FeatureSSEUnalignedMem".
Changed the existing test case for the feature bit to reflect the new name and
renamed the test file itself to better reflect the feature.
Added runs to fold-vex.ll to check for the failing codegen.

Note that the feature bit is not set by default on any CPU because it may require a
configuration register setting to enable the enhanced unaligned behavior.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@227983 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/X86/X86.td
lib/Target/X86/X86InstrFragmentsSIMD.td
lib/Target/X86/X86Subtarget.cpp
lib/Target/X86/X86Subtarget.h
test/CodeGen/X86/2010-01-07-UAMemFeature.ll [deleted file]
test/CodeGen/X86/fold-vex.ll
test/CodeGen/X86/sse-unaligned-mem-feature.ll [new file with mode: 0644]