Explicitly request unsigned enum types when desired
authorReid Kleckner <reid@kleckner.net>
Mon, 23 Sep 2013 23:26:57 +0000 (23:26 +0000)
committerReid Kleckner <reid@kleckner.net>
Mon, 23 Sep 2013 23:26:57 +0000 (23:26 +0000)
commit118a0659ab8a4d0e0af343b88e5fa71a5c1eb6a6
tree0ccf13d04a66fc600e3ecc221f91bc4ced150676
parent5a63474e2d4c797ca8245edae4064f17b47df3ee
Explicitly request unsigned enum types when desired

The underlying type of all plain enums in MSVC is 'int', even if the
enumerator contains large 32-bit unsigned values or values greater than
UINT_MAX.  The only way to get a large or unsigned enum type is to
request it explicitly with the C++11 strong enum types feature.

However, since LLVM isn't C++11 yet, I had to add a conditional
LLVM_ENUM_INT_TYPE to Compiler.h to control its usage.

The motivating true positive for this change is compiling PointerIntPair
with MSVC for win64.  The PointerIntMask value is supposed to be pointer
sized value of all ones with some low zeros.  Instead, it's truncated to
32-bits!  We are only saved later because it is sign extended back in
the AND with int64_t, and we happen to want all ones.

This silences lots of -Wmicrosoft warnings during a clang self-host
targeting Windows.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191241 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/ADT/PointerIntPair.h
include/llvm/IR/Attributes.h
include/llvm/IR/InlineAsm.h
include/llvm/MC/MCSectionMachO.h
include/llvm/MC/MachineLocation.h
include/llvm/Object/ObjectFile.h
include/llvm/Support/COFF.h
include/llvm/Support/Compiler.h
include/llvm/Support/Dwarf.h
include/llvm/Support/ELF.h
include/llvm/Support/MachO.h