X-Git-Url: http://plrg.eecs.uci.edu/git/?p=oota-llvm.git;a=blobdiff_plain;f=lib%2FBitcode%2FReader%2FBitcodeReader.cpp;h=85dde397916c580b3ff2fabd765aa475e14e51bf;hp=48fa9390412b13811d06f66594b88a6c0154d494;hb=15262784434ada50aeb5f8474b880ce5d672fb0e;hpb=306030f8aa52ace8fd57a9b9aca06bedac3b32de diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 48fa9390412..85dde397916 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -3503,10 +3503,17 @@ const std::error_category &llvm::BitcodeErrorCategory() { // External interface //===----------------------------------------------------------------------===// -/// getLazyBitcodeModule - lazy function-at-a-time loading from a file. +/// \brief Get a lazy one-at-time loading module from bitcode. /// -ErrorOr llvm::getLazyBitcodeModule(MemoryBuffer *Buffer, - LLVMContext &Context) { +/// This isn't always used in a lazy context. In particular, it's also used by +/// \a parseBitcodeFile(). If this is truly lazy, then we need to eagerly pull +/// in forward-referenced functions from block address references. +/// +/// \param[in] WillMaterializeAll Set to \c true if the caller promises to +/// materialize everything -- in particular, if this isn't truly lazy. +static ErrorOr getLazyBitcodeModuleImpl(MemoryBuffer *Buffer, + LLVMContext &Context, + bool WillMaterializeAll) { Module *M = new Module(Buffer->getBufferIdentifier(), Context); BitcodeReader *R = new BitcodeReader(Buffer, Context); M->setMaterializer(R); @@ -3520,12 +3527,18 @@ ErrorOr llvm::getLazyBitcodeModule(MemoryBuffer *Buffer, if (std::error_code EC = R->ParseBitcodeInto(M)) return cleanupOnError(EC); - if (std::error_code EC = R->materializeForwardReferencedFunctions()) - return cleanupOnError(EC); + if (!WillMaterializeAll) + // Resolve forward references from blockaddresses. + if (std::error_code EC = R->materializeForwardReferencedFunctions()) + return cleanupOnError(EC); return M; } +ErrorOr llvm::getLazyBitcodeModule(MemoryBuffer *Buffer, + LLVMContext &Context) { + return getLazyBitcodeModuleImpl(Buffer, Context, false); +} Module *llvm::getStreamedBitcodeModule(const std::string &name, DataStreamer *streamer, @@ -3545,7 +3558,8 @@ Module *llvm::getStreamedBitcodeModule(const std::string &name, ErrorOr llvm::parseBitcodeFile(MemoryBuffer *Buffer, LLVMContext &Context) { - ErrorOr ModuleOrErr = getLazyBitcodeModule(Buffer, Context); + ErrorOr ModuleOrErr = + getLazyBitcodeModuleImpl(Buffer, Context, true); if (!ModuleOrErr) return ModuleOrErr; Module *M = ModuleOrErr.get();