How to close a review manually.

[oota-llvm.git] / docs / Phabricator.rst

diff --git a/docs/Phabricator.rst b/docs/Phabricator.rst
index 73704d9b17d74ae414b87d084bb49e4749b88e9a..af1e4429fda9b974bbb11eefb5da7945bc42dd43 100644 (file)
--- a/docs/Phabricator.rst
+++ b/docs/Phabricator.rst
@@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``, etc from the review and commit it to t
   arc commit --revision D<Revision>
 
 
-When committing an LLVM change that has been reviewed using
+When committing a change that has been reviewed using
 Phabricator, the convention is for the commit message to end with the
 line:
 
@@ -153,6 +153,12 @@ This allows people reading the version history to see the review for
 context.  This also allows Phabricator to detect the commit, close the
 review, and add a link from the review to the commit.
 
+If you use ``git`` or ``svn`` to commit the change and forget to add the line
+to your commit message, you should close the review manually. In the web UI,
+under "Leap Into Action" put the SVN revision number in the Comment, set the
+Action to "Close Revision" and click Submit. Note the review must have been
+Accepted first.
+
 Abandoning a change
 -------------------