From b02e5f980b66f92801bc2e93db05940ac5ac7c5e Mon Sep 17 00:00:00 2001 From: Brian Norris Date: Fri, 19 Apr 2013 15:21:07 -0700 Subject: [PATCH] snapshot-interface: bugfix - terminate string from readlink() readlink() doesn't terminate the string for us, so our string doesn't match properly (it will have a little extra garbage at the end). --- snapshot-interface.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/snapshot-interface.cc b/snapshot-interface.cc index 5f8a687..fdabcf3 100644 --- a/snapshot-interface.cc +++ b/snapshot-interface.cc @@ -85,10 +85,16 @@ static void SnapshotGlobalSegments() static void get_binary_name(char *buf, size_t len) { - if (readlink("/proc/self/exe", buf, len) == -1) { + ssize_t size = readlink("/proc/self/exe", buf, len); + if (size < 0) { perror("readlink"); exit(EXIT_FAILURE); } + + /* Terminate string */ + if ((size_t)size > len) + size = len; + buf[size] = '\0'; } /** The SnapshotGlobalSegments function computes the memory regions -- 2.34.1