From: Brian Demsky <bdemsky@uci.edu>
Date: Wed, 10 Oct 2012 00:54:43 +0000 (-0700)
Subject: fix some of the bugs related to barrier example...
X-Git-Tag: pldi2013~64
X-Git-Url: http://plrg.eecs.uci.edu/git/?p=model-checker.git;a=commitdiff_plain;h=4546308ab989c074f83d8607e16f13ffbcff494a;hp=2e9b955070a194963ddb98a5cb3e16968323adec

fix some of the bugs related to barrier example...
---

diff --git a/action.cc b/action.cc
index 5e05081..1a819ea 100644
--- a/action.cc
+++ b/action.cc
@@ -111,6 +111,11 @@ bool ModelAction::is_write() const
 	return type == ATOMIC_WRITE || type == ATOMIC_RMW || type == ATOMIC_INIT;
 }
 
+bool ModelAction::could_be_write() const
+{
+	return is_write() || is_rmwr();
+}
+
 bool ModelAction::is_rmwr() const
 {
 	return type == ATOMIC_RMWR;
@@ -217,11 +222,11 @@ bool ModelAction::could_synchronize_with(const ModelAction *act) const
 
 	// Explore interleavings of seqcst writes to guarantee total order
 	// of seq_cst operations that don't commute
-	if ((is_write() || act->is_write()) && is_seqcst() && act->is_seqcst())
+	if ((could_be_write() || act->could_be_write()) && is_seqcst() && act->is_seqcst())
 		return true;
 
 	// Explore synchronizing read/write pairs
-	if (is_read() && is_acquire() && act->is_write() && act->is_release())
+	if (is_read() && is_acquire() && act->could_be_write() && act->is_release())
 		return true;
 
 	// Otherwise handle by reads_from relation
diff --git a/action.h b/action.h
index 4960931..4f63c18 100644
--- a/action.h
+++ b/action.h
@@ -94,6 +94,7 @@ public:
 	bool is_failed_trylock() const;
 	bool is_read() const;
 	bool is_write() const;
+	bool could_be_write() const;
 	bool is_rmwr() const;
 	bool is_rmwc() const;
 	bool is_rmw() const;
diff --git a/main.cc b/main.cc
index 6624f06..fc1b277 100644
--- a/main.cc
+++ b/main.cc
@@ -19,6 +19,7 @@ static void param_defaults(struct model_params * params) {
 	params->maxfuturedelay = 100;
 	params->fairwindow = 0;
 	params->enabledcount = 1;
+	params->bound = 0;
 }
 
 static void print_usage(struct model_params *params) {
@@ -36,13 +37,14 @@ static void print_usage(struct model_params *params) {
 "                      enabled sufficiently many times should receive\n"
 "                      priority for execution. Default: %d\n"
 "-e                    Enabled count. Default: %d\n"
+"-b                    Upper length bound. Default: %d\n"
 "--                    Program arguments follow.\n\n",
-params->maxreads, params->maxfuturedelay, params->fairwindow, params->enabledcount);
+params->maxreads, params->maxfuturedelay, params->fairwindow, params->enabledcount, params->bound);
 	exit(EXIT_SUCCESS);
 }
 
 static void parse_options(struct model_params *params, int *argc, char ***argv) {
-	const char *shortopts = "hm:s:f:e:";
+	const char *shortopts = "hm:s:f:e:b:";
 	int opt;
 	bool error = false;
 	while (!error && (opt = getopt(*argc, *argv, shortopts)) != -1) {
@@ -59,6 +61,9 @@ static void parse_options(struct model_params *params, int *argc, char ***argv)
 		case 'e':
 			params->enabledcount = atoi(optarg);
 			break;
+		case 'b':
+			params->bound = atoi(optarg);
+			break;
 		case 'm':
 			params->maxreads = atoi(optarg);
 			break;
diff --git a/model.cc b/model.cc
index 5753c5c..c0cc93e 100644
--- a/model.cc
+++ b/model.cc
@@ -260,7 +260,8 @@ bool ModelChecker::next_execution()
 	DEBUG("Number of acquires waiting on pending release sequences: %zu\n",
 			pending_rel_seqs->size());
 
-	if (isfinalfeasible() || DBG_ENABLED())
+
+	if (isfinalfeasible() || (params.bound != 0 && priv->used_sequence_numbers > params.bound ) || DBG_ENABLED() )
 		print_summary();
 
 	if ((diverge = get_next_backtrack()) == NULL)
@@ -1873,7 +1874,7 @@ void ModelChecker::build_reads_from_past(ModelAction *curr)
 					curr->print();
 				}
 
-				if (curr->get_sleep_flag()) {
+				if (curr->get_sleep_flag() && ! curr->is_seqcst()) {
 					if (sleep_can_read_from(curr, act))
 						curr->get_node()->add_read_from(act);
 				} else
@@ -2073,6 +2074,12 @@ bool ModelChecker::take_step() {
 	if (!isfeasible())
 		return false;
 
+	if (params.bound != 0) {
+		if (priv->used_sequence_numbers > params.bound) {
+			return false;
+		}
+	}
+
 	DEBUG("(%d, %d)\n", curr ? id_to_int(curr->get_id()) : -1,
 			next ? id_to_int(next->get_id()) : -1);
 
diff --git a/model.h b/model.h
index 6e470c0..01dd35b 100644
--- a/model.h
+++ b/model.h
@@ -36,6 +36,7 @@ struct model_params {
 	int maxfuturedelay;
 	unsigned int fairwindow;
 	unsigned int enabledcount;
+	unsigned int bound;
 };
 
 struct PendingFutureValue {