X-Git-Url: http://plrg.eecs.uci.edu/git/?p=model-checker.git;a=blobdiff_plain;f=nodestack.cc;h=ec7ce1694f764e640e099c9f2eb7a431c0b0763c;hp=a88166f087722c084cc9a30bf4c64ea8d0f4404e;hb=ffc110b3aaa80564dbf85f3c6a9049efd40571f1;hpb=35dd2c2087e76909e28e2754ad361bec5dff8f2a diff --git a/nodestack.cc b/nodestack.cc index a88166f..ec7ce16 100644 --- a/nodestack.cc +++ b/nodestack.cc @@ -1,7 +1,10 @@ +#include + #include "nodestack.h" #include "action.h" #include "common.h" #include "model.h" +#include "threads-model.h" /** * @brief Node constructor @@ -17,20 +20,60 @@ * @param nthreads The number of threads which exist at this point in the * execution trace. */ -Node::Node(ModelAction *act, Node *par, int nthreads) +Node::Node(ModelAction *act, Node *par, int nthreads, Node *prevfairness) : action(act), parent(par), num_threads(nthreads), explored_children(num_threads), backtrack(num_threads), + fairness(num_threads), numBacktracks(0), + enabled_array(NULL), may_read_from(), read_from_index(0), future_values(), - future_index(-1) + future_index(-1), + relseq_break_writes(), + relseq_break_index(0), + misc_index(0), + misc_max(0) { - if (act) + if (act) { act->set_node(this); + int currtid=id_to_int(act->get_tid()); + int prevtid=(prevfairness != NULL)?id_to_int(prevfairness->action->get_tid()):0; + + if ( model->params.fairwindow != 0 ) { + for(int i=0;iget_num_threads())?&par->fairness[i]:NULL; + if (prevfi) { + *fi=*prevfi; + } + if (parent->is_enabled(i)) { + fi->enabled_count++; + } + if (i==currtid) { + fi->turns++; + fi->priority = false; + } + //Do window processing + if (prevfairness != NULL) { + if (prevfairness -> parent->is_enabled(i)) + fi->enabled_count--; + if (i==prevtid) { + fi->turns--; + } + //Need full window to start evaluating conditions + //If we meet the enabled count and have no turns, give us priority + if ((fi->enabled_count >= model->params.enabledcount) && + (fi->turns == 0)) + fi->priority = true; + } + } + } + } } /** @brief Node desctructor */ @@ -38,6 +81,8 @@ Node::~Node() { if (action) delete action; + if (enabled_array) + model_free(enabled_array); } /** Prints debugging info for the ModelAction associated with this Node */ @@ -52,19 +97,19 @@ void Node::print() /** @brief Prints info about may_read_from set */ void Node::print_may_read_from() { - readfrom_set_t::iterator it; - for (it = may_read_from.begin(); it != may_read_from.end(); it++) - (*it)->print(); + for (unsigned int i = 0; i < may_read_from.size(); i++) + may_read_from[i]->print(); } /** * Sets a promise to explore meeting with the given node. * @param i is the promise index. */ -void Node::set_promise(uint32_t i) { - if (i>=promises.size()) - promises.resize(i+1,0); - promises[i]=1; +void Node::set_promise(unsigned int i) { + if (i >= promises.size()) + promises.resize(i + 1, PROMISE_IGNORE); + if (promises[i] == PROMISE_IGNORE) + promises[i] = PROMISE_UNFULFILLED; } /** @@ -72,8 +117,8 @@ void Node::set_promise(uint32_t i) { * @param i The promise index. * @return true if the promise should be satisfied by the given model action. */ -bool Node::get_promise(uint32_t i) { - return (i0) { + DBG(); + + for (unsigned int i = 0; i < promises.size(); i++) { + if (promises[i] == PROMISE_UNFULFILLED) { + promises[i] = PROMISE_FULFILLED; + while (i > 0) { i--; - if (promises[i]==2) - promises[i]=1; + if (promises[i] == PROMISE_FULFILLED) + promises[i] = PROMISE_UNFULFILLED; } return true; } @@ -100,22 +147,52 @@ bool Node::increment_promise() { * @return true if we have explored all promise combinations. */ bool Node::promise_empty() { - for (unsigned int i=0;i=misc_max; +} + + /** * Adds a value from a weakly ordered future write to backtrack to. * @param value is the value to backtrack to. */ -bool Node::add_future_value(uint64_t value) { - for(unsigned int i=0;i=expiration) + return false; + if (future_index < ((int) i)) { + suitableindex=i; + } + } + } - future_values.push_back(value); + if (suitableindex!=-1) { + future_values[suitableindex].expiration=expiration; + return true; + } + struct future_value newfv={value, expiration}; + future_values.push_back(newfv); return true; } @@ -124,10 +201,9 @@ bool Node::add_future_value(uint64_t value) { * @return true if the future_values set is empty. */ bool Node::future_value_empty() { - return ((future_index+1)>=future_values.size()); + return ((future_index + 1) >= ((int)future_values.size())); } - /** * Checks if the Thread associated with this thread ID has been explored from * this Node already. @@ -150,23 +226,29 @@ bool Node::backtrack_empty() return (numBacktracks == 0); } - /** * Checks whether the readsfrom set for this node is empty. * @return true if the readsfrom set is empty. */ bool Node::read_from_empty() { - return ((read_from_index+1)>=may_read_from.size()); + return ((read_from_index+1) >= may_read_from.size()); } - - /** * Mark the appropriate backtracking information for exploring a thread choice. * @param act The ModelAction to explore */ -void Node::explore_child(ModelAction *act) +void Node::explore_child(ModelAction *act, enabled_type_t * is_enabled) { + if ( ! enabled_array ) + enabled_array=(enabled_type_t *)model_malloc(sizeof(enabled_type_t)*num_threads); + if (is_enabled != NULL) + memcpy(enabled_array, is_enabled, sizeof(enabled_type_t)*num_threads); + else { + for(int i=0;iget_tid()); } @@ -204,7 +286,19 @@ thread_id_t Node::get_next_backtrack() bool Node::is_enabled(Thread *t) { - return id_to_int(t->get_id()) < num_threads; + int thread_id=id_to_int(t->get_id()); + return thread_id < num_threads && (enabled_array[thread_id] != THREAD_DISABLED); +} + +bool Node::is_enabled(thread_id_t tid) +{ + int thread_id=id_to_int(tid); + return thread_id < num_threads && (enabled_array[thread_id] != THREAD_DISABLED); +} + +bool Node::has_priority(thread_id_t tid) +{ + return fairness[id_to_int(tid)].priority; } /** @@ -221,10 +315,23 @@ void Node::add_read_from(const ModelAction *act) * where this->action is a 'read'. * @return The first element in future_values */ - uint64_t Node::get_future_value() { - ASSERT(future_index= ((int)relseq_break_writes.size())); } void Node::explore(thread_id_t tid) @@ -267,58 +436,53 @@ void Node::explore(thread_id_t tid) explored_children[i] = true; } -static void clear_node_list(node_list_t *list, node_list_t::iterator start, - node_list_t::iterator end) -{ - node_list_t::iterator it; - - for (it = start; it != end; it++) - delete (*it); - list->erase(start, end); -} - -NodeStack::NodeStack() - : total_nodes(0) +NodeStack::NodeStack() : + node_list(1, new Node()), + iter(0), + total_nodes(0) { - node_list.push_back(new Node()); total_nodes++; - iter = node_list.begin(); } NodeStack::~NodeStack() { - clear_node_list(&node_list, node_list.begin(), node_list.end()); + for (unsigned int i = 0; i < node_list.size(); i++) + delete node_list[i]; } void NodeStack::print() { - node_list_t::iterator it; printf("............................................\n"); printf("NodeStack printing node_list:\n"); - for (it = node_list.begin(); it != node_list.end(); it++) { + for (unsigned int it = 0; it < node_list.size(); it++) { if (it == this->iter) printf("vvv following action is the current iterator vvv\n"); - (*it)->print(); + node_list[it]->print(); } printf("............................................\n"); } -ModelAction * NodeStack::explore_action(ModelAction *act) +/** Note: The is_enabled set contains what actions were enabled when + * act was chosen. */ + +ModelAction * NodeStack::explore_action(ModelAction *act, enabled_type_t * is_enabled) { DBG(); ASSERT(!node_list.empty()); - node_list_t::iterator it=iter; - it++; - if (it != node_list.end()) { + if ((iter+1) < node_list.size()) { iter++; - return (*iter)->get_action(); + return node_list[iter]->get_action(); } /* Record action */ - get_head()->explore_child(act); - node_list.push_back(new Node(act, get_head(), model->get_num_threads())); + get_head()->explore_child(act, is_enabled); + Node *prevfairness = NULL; + if ( model->params.fairwindow != 0 && iter > model->params.fairwindow ) { + prevfairness = node_list[iter-model->params.fairwindow]; + } + node_list.push_back(new Node(act, get_head(), model->get_num_threads(), prevfairness)); total_nodes++; iter++; return NULL; @@ -335,35 +499,34 @@ ModelAction * NodeStack::explore_action(ModelAction *act) void NodeStack::pop_restofstack(int numAhead) { /* Diverging from previous execution; clear out remainder of list */ - node_list_t::iterator it = iter; - while (numAhead--) - it++; - clear_node_list(&node_list, it, node_list.end()); + unsigned int it=iter+numAhead; + for(unsigned int i=it;i