X-Git-Url: http://plrg.eecs.uci.edu/git/?p=model-checker.git;a=blobdiff_plain;f=clockvector.cc;h=14bb809dabddb051358e27776a0896ef978c62a5;hp=2ef8b03d9e36e22ce4ee6989ec31d20633717ed2;hb=e67f2f90b92e9176dc3f574095ba05a062c87f72;hpb=e8bc4a0715ce1c86f3ff7d24179e1164bf3ee61b

diff --git a/clockvector.cc b/clockvector.cc
index 2ef8b03..14bb809 100644
--- a/clockvector.cc
+++ b/clockvector.cc
@@ -1,4 +1,3 @@
-#include <algorithm>
 #include <cstring>
 #include <stdlib.h>
 
@@ -6,56 +5,68 @@
 #include "action.h"
 #include "clockvector.h"
 #include "common.h"
+#include "threads-model.h"
 
+/**
+ * Constructs a new ClockVector, given a parent ClockVector and a first
+ * ModelAction. This constructor can assign appropriate default settings if no
+ * parent and/or action is supplied.
+ * @param parent is the previous ClockVector to inherit (i.e., clock from the
+ * same thread or the parent that created this thread)
+ * @param act is an action with which to update the ClockVector
+ */
 ClockVector::ClockVector(ClockVector *parent, ModelAction *act)
 {
 	num_threads = model->get_num_threads();
-	clock = (int *)MYMALLOC(num_threads * sizeof(int));
-	memset(clock, 0, num_threads * sizeof(int));
+	clock = (modelclock_t *)snapshot_calloc(num_threads, sizeof(int));
 	if (parent)
-		std::memcpy(clock, parent->clock, parent->num_threads * sizeof(int));
+		std::memcpy(clock, parent->clock, parent->num_threads * sizeof(modelclock_t));
 
 	if (act)
 		clock[id_to_int(act->get_tid())] = act->get_seq_number();
 }
 
+/** @brief Destructor */
 ClockVector::~ClockVector()
 {
-	MYFREE(clock);
+	snapshot_free(clock);
 }
 
-void ClockVector::merge(ClockVector *cv)
+/**
+ * Merge a clock vector into this vector, using a pairwise comparison. The
+ * resulting vector length will be the maximum length of the two being merged.
+ * @param cv is the ClockVector being merged into this vector.
+ */
+void ClockVector::merge(const ClockVector *cv)
 {
-	int *clk = clock;
-	bool resize = false;
-
 	ASSERT(cv != NULL);
 
 	if (cv->num_threads > num_threads) {
-		resize = true;
-		clk = (int *)MYMALLOC(cv->num_threads * sizeof(int));
-	}
-
-	/* Element-wise maximum */
-	for (int i = 0; i < num_threads; i++)
-		clk[i] = std::max(clock[i], cv->clock[i]);
-
-	if (resize) {
+		clock = (modelclock_t *)snapshot_realloc(clock, cv->num_threads * sizeof(modelclock_t));
 		for (int i = num_threads; i < cv->num_threads; i++)
-			clk[i] = cv->clock[i];
+			clock[i] = 0;
 		num_threads = cv->num_threads;
-		MYFREE(clock);
 	}
-	clock = clk;
+
+	/* Element-wise maximum */
+	for (int i = 0; i < cv->num_threads; i++)
+		if (cv->clock[i] > clock[i])
+			clock[i] = cv->clock[i];
 }
 
 /**
+ * Check whether this vector's thread has synchronized with another action's
+ * thread. This effectively checks the happens-before relation (or actually,
+ * happens after), but it's easier to compare two ModelAction events directly,
+ * using ModelAction::happens_before.
+ *
+ * @see ModelAction::happens_before
  *
  * @return true if this ClockVector's thread has synchronized with act's
  * thread, false otherwise. That is, this function returns:
  * <BR><CODE>act <= cv[act->tid]</CODE>
  */
-bool ClockVector::synchronized_since(ModelAction *act)
+bool ClockVector::synchronized_since(const ModelAction *act) const
 {
 	int i = id_to_int(act->get_tid());
 
@@ -64,10 +75,21 @@ bool ClockVector::synchronized_since(ModelAction *act)
 	return false;
 }
 
-void ClockVector::print()
+/** Gets the clock corresponding to a given thread id from the clock vector. */
+modelclock_t ClockVector::getClock(thread_id_t thread) {
+	int threadid = id_to_int(thread);
+
+	if (threadid < num_threads)
+		return clock[threadid];
+	else
+		return 0;
+}
+
+/** @brief Formats and prints this ClockVector's data. */
+void ClockVector::print() const
 {
 	int i;
-	printf("CV: (");
+	model_print("CV: (");
 	for (i = 0; i < num_threads; i++)
-		printf("%2d%s", clock[i], (i == num_threads - 1) ? ")\n" : ", ");
+		model_print("%2u%s", clock[i], (i == num_threads - 1) ? ")\n" : ", ");
 }