X-Git-Url: http://plrg.eecs.uci.edu/git/?p=model-checker.git;a=blobdiff_plain;f=action.cc;h=8dba82f3a8ff7d97967410cfa75b33a84394de98;hp=33c69656d7702d757cd90d44a5884fdef99e2864;hb=59eb730e1d19a0825008c40eb521bfc5c29df5f9;hpb=5e3720f6a6dccf2af670e4ab30660130f2a57c8f diff --git a/action.cc b/action.cc index 33c6965..8dba82f 100644 --- a/action.cc +++ b/action.cc @@ -1,11 +1,16 @@ #include #define __STDC_FORMAT_MACROS #include +#include #include "model.h" #include "action.h" #include "clockvector.h" #include "common.h" +#include "threads.h" +#include "nodestack.h" + +#define ACTION_INITIAL_CLOCK 0 ModelAction::ModelAction(action_type_t type, memory_order order, void *loc, uint64_t value) : type(type), @@ -13,17 +18,68 @@ ModelAction::ModelAction(action_type_t type, memory_order order, void *loc, uint location(loc), value(value), reads_from(NULL), + node(NULL), + seq_number(ACTION_INITIAL_CLOCK), cv(NULL) { Thread *t = thread_current(); this->tid = t->get_id(); - this->seq_number = model->get_next_seq_num(); } +/** @brief ModelAction destructor */ ModelAction::~ModelAction() { - if (cv) - delete cv; + /** + * We can't free the clock vector: + * Clock vectors are snapshotting state. When we delete model actions, + * they are at the end of the node list and have invalid old clock + * vectors which have already been rolled back to an unallocated state. + */ + + /* + if (cv) + delete cv; */ +} + +void ModelAction::copy_from_new(ModelAction *newaction) +{ + seq_number = newaction->seq_number; +} + +void ModelAction::set_seq_number(modelclock_t num) +{ + ASSERT(seq_number == ACTION_INITIAL_CLOCK); + seq_number = num; +} + +bool ModelAction::is_mutex_op() const +{ + return type == ATOMIC_LOCK || type == ATOMIC_TRYLOCK || type == ATOMIC_UNLOCK; +} + +bool ModelAction::is_lock() const +{ + return type == ATOMIC_LOCK; +} + +bool ModelAction::is_unlock() const +{ + return type == ATOMIC_UNLOCK; +} + +bool ModelAction::is_trylock() const +{ + return type == ATOMIC_TRYLOCK; +} + +bool ModelAction::is_success_lock() const +{ + return type == ATOMIC_LOCK || (type == ATOMIC_TRYLOCK && value == VALUE_TRYSUCCESS); +} + +bool ModelAction::is_failed_trylock() const +{ + return (type == ATOMIC_TRYLOCK && value == VALUE_TRYFAILED); } bool ModelAction::is_read() const @@ -51,6 +107,11 @@ bool ModelAction::is_rmwc() const return type == ATOMIC_RMWC; } +bool ModelAction::is_fence() const +{ + return type == ATOMIC_FENCE; +} + bool ModelAction::is_initialization() const { return type == ATOMIC_INIT; @@ -96,8 +157,8 @@ bool ModelAction::same_thread(const ModelAction *act) const } void ModelAction::copy_typeandorder(ModelAction * act) { - this->type=act->type; - this->order=act->order; + this->type = act->type; + this->order = act->order; } /** This method changes an existing read part of an RMW action into either: @@ -125,7 +186,7 @@ void ModelAction::process_rmw(ModelAction * act) { * @param act is the action to consider exploring a reordering. * @return tells whether we have to explore a reordering. */ -bool ModelAction::is_synchronizing(const ModelAction *act) const +bool ModelAction::could_synchronize_with(const ModelAction *act) const { //Same thread can't be reordered if (same_thread(act)) @@ -137,37 +198,97 @@ bool ModelAction::is_synchronizing(const ModelAction *act) const // Explore interleavings of seqcst writes to guarantee total order // of seq_cst operations that don't commute - if (is_write() && is_seqcst() && act->is_write() && act->is_seqcst()) + if ((is_write() || act->is_write()) && is_seqcst() && act->is_seqcst()) return true; // Explore synchronizing read/write pairs if (is_read() && is_acquire() && act->is_write() && act->is_release()) return true; - if (is_write() && is_release() && act->is_read() && act->is_acquire()) - return true; // Otherwise handle by reads_from relation return false; } -void ModelAction::create_cv(const ModelAction *parent) +bool ModelAction::is_conflicting_lock(const ModelAction *act) const { - ASSERT(cv == NULL); + //Must be different threads to reorder + if (same_thread(act)) + return false; + + //Try to reorder a lock past a successful lock + if (act->is_success_lock()) + return true; + + //Try to push a successful trylock past an unlock + if (act->is_unlock() && is_trylock() && value == VALUE_TRYSUCCESS) + return true; + + return false; +} +/** + * Create a new clock vector for this action. Note that this function allows a + * user to clobber (and leak) a ModelAction's existing clock vector. A user + * should ensure that the vector has already either been rolled back + * (effectively "freed") or freed. + * + * @param parent A ModelAction from which to inherit a ClockVector + */ +void ModelAction::create_cv(const ModelAction *parent) +{ if (parent) cv = new ClockVector(parent->cv, this); else cv = new ClockVector(NULL, this); } +void ModelAction::set_try_lock(bool obtainedlock) { + if (obtainedlock) + value=VALUE_TRYSUCCESS; + else + value=VALUE_TRYFAILED; +} -/** Update the model action's read_from action */ -void ModelAction::read_from(const ModelAction *act) +/** + * Update the model action's read_from action + * @param act The action to read from; should be a write + * @return True if this read established synchronization + */ +bool ModelAction::read_from(const ModelAction *act) { ASSERT(cv); - if (act->is_release() && this->is_acquire()) - cv->merge(act->cv); reads_from = act; + if (act != NULL && this->is_acquire()) { + rel_heads_list_t release_heads; + model->get_release_seq_heads(this, &release_heads); + int num_heads = release_heads.size(); + for (unsigned int i = 0; i < release_heads.size(); i++) + if (!synchronize_with(release_heads[i])) { + model->set_bad_synchronization(); + num_heads--; + } + return num_heads > 0; + } + return false; +} + +/** + * Synchronize the current thread with the thread corresponding to the + * ModelAction parameter. + * @param act The ModelAction to synchronize with + * @return True if this is a valid synchronization; false otherwise + */ +bool ModelAction::synchronize_with(const ModelAction *act) { + if (*this < *act && type != THREAD_JOIN && type != ATOMIC_LOCK) + return false; + model->check_promises(act->get_tid(), cv, act->cv); + cv->merge(act->cv); + return true; +} + +bool ModelAction::has_synchronized_with(const ModelAction *act) const +{ + return cv->has_synchronized_with(act->cv); } /** @@ -181,9 +302,10 @@ bool ModelAction::happens_before(const ModelAction *act) const return act->cv->synchronized_since(this); } -void ModelAction::print(void) const +/** @brief Print nicely-formatted info about this ModelAction */ +void ModelAction::print() const { - const char *type_str; + const char *type_str, *mo_str; switch (this->type) { case THREAD_CREATE: type_str = "thread create"; @@ -197,6 +319,9 @@ void ModelAction::print(void) const case THREAD_JOIN: type_str = "thread join"; break; + case THREAD_FINISH: + type_str = "thread finish"; + break; case ATOMIC_READ: type_str = "atomic read"; break; @@ -206,6 +331,9 @@ void ModelAction::print(void) const case ATOMIC_RMW: type_str = "atomic rmw"; break; + case ATOMIC_FENCE: + type_str = "fence"; + break; case ATOMIC_RMWR: type_str = "atomic rmwr"; break; @@ -215,16 +343,50 @@ void ModelAction::print(void) const case ATOMIC_INIT: type_str = "init atomic"; break; + case ATOMIC_LOCK: + type_str = "lock"; + break; + case ATOMIC_UNLOCK: + type_str = "unlock"; + break; + case ATOMIC_TRYLOCK: + type_str = "trylock"; + break; default: type_str = "unknown type"; } uint64_t valuetoprint=type==ATOMIC_READ?(reads_from!=NULL?reads_from->value:VALUE_NONE):value; - printf("(%3d) Thread: %-2d Action: %-13s MO: %d Loc: %14p Value: %-12" PRIu64, - seq_number, id_to_int(tid), type_str, order, location, valuetoprint); - if (reads_from) - printf(" Rf: %d", reads_from->get_seq_number()); + switch (this->order) { + case std::memory_order_relaxed: + mo_str = "relaxed"; + break; + case std::memory_order_acquire: + mo_str = "acquire"; + break; + case std::memory_order_release: + mo_str = "release"; + break; + case std::memory_order_acq_rel: + mo_str = "acq_rel"; + break; + case std::memory_order_seq_cst: + mo_str = "seq_cst"; + break; + default: + mo_str = "unknown"; + break; + } + + printf("(%3d) Thread: %-2d Action: %-13s MO: %7s Loc: %14p Value: %-12" PRIu64, + seq_number, id_to_int(tid), type_str, mo_str, location, valuetoprint); + if (is_read()) { + if (reads_from) + printf(" Rf: %d", reads_from->get_seq_number()); + else + printf(" Rf: ?"); + } if (cv) { printf("\t"); cv->print();