From f72422ccaade8480b0449217dd7f1833a902db85 Mon Sep 17 00:00:00 2001 From: Scott Michelson Date: Fri, 27 Oct 2017 17:33:45 -0700 Subject: [PATCH] LOG_EVERY_N instead of every time Summary: when queues fill, this starts blowing up, affecting server performance and making logs useless. It's useful to know queues are full, but we don't need the log every time we try to append Reviewed By: yfeldblum Differential Revision: D6175784 fbshipit-source-id: b4e6966087c4a6f9fba51d7f9193b9f41e13b899 --- folly/io/async/AsyncServerSocket.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/folly/io/async/AsyncServerSocket.cpp b/folly/io/async/AsyncServerSocket.cpp index 19bc823f..0d3684ed 100644 --- a/folly/io/async/AsyncServerSocket.cpp +++ b/folly/io/async/AsyncServerSocket.cpp @@ -962,8 +962,8 @@ void AsyncServerSocket::dispatchSocket(int socket, // should use pauseAccepting() to temporarily back off accepting new // connections, before they reach the point where their threads can't // even accept new messages. - LOG(ERROR) << "failed to dispatch newly accepted socket:" - << " all accept callback queues are full"; + LOG_EVERY_N(ERROR, 100) << "failed to dispatch newly accepted socket:" + << " all accept callback queues are full"; closeNoInt(socket); if (connectionEventCallback_) { connectionEventCallback_->onConnectionDropped(socket, addr); @@ -1002,9 +1002,10 @@ void AsyncServerSocket::dispatchError(const char *msgstr, int errnoValue) { if (callbackIndex_ == startingIndex) { // The notification queues for all of the callbacks were full. // We can't really do anything at this point. - LOG(ERROR) << "failed to dispatch accept error: all accept callback " - "queues are full: error msg: " << - msg.msg.c_str() << errnoValue; + LOG_EVERY_N(ERROR, 100) + << "failed to dispatch accept error: all accept" + << " callback queues are full: error msg: " << msg.msg << ": " + << errnoValue; return; } info = nextCallback(); -- 2.34.1