From cd69a53aed1a97579a45d48e5a82786651f568df Mon Sep 17 00:00:00 2001 From: Orvid King Date: Mon, 17 Aug 2015 10:37:08 -0700 Subject: [PATCH] Remove `unsigned char v = static_cast(v);` Summary: MSVC spotted this very suspicious line when I was running it with /analyze, and complained about using an unitialized variable. This variable isn't used anywhere in the function, and is initializing itself with itself. I have no idea how this compiled in the first place, but apparently it does. This removes the line in question. Closes #295 Reviewed By: @yfeldblum, @paulbiss Differential Revision: D2340688 Pulled By: @sgolemon --- folly/String-inl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/folly/String-inl.h b/folly/String-inl.h index ff085713..1a4edb7d 100644 --- a/folly/String-inl.h +++ b/folly/String-inl.h @@ -203,7 +203,6 @@ void uriUnescape(StringPiece str, String& out, UriEscapeMode mode) { // this is faster than calling push_back repeatedly. while (p != str.end()) { char c = *p; - unsigned char v = static_cast(v); switch (c) { case '%': { -- 2.34.1