From bbc518064c581d8b22bd4346aee001dad02cc68d Mon Sep 17 00:00:00 2001 From: Yedidya Feldblum Date: Fri, 2 Jun 2017 17:51:28 -0700 Subject: [PATCH] Apply clang-format to folly/gen/ (partial: namespace) Summary: [Folly] Apply `clang-format` to `folly/gen/` (partial: namespace). With some manual rearrangement in the places where `clang-format` does awkward things, with the result that clang-format over `folly/gen/` becomes a no-op. Reviewed By: Orvid Differential Revision: D5177428 fbshipit-source-id: 17f51d00454a7be7f29dcf1a2ff3d0eaf1de72ab --- folly/gen/Base-inl.h | 7 ++++--- folly/gen/Base.h | 9 +++++---- folly/gen/Combine-inl.h | 6 +++--- folly/gen/Combine.h | 6 +++--- folly/gen/Core-inl.h | 7 ++++--- folly/gen/Core.h | 7 ++++--- folly/gen/File-inl.h | 5 +++-- folly/gen/File.h | 6 +++--- folly/gen/Parallel.h | 7 ++++--- folly/gen/ParallelMap-inl.h | 9 ++++++--- folly/gen/ParallelMap.h | 9 +++++---- folly/gen/String-inl.h | 6 +++--- folly/gen/String.h | 6 +++--- folly/gen/test/BaseTest.cpp | 2 +- folly/gen/test/StringBenchmark.cpp | 2 +- 15 files changed, 52 insertions(+), 42 deletions(-) diff --git a/folly/gen/Base-inl.h b/folly/gen/Base-inl.h index 66d2b92c..959696e8 100644 --- a/folly/gen/Base-inl.h +++ b/folly/gen/Base-inl.h @@ -22,7 +22,8 @@ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wshadow" -namespace folly { namespace gen { +namespace folly { +namespace gen { /** * ArgumentReference - For determining ideal argument type to receive a value. @@ -2336,7 +2337,7 @@ inline detail::Skip skip(size_t count) { return detail::Skip(count); } inline detail::Batch batch(size_t batchSize) { return detail::Batch(batchSize); } - -}} // folly::gen +} // gen +} // folly #pragma GCC diagnostic pop diff --git a/folly/gen/Base.h b/folly/gen/Base.h index a5d4b05a..cf3eca13 100644 --- a/folly/gen/Base.h +++ b/folly/gen/Base.h @@ -78,9 +78,10 @@ * * To learn more about this library, including the use of infinite generators, * see the examples in the comments, or the docs (coming soon). -*/ + */ -namespace folly { namespace gen { +namespace folly { +namespace gen { class Less { public: @@ -814,7 +815,7 @@ template(fallback)); } - -}} // folly::gen +} // gen +} // folly #include diff --git a/folly/gen/Combine-inl.h b/folly/gen/Combine-inl.h index 58daf078..4e293d11 100644 --- a/folly/gen/Combine-inl.h +++ b/folly/gen/Combine-inl.h @@ -201,7 +201,7 @@ class MergeTuples { } }; -} // namespace detail +} // namespace detail // TODO(mcurtiss): support zip() for N>1 operands. Because of variadic problems, // this might not be easily possible until gcc4.8 is available. @@ -211,5 +211,5 @@ Zip zip(Source&& source) { return Zip(std::forward(source)); } -} // namespace gen -} // namespace folly +} // namespace gen +} // namespace folly diff --git a/folly/gen/Combine.h b/folly/gen/Combine.h index c665efce..42ca358f 100644 --- a/folly/gen/Combine.h +++ b/folly/gen/Combine.h @@ -29,7 +29,7 @@ class Interleave; template class Zip; -} // namespace detail +} // namespace detail template::type, @@ -38,7 +38,7 @@ Interleave interleave(Source2&& source2) { return Interleave(std::forward(source2)); } -} // namespace gen -} // namespace folly +} // namespace gen +} // namespace folly #include diff --git a/folly/gen/Core-inl.h b/folly/gen/Core-inl.h index 2868224b..87891e36 100644 --- a/folly/gen/Core-inl.h +++ b/folly/gen/Core-inl.h @@ -25,7 +25,8 @@ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wshadow" -namespace folly { namespace gen { +namespace folly { +namespace gen { /** * IsCompatibleSignature - Trait type for testing whether a given Functor @@ -372,7 +373,7 @@ public: }; } // detail - -}} // folly::gen +} // gen +} // folly #pragma GCC diagnostic pop diff --git a/folly/gen/Core.h b/folly/gen/Core.h index 5181355f..dfd93d62 100644 --- a/folly/gen/Core.h +++ b/folly/gen/Core.h @@ -17,7 +17,8 @@ #pragma once #define FOLLY_GEN_CORE_H_ -namespace folly { namespace gen { +namespace folly { +namespace gen { template class GenImpl; @@ -37,7 +38,7 @@ template class Chain; } // detail - -}} // folly::gen +} // gen +} // folly #include diff --git a/folly/gen/File-inl.h b/folly/gen/File-inl.h index 591ead34..d098dbd0 100644 --- a/folly/gen/File-inl.h +++ b/folly/gen/File-inl.h @@ -129,7 +129,7 @@ inline auto byLineImpl(File file, char delim, bool keepDelimiter) | resplit(delim, keepDelimiter); } -} // !detail +} // !detail /** * Generator which reads lines from a file. @@ -161,4 +161,5 @@ inline auto byLine(int fd, char delim = '\n') inline auto byLine(const char* f, char delim = '\n') -> decltype(byLine(File(f), delim)) { return byLine(File(f), delim); } -}} // !folly::gen +} // !gen +} // !folly diff --git a/folly/gen/File.h b/folly/gen/File.h index b5dfc4b3..4157a07d 100644 --- a/folly/gen/File.h +++ b/folly/gen/File.h @@ -27,7 +27,7 @@ namespace gen { namespace detail { class FileReader; class FileWriter; -} // namespace detail +} // namespace detail /** * Generator that reads from a file with a buffer of the given size. @@ -64,7 +64,7 @@ template S toFile(File file, std::unique_ptr buffer) { return S(std::move(file), std::move(buffer)); } - -}} // !folly::gen +} // !gen +} // !folly #include diff --git a/folly/gen/Parallel.h b/folly/gen/Parallel.h index d4012d17..85e956ea 100644 --- a/folly/gen/Parallel.h +++ b/folly/gen/Parallel.h @@ -21,7 +21,8 @@ #include -namespace folly { namespace gen { +namespace folly { +namespace gen { namespace detail { template @@ -102,7 +103,7 @@ template > Sub sub(Sink sink) { return Sub(std::move(sink)); } - -}} // !namespace folly::gen +} // !namespace gen +} // !namespace folly #include diff --git a/folly/gen/ParallelMap-inl.h b/folly/gen/ParallelMap-inl.h index 47fd9bcb..7975b21d 100644 --- a/folly/gen/ParallelMap-inl.h +++ b/folly/gen/ParallelMap-inl.h @@ -28,7 +28,9 @@ #include #include -namespace folly { namespace gen { namespace detail { +namespace folly { +namespace gen { +namespace detail { /** * PMap - Map in parallel (using threads). For producing a sequence of @@ -250,5 +252,6 @@ class PMap : public Operator> { return Gen(source.self(), pred_, nThreads_); } }; - -}}} // namespaces +} // namespace detail +} // namespace gen +} // namespace folly diff --git a/folly/gen/ParallelMap.h b/folly/gen/ParallelMap.h index 4e9da1ef..e17acc93 100644 --- a/folly/gen/ParallelMap.h +++ b/folly/gen/ParallelMap.h @@ -19,14 +19,15 @@ #include -namespace folly { namespace gen { +namespace folly { +namespace gen { namespace detail { template class PMap; -} // namespace detail +} // namespace detail /** * Run `pred` in parallel in nThreads. Results are returned in the @@ -42,7 +43,7 @@ template diff --git a/folly/gen/String-inl.h b/folly/gen/String-inl.h index be9f1d54..64e86f98 100644 --- a/folly/gen/String-inl.h +++ b/folly/gen/String-inl.h @@ -412,7 +412,7 @@ class SplitTo { #pragma GCC diagnostic pop -} // namespace detail +} // namespace detail -} // namespace gen -} // namespace folly +} // namespace gen +} // namespace folly diff --git a/folly/gen/String.h b/folly/gen/String.h index fde954a0..2b8b02cd 100644 --- a/folly/gen/String.h +++ b/folly/gen/String.h @@ -41,7 +41,7 @@ template class SplitTo; -} // namespace detail +} // namespace detail /** * Split the output from a generator into StringPiece "lines" delimited by @@ -242,7 +242,7 @@ StreamSplitter streamSplitter(char delimiter, return StreamSplitter(delimiter, std::move(pieceCb), capacity); } -} // namespace gen -} // namespace folly +} // namespace gen +} // namespace folly #include diff --git a/folly/gen/test/BaseTest.cpp b/folly/gen/test/BaseTest.cpp index 999d74b9..32734719 100644 --- a/folly/gen/test/BaseTest.cpp +++ b/folly/gen/test/BaseTest.cpp @@ -918,7 +918,7 @@ class TestIntSeq : public GenImpl { TestIntSeq& operator=(const TestIntSeq&) = delete; }; -} // namespace +} // namespace TEST(Gen, NoGeneratorCopies) { EXPECT_EQ(15, TestIntSeq() | sum); diff --git a/folly/gen/test/StringBenchmark.cpp b/folly/gen/test/StringBenchmark.cpp index cffe89c1..c6de1ed4 100644 --- a/folly/gen/test/StringBenchmark.cpp +++ b/folly/gen/test/StringBenchmark.cpp @@ -61,7 +61,7 @@ void initStringResplitterBenchmark() { size_t len(folly::StringPiece s) { return s.size(); } -} // namespace +} // namespace BENCHMARK(StringResplitter_Big, iters) { size_t s = 0; -- 2.34.1