From b367f0fada0a53564f83e5072bbd45994a1c0795 Mon Sep 17 00:00:00 2001 From: Victor Gao Date: Fri, 9 Jun 2017 11:26:26 -0700 Subject: [PATCH 1/1] apply clang-tidy modernize-use-override Summary: Use clang-tidy to mechanically add missing `override` and remove redundant `virtual`. Reviewed By: igorsugak Differential Revision: D5211868 fbshipit-source-id: 6a85f7c4a543a4c9345ec5b0681a8853707343dc --- folly/io/Compression.cpp | 2 +- folly/io/Compression.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/folly/io/Compression.cpp b/folly/io/Compression.cpp index d014b69a..8dd19bc7 100644 --- a/folly/io/Compression.cpp +++ b/folly/io/Compression.cpp @@ -997,7 +997,7 @@ class ZlibStreamCodec final : public StreamCodec { static std::unique_ptr createCodec(int level, CodecType type); static std::unique_ptr createStream(int level, CodecType type); explicit ZlibStreamCodec(int level, CodecType type); - ~ZlibStreamCodec(); + ~ZlibStreamCodec() override; std::vector validPrefixes() const override; bool canUncompress(const IOBuf* data, Optional uncompressedLength) diff --git a/folly/io/Compression.h b/folly/io/Compression.h index e9bcd2a5..0a2423bf 100644 --- a/folly/io/Compression.h +++ b/folly/io/Compression.h @@ -237,7 +237,7 @@ class Codec { class StreamCodec : public Codec { public: - virtual ~StreamCodec() {} + ~StreamCodec() override {} /** * Does the codec need the data length before compression streaming? @@ -359,7 +359,7 @@ class StreamCodec : public Codec { private: // default: Implemented using the streaming API. std::unique_ptr doCompress(const folly::IOBuf* data) override; - virtual std::unique_ptr doUncompress( + std::unique_ptr doUncompress( const folly::IOBuf* data, folly::Optional uncompressedLength) override; -- 2.34.1