From 19859f96226810883e0f967e49d6d73912ae900d Mon Sep 17 00:00:00 2001 From: Christopher Dykes Date: Thu, 15 Jun 2017 16:53:09 -0700 Subject: [PATCH] Ensure LogWriter::writeMessage(std::string&&) is in the overload set of ImmediateFileWriter Summary: As MSVC correctly warns via C4266, the overload sets of functions in base classes are not part of the overload set in derived classes where you've declared an overload (or override) unless you've explicitly imported it. Reviewed By: simpkins Differential Revision: D5260056 fbshipit-source-id: bbbeeea3c13201a3a6eba6e62cfa5a49a9470d43 --- folly/experimental/logging/ImmediateFileWriter.h | 1 + 1 file changed, 1 insertion(+) diff --git a/folly/experimental/logging/ImmediateFileWriter.h b/folly/experimental/logging/ImmediateFileWriter.h index 8f49c1fc..a029e73f 100644 --- a/folly/experimental/logging/ImmediateFileWriter.h +++ b/folly/experimental/logging/ImmediateFileWriter.h @@ -46,6 +46,7 @@ class ImmediateFileWriter : public LogWriter { */ explicit ImmediateFileWriter(folly::File&& file); + using LogWriter::writeMessage; void writeMessage(folly::StringPiece buffer) override; private: -- 2.34.1