6 years agoMark constexpr values needed within non-implicitly-capturing lambdas as static
Christopher Dykes [Sat, 20 May 2017 03:33:41 +0000 (20:33 -0700)]
Mark constexpr values needed within non-implicitly-capturing lambdas as static

Summary: MSVC needs these to be marked as `static` in order to be accessible within the lambdas without capturing them.

Reviewed By: yfeldblum

Differential Revision: D5099607

fbshipit-source-id: 0270e2191d504f74b1902789b662e1766b2056c4

6 years agoWork around a compiler crash in VS 2017.3 Preview 1
Christopher Dykes [Sat, 20 May 2017 01:37:20 +0000 (18:37 -0700)]
Work around a compiler crash in VS 2017.3 Preview 1

MSVC is being grumpy, and I want to continue to work from the preview build, so commit the workaround, as there's no significant difference.
Upstream bug report:

Reviewed By: yfeldblum

Differential Revision: D5099876

fbshipit-source-id: 64d5573d78b14339ff3177dd910a22787463ccd2

6 years agoFix the header being included when trying to specialize std::hash
Christopher Dykes [Fri, 19 May 2017 23:42:25 +0000 (16:42 -0700)]
Fix the header being included when trying to specialize std::hash

Summary: `std::hash` lives in `<functional>`, not `<xstddef>`.

Reviewed By: yfeldblum

Differential Revision: D5097468

fbshipit-source-id: d0684491d1d4b0f83f07ad837a66a915ce2ec8a6

Shoaib Meenai [Fri, 19 May 2017 23:11:07 +0000 (16:11 -0700)]

Summary: 4.0 has been out for three months now, so it's pretty safe to remove them.

Reviewed By: Orvid, yfeldblum, mzlee

Differential Revision: D5096007

fbshipit-source-id: 595c3e86cd7cf1a1706f27f107fb0af8ab89a676

6 years agoStampedPtr: use async-signal-safe assert
Xiao Shi [Fri, 19 May 2017 14:23:29 +0000 (07:23 -0700)]
StampedPtr: use async-signal-safe assert

Summary: Use SafeAssert instead of assert.

Reviewed By: nbronson

Differential Revision: D5085575

fbshipit-source-id: daeff427b9b1fc5dff6ea986d16a70364acd2dd7

6 years agoThreadedRepeatingFunctionRunner: Name all the threads
Alexey Spiridonov [Wed, 17 May 2017 22:56:39 +0000 (15:56 -0700)]
ThreadedRepeatingFunctionRunner: Name all the threads

Summary: Name all repeating function threads for ease of debugging.

Reviewed By: yfeldblum

Differential Revision: D5065281

fbshipit-source-id: e875e654dfa644a265e44416baf5fbf23c9da434

6 years agoTweak basic_fbstring construction from std types
Phil Willoughby [Wed, 17 May 2017 11:05:52 +0000 (04:05 -0700)]
Tweak basic_fbstring construction from std types

Previously we defined an assignment from std::string on all basic_fbstring
specialisations, but we don't actually want to do that because it's nonsense to
construct a basic_fbstring<char16_t> from an std::string. Equally it's not
nonsense to construct one of those from an std::u16string but the previous code
didn't allow it.

We now permit basic_fbstring<C, T, A1, S> to be constructed or assigned-to from
std::basic_string<C, T, A2>. The character type and traits must match but the
allocator is permitted to vary.

Background on my determination that the allocator type was unimportant and
could be disregarded: In part this is because C++17 made the same choice for
basic_string_view. Another factor was C++17's std::pmr::string (it's a
std::string with a different allocator) which I thought should be convertible
to fbstring in the same way as std::string.

Reviewed By: Gownta

Differential Revision: D5060569

fbshipit-source-id: f8984c528b76356240970c67916c58995d3f228d

6 years agoSimplify ThreadedRepeatingFunctionRunner by requiring classes that contain it to...
Alexey Spiridonov [Tue, 16 May 2017 21:05:49 +0000 (14:05 -0700)]
Simplify ThreadedRepeatingFunctionRunner by requiring classes that contain it to be final

Summary: It is pretty confusing to inherit from classes that manage threads. See the docblocks in this diff.

Reviewed By: yfeldblum

Differential Revision: D4973498

fbshipit-source-id: 2fcf1ddf68ef46d4d78a9b40f304262064862715

6 years agogate sse42 implementation of checksum for x86 only
Stephen Chen [Tue, 16 May 2017 17:06:47 +0000 (10:06 -0700)]
gate sse42 implementation of checksum for x86 only

folly/detail/ChecksumDetail.h gets included in Checksum.h and it
unconditionally includes <immintrin.h>. This doesn't compile on
aarch64 platform. Add #ifdefs for this.

Reviewed By: yfeldblum

Differential Revision: D5048636

fbshipit-source-id: d2074eb1b01487b02d95f3e2eebe683237d918fe

6 years agoFix violations of unused-lambda-capture
Yedidya Feldblum [Tue, 16 May 2017 15:07:22 +0000 (08:07 -0700)]
Fix violations of unused-lambda-capture

Summary: [Folly] Fix violations of `unused-lambda-capture`.

Reviewed By: Orvid

Differential Revision: D5060391

fbshipit-source-id: 34aabc847719603d13da8f2b52a7ec187d803a4a

6 years agoSwitch implicit references of folly::make_unique to std::make_unique
Christopher Dykes [Tue, 16 May 2017 01:23:54 +0000 (18:23 -0700)]
Switch implicit references of folly::make_unique to std::make_unique

Summary: It's *almost* dead. This switches things to explicitly reference `std::make_unique` so that `folly::make_unique` can be marked as deprecated until mobile catches up and it can be killed completely.

Reviewed By: yfeldblum

Differential Revision: D5026584

fbshipit-source-id: aefc8cb3de84583fd3722fdb9dfea620884590c5

6 years agoDrop support for deprecated associative containers
Yedidya Feldblum [Mon, 15 May 2017 19:31:24 +0000 (12:31 -0700)]
Drop support for deprecated associative containers

[Folly] Drop support for deprecated associative containers.

Namely, `__gnu_cxx::hash_set` and `__gnu_cxx::hash_map`.

Reviewed By: wqfish

Differential Revision: D5058813

fbshipit-source-id: ebbcf10765f5d06776ee8f697cfb78614a3a566c

6 years agoStampedPtr
Nathan Bronson [Mon, 15 May 2017 19:12:55 +0000 (12:12 -0700)]

This diff adds StampedPtr, which packs a pointer and a uint16_t into
a uint64_t with maximum portability and without adding any additional

Reviewed By: yfeldblum, davidtgoldblatt

Differential Revision: D4804614

fbshipit-source-id: 25fe7aff47d1e126ac8edfff4eb0bbb1d34071aa

6 years agoIn AsyncSocket::handleErrMessages() inside the loop check if the callback was not...
Maxim Georgiev [Mon, 15 May 2017 19:01:31 +0000 (12:01 -0700)]
In AsyncSocket::handleErrMessages() inside the loop check if the callback was not uninstalled

Summary: AsyncSocket::handleErrMessages() should check if the error message callback is still installing before calling it, since the callback could be uninstaled on the previous loop iteration.

Reviewed By: yfeldblum

Differential Revision: D5051001

fbshipit-source-id: fc01932c0d36bd8f72bf1905f12211fb83d28674

6 years agoList the new GCC 4.9 and C++14 minimum requirement
Yedidya Feldblum [Mon, 15 May 2017 18:33:10 +0000 (11:33 -0700)]
List the new GCC 4.9 and C++14 minimum requirement

[Folly] List the new GCC 4.9 and C++14 minimum requirement.

We no longer support GCC 4.8 or C++11.

Closes #590.

Reviewed By: Orvid, mzlee

Differential Revision: D5058942

fbshipit-source-id: 0545d1bb294494e5ef5f17a40c9cf3ac688bd8d0

6 years agoFix compilation ChecksumDetail.cpp with MSVC
Arkady Shapkin [Mon, 15 May 2017 14:43:38 +0000 (07:43 -0700)]
Fix compilation ChecksumDetail.cpp with MSVC

MSVC doesn't support `^` and `&` operator for __m128i type

Reviewed By: yfeldblum, Orvid

Differential Revision: D5053356

Pulled By: djwatson

fbshipit-source-id: f789824052e0c679c265c83ad704109805c21402

6 years agoFix compilation on Linux systems without vDSO support v2017.05.15.00
Koen De Keyser [Sat, 13 May 2017 18:01:56 +0000 (11:01 -0700)]
Fix compilation on Linux systems without vDSO support

- The vDSO check code in is broken, and will always fail (uses AC_LANG_PROGRAM but with arguments in the AC_LANG_SOURCE style)
- On Linux, using dlopen/dlsym requires -ldl (libdl) during the link phase. This check was missing and this argument was not added to the linker arguments.
- On a Linux system without vDSO support, still uses vDSO in ClockGettimeWrappers.cpp

- Switched to AC_LANG_SOURCE
- Required libdl to exist when build target is Linux. This also adds this dependency to, resulting in fixing a dependency issue for Proxygen (recent Proxygen build would have issues in building examples due to failing linking step due to missing dlopen / dlsym / dlclose symbols)
- In ClockGettimeWrappers.cpp, checking if `__linux__` is set is not sufficient to determine that the system has vDSO support. The autoconf script already exposes a correct check: FOLLY_HAVE_LINUX_VDSO (this is already used in folly/detail/CacheLocality.cpp), so switched to that one.

Reviewed By: yfeldblum

Differential Revision: D5049816

Pulled By: Orvid

fbshipit-source-id: 58b2ed4c4101274505c61b4825accf262c0d56ef

6 years agoreturn range from AsyncIO::cancel(), fix test
Philip Pronin [Fri, 12 May 2017 23:07:57 +0000 (16:07 -0700)]
return range from AsyncIO::cancel(), fix test

Return not just number of cancelled ops, but all of them as well.
Test was incorrectly assuming `wait(1)` will return exactly one operation, fix
that as well.

Reviewed By: ot

Differential Revision: D5054684

fbshipit-source-id: 1c53c3f7ba855d1fcfeac8b1b27f90f0872d2c21

6 years agoexception_wrapper::get_object<>
Yedidya Feldblum [Fri, 12 May 2017 21:14:22 +0000 (14:14 -0700)]

[Folly] `exception_wrapper::get_object<>`.

Returns a pointer to the stored object, if the template type parameter is of the right sort.

Reviewed By: jsedgwick

Differential Revision: D5000720

fbshipit-source-id: 2869439085e8dfb56e6cb439794b03876b7d715c

6 years agoFix broken promise error in folly::retrying
Yinghai Lu [Fri, 12 May 2017 17:21:06 +0000 (10:21 -0700)]
Fix broken promise error in folly::retrying

Summary: This diff shows an issue in `folly::retrying`. When the future generation function throws an exception and `folly::retrying` is nested in another functor that returns Future, it will throw `broken promise` instead of the actual exception message, which can be very generic and confusing. Fix is to capture the exception so that exact error message can be propagated up.

Reviewed By: yfeldblum

Differential Revision: D5050690

fbshipit-source-id: 5b9b24977788f60aa778bb8e9cdf4281ea9a0023

6 years agoinclude folly/portability/Sockets.h instead of netinet/tcp.h
James Sedgwick [Fri, 12 May 2017 09:44:24 +0000 (02:44 -0700)]
include folly/portability/Sockets.h instead of netinet/tcp.h

Summary: To satisfy internal linter

Reviewed By: yfeldblum

Differential Revision: D4957870

fbshipit-source-id: 191ac768790fbd8cc8a4d24036c016644ff1d125

6 years agoadd FOLLY_FALLTHROUGH throughout to satisfy internal linter
James Sedgwick [Fri, 12 May 2017 04:31:22 +0000 (21:31 -0700)]
add FOLLY_FALLTHROUGH throughout to satisfy internal linter

Summary: changes as suggested by FB-internal linter

Reviewed By: yfeldblum

Differential Revision: D4957742

fbshipit-source-id: c9d94c477d24f153cab0d25edccfd39ff31fdfdf

6 years agoinclude folly/portability/OpenSSL.h instead of openssl/*.h
James Sedgwick [Fri, 12 May 2017 02:50:27 +0000 (19:50 -0700)]
include folly/portability/OpenSSL.h instead of openssl/*.h

Summary: suggested by internal linter

Reviewed By: Orvid

Differential Revision: D4958232

fbshipit-source-id: 69c67d80be092db17703d672524124ca5ef7ba32

6 years agoCopying a non-const FunctionRef lvalue should be a trivial operation
Eric Niebler [Thu, 11 May 2017 23:55:38 +0000 (16:55 -0700)]
Copying a non-const FunctionRef lvalue should be a trivial operation

Summary: Before this change, when a non-const FunctionRef lvalue is copied, it is treated as any other callable: it is wrapped with an indirection. That's semantically incorrect and potentially creates lifetime problems. Instead, use the compiler generated copy constructor, which only copies the object and function pointers.

Reviewed By: yfeldblum

Differential Revision: D5040843

fbshipit-source-id: f691060bdced2e287ba22d22b961c02c2b924147

6 years agoSwitch uncompressedLength to an Optional<uint64_t>
Nick Terrell [Thu, 11 May 2017 21:56:02 +0000 (14:56 -0700)]
Switch uncompressedLength to an Optional<uint64_t>

Summary: Instead of using `UNKNWON_UNCOMPRESSED_LENGTH` use an `Optional`.

Reviewed By: yfeldblum

Differential Revision: D5038919

fbshipit-source-id: 7fb60542277019996be3ff50509df5a5060cb1a0

6 years agoOutline `Optional::require_value()`
Ashwin Bharambe [Thu, 11 May 2017 20:29:41 +0000 (13:29 -0700)]
Outline `Optional::require_value()`

We would like to use `folly/Optional` in settings where exceptions
are disabled. An example is ObjC++ codebases where supporting exceptions
doesn't quite help (since objc_msgSend() can throw) and yet we need to pay the
additional binary size cost for the unwind tables.

This patch makes a small change to outline the "assert" utility included
inside Optional.h

Reviewed By: yfeldblum, mzlee

Differential Revision: D5030172

fbshipit-source-id: 7def3c6eda22c41c8cab2037444978e0a4c50abf

6 years agoAsyncIO::cancel
Philip Pronin [Thu, 11 May 2017 19:51:11 +0000 (12:51 -0700)]

It should be implemented with `io_cancel`, but it is not
supported (D682836), so still have to drain events, ignoring only
op callbacks.

Reviewed By: luciang, ot

Differential Revision: D5044020

fbshipit-source-id: 0bcd04c91a437fccaf2189ccf771a1cb61c68942

6 years agoFix a race on destruction of ScopedEventBaseThread
Victor Zverovich [Thu, 11 May 2017 16:19:42 +0000 (09:19 -0700)]
Fix a race on destruction of ScopedEventBaseThread

This diff fixes a race that happens on destruction of `ScopedEventBaseThread`.

Thread1: ~ScopedEventBaseThread()
Thread1: eb_.terminateLoopSoon() <- preempted just after stop_ = true
Thread2: eb->loopForever() in run(...) exits because stop_ is true
Thread2: ...
Thread2: eb->~EventBase()
Thread1: queue_->putMessage(nullptr) <- accesses destroyed EventBase

Reviewed By: yfeldblum

Differential Revision: D5042654

fbshipit-source-id: 95515ed7cde09ff5f125ef121bea86ab3907f98a

6 years agohasher instances for 8-bit and 16-bit integral types
Yedidya Feldblum [Thu, 11 May 2017 05:41:55 +0000 (22:41 -0700)]
hasher instances for 8-bit and 16-bit integral types

[Folly] `hasher` instances for 8-bit and 16-bit integral types.

Allowing the use of `Hash` with such types.

They are not necessarily the ideal algorithms for those widths, essentially forwarding to the 32-bit instances.

Reviewed By: luciang

Differential Revision: D5043094

fbshipit-source-id: 6ef96dfc8d1baf0a15b9bdd585b7c7672099e4f0

6 years agoAdd writable() to AsyncTransport
Kevin Chen [Thu, 11 May 2017 02:42:00 +0000 (19:42 -0700)]
Add writable() to AsyncTransport

This is useful for checking if it's possible to still write to a transport,
even if its read side is closed (for transports that support half shutdown,
like AsyncSocket). Default implementation just returns true for now (up
to implementers to override).

Reviewed By: yfeldblum

Differential Revision: D4982649

fbshipit-source-id: 0a9a2e2b745ea3db57e9f151f3a8634e1bda2465

6 years agoadd missing const to fix `folly::toDynamic` on `std::vector<bool>`
Mathieu Baudet [Thu, 11 May 2017 02:05:01 +0000 (19:05 -0700)]
add missing const to fix `folly::toDynamic` on `std::vector<bool>`

Summary: [folly] add missing const to fix `folly::toDynamic` on `std::vector<bool>`

Reviewed By: ender-wieczorek, yfeldblum

Differential Revision: D5039403

fbshipit-source-id: edd052c7d1d832d424166cba15fcd9f4f8bd219c

6 years agoAdd pollWithRusage to Subprocess
Victor Loh [Wed, 10 May 2017 06:24:57 +0000 (23:24 -0700)]
Add pollWithRusage to Subprocess

I was looking for a way to get rusage of a particular pid because
getrusage isn't good enough since it records the rusage of all the children
that has been terminated (and waited for). Even though wait4 is marked as
deprecated, wait3 (the cousin of wait4) is still being used in places like
time. Furthermore, there is no suitable replacement to get rusage with wait*.

Reviewed By: yfeldblum

Differential Revision: D5008084

fbshipit-source-id: 6e511ebec7464d21309e5112aca95083e9307ea1

6 years agoRevert D4982969: [Folly] Destroy promise/future callback functions before waking...
Anton Lunov [Wed, 10 May 2017 05:48:50 +0000 (22:48 -0700)]
Revert D4982969: [Folly] Destroy promise/future callback functions before waking waiters

Summary: This reverts commit 71134c1657bdd4c38c12d8ca17f8335ef4c27352

Differential Revision: D4982969

fbshipit-source-id: fc1e766a5fd03fbd02c345904c3c6587013f38d5

6 years agoFix FBString with MSVC
Arkadiy Shapkin [Tue, 9 May 2017 22:38:27 +0000 (15:38 -0700)]
Fix FBString with MSVC

Summary: Closes

Reviewed By: ericniebler

Differential Revision: D5029876

Pulled By: yfeldblum

fbshipit-source-id: 6a8f16373dcfb1c7b2741eb808da0f6dbc4207b6

6 years agoAdd folly::Identity function object to Utility.h; replace AtomicHashArray's AHAIdenti...
Eric Niebler [Tue, 9 May 2017 21:30:11 +0000 (14:30 -0700)]
Add folly::Identity function object to Utility.h; replace AtomicHashArray's AHAIdentity and folly/gen's Identity with it

Summary: Code duplication is bad.

Reviewed By: yfeldblum

Differential Revision: D5011806

fbshipit-source-id: cab7bb3af1c934a5a63cd3fb98aa33f2578aebfb

6 years agoSupport static gflags library
Arkady Shapkin [Tue, 9 May 2017 03:43:36 +0000 (20:43 -0700)]
Support static gflags library

Summary: Closes

Reviewed By: yfeldblum

Differential Revision: D5022071

Pulled By: Orvid

fbshipit-source-id: 2506087de76ba4544bf68a330bc2a18977c65f28

6 years agoDestroy promise/future callback functions before waking waiters
Yedidya Feldblum [Tue, 9 May 2017 01:50:51 +0000 (18:50 -0700)]
Destroy promise/future callback functions before waking waiters

Code may pass a callback which captures an object with a destructor which mutates through a stored reference, triggering heap-use-after-free or stack-use-after-scope.

void performDataRace() {
  auto number = std::make_unique<int>(0);
  auto guard = folly::makeGuard([&number] { *number = 1; });
  folly::via(getSomeExecutor(), [guard = std::move(guard)]() mutable {}).wait();
  // data race - we may wake and destruct number before guard is destructed on the
  // executor thread, which is both stack-use-after-scope and heap-use-after-free!

We can avoid this condition by always destructing the provided functor before setting any result on the promise.

Reviewed By: spacedentist

Differential Revision: D4982969

fbshipit-source-id: 71134c1657bdd4c38c12d8ca17f8335ef4c27352

6 years agoback_emplace_iterator and related classes and utility functions
Philipp Unterbrunner [Tue, 9 May 2017 01:37:28 +0000 (18:37 -0700)]
back_emplace_iterator and related classes and utility functions

C++ up to and including C++17 lacks an alternative to std::back_inserter() that uses emplace_back() instead of push_back(). This causes unnecessary temporary objects in some cases, when using std::back_inserter() together with STL functions such as std::copy() or std::transform(). The same holds for std::front_inserter() and std::inserter().
This diff introduces folly::back_emplacer(), folly::front_emplacer(), folly::emplacer(), and related iterator classes, which call emplace_back(), emplace_front(), and emplace() respectively, with perfect forwarding of any arguments to the output iterator's operator=.
Includes support for variadic emplacement / multi-argument constructors through a utility function folly::make_emplace_args() which packs its arguments into a special tuple for use with operator=.

Reviewed By: ericniebler

Differential Revision: D4897174

fbshipit-source-id: c85c30c457e0c946938051819baa662d1a0b8ca1

6 years agoCodemod folly::make_unique to std::make_unique
Christopher Dykes [Tue, 9 May 2017 01:16:18 +0000 (18:16 -0700)]
Codemod folly::make_unique to std::make_unique

Summary: There are still some upstream references to `folly::make_unique` that need to be removed before it can be full killed, but this gets it most of the way there.

Reviewed By: yfeldblum

Differential Revision: D5024310

fbshipit-source-id: 6cfe8ea93662be18bb55588c8200dec72946e205

6 years agochange EXPECT_EQ(false, ... to EXPECT_FALSE(...; ditto for true/EXPECT_TRUE
Jim Meyering [Mon, 8 May 2017 23:41:07 +0000 (16:41 -0700)]
change EXPECT_EQ(false, ... to EXPECT_FALSE(...; ditto for true/EXPECT_TRUE

Change every instance of EXPECT_EQ(false, ... to the simpler/shorter EXPECT_FALSE(...
Likewise, convert each EXPECT_EQ(true, ... to EXPECT_TRUE(...

Differential Revision: D5019004

fbshipit-source-id: 0203f10fa47237f869a75a057ac4456ef03e1f53

6 years agoMove OpenSSLPtrTypes.h from folly/io/async/ssl to folly/ssl
Anirudh Ramachandran [Mon, 8 May 2017 19:21:47 +0000 (12:21 -0700)]
Move OpenSSLPtrTypes.h from folly/io/async/ssl to folly/ssl

There's nothing io/async/ssl-specific in this file. Moving to the
top-level directory will help this be more discoverable. Part of general cleanup
for io/async/ssl

Reviewed By: yfeldblum

Differential Revision: D5005566

fbshipit-source-id: 66a05a2139ee80a6d63791d1851da3f1858e8abf

6 years agoAdd hardware crc impl
Dave Watson [Mon, 8 May 2017 16:44:17 +0000 (09:44 -0700)]
Add hardware crc impl

A faster crc32 impl for folly.  Similar to crc32c, except
intel doesn't provide crc32 directly in hardware - instead, pclmul can be used,
which is ~2x slower than crc32c, but still ~5-10x faster than software implementation.

Reviewed By: Orvid, yfeldblum

Differential Revision: D4994761

fbshipit-source-id: ad8ba856649eea6dc7b541d561329ff7d7fe2d60

6 years agoFix folly::call_once v2017.05.08.00
Andrii Grynenko [Sat, 6 May 2017 18:01:13 +0000 (11:01 -0700)]
Fix folly::call_once

Summary: std::call_once implementation is broken if function throws. This fixes folly::call_once to not depend on std::call_once.

Reviewed By: yfeldblum

Differential Revision: D5015897

fbshipit-source-id: bcbda68becf0930cdbf0b09125cbee61d75c2015

6 years agoMark future-core get-state members as const noexcept
Yedidya Feldblum [Sat, 6 May 2017 04:15:35 +0000 (21:15 -0700)]
Mark future-core get-state members as const noexcept

Summary: [Folly] Mark future-core get-state members as `const noexcept`.

Reviewed By: andrewjcg

Differential Revision: D5014358

fbshipit-source-id: e39b0b63c59267a4ecfab5aac02e6d96ce2e7e00

6 years agoStop trying to setrlimit(RLIMIT_AS) in ASAN builds
Yedidya Feldblum [Sat, 6 May 2017 00:14:26 +0000 (17:14 -0700)]
Stop trying to setrlimit(RLIMIT_AS) in ASAN builds

[Folly] Stop trying to `setrlimit(RLIMIT_AS)` in ASAN builds.

ASAN needs to reserve plenty of memory outside of the limited address space imposed by the call to `setrlimit`.

Reviewed By: andriigrynenko

Differential Revision: D5014679

fbshipit-source-id: 2ab71b1cca9297d3a276cf72154fac30a2057f86

6 years agoFixedString gets comparisons with folly::Range and hence with std::string
Eric Niebler [Fri, 5 May 2017 21:10:47 +0000 (14:10 -0700)]
FixedString gets comparisons with folly::Range and hence with std::string

Summary: It should be possible to perform simple comparison operations between a FixedString and a std::string. By adding asymmetric comparison operators with FixedString and Range, we make FixedString comparable with anything convertible to Range, including std::string.

Reviewed By: yfeldblum

Differential Revision: D5007704

fbshipit-source-id: fee89d8807ac2d5378eec0d0a51eb8684976a271

6 years agoFix getCurrentThreadName() on OSX
Christopher Dykes [Fri, 5 May 2017 19:03:21 +0000 (12:03 -0700)]
Fix getCurrentThreadName() on OSX

Summary: OSX was sad. Now it should be happy.

Reviewed By: mzlee

Differential Revision: D5011751

fbshipit-source-id: 77f22ff461036d8530d8f650396d8e12503448e7

6 years agoControl the number of threads in TestExecutor
Yedidya Feldblum [Fri, 5 May 2017 18:52:53 +0000 (11:52 -0700)]
Control the number of threads in TestExecutor

[Folly] Control the number of threads in `TestExecutor`.

Let the caller control the number of threads to use in each given case.

Reviewed By: spacedentist

Differential Revision: D4999699

fbshipit-source-id: 4acf68cf17fbca14f0779daf0268d54c5606e4a8

6 years agoFuture: improve test with task discarding executors
Sven Over [Fri, 5 May 2017 16:12:51 +0000 (09:12 -0700)]
Future: improve test with task discarding executors

We have tests that check that the Future implementation deals
cleanly with executors discarding tasks. The existing tests destroy
the tasks immediately when they are passed to Executor::add. This
diff adds corresponding tests for the scenario where the task is
not destroyed right away, but after the call to Future::then has

This diff also adds a mechanism to detect that the passed callback
function is actually destroyed. We have tested already that the
promise returned by folly::then will be set to a BrokenPromise
exception when the executor discards the task. However, the task
passed to the executor is not only the callback we pass to
folly::then, as the Future implementation wraps it with some code
that stores the return value in a Promise. Existing tests check
that this Promise is destroyed. The added mechanism in this diff
checks that the orignal callback function itself gets destroyed.

Reviewed By: Krigpl

Differential Revision: D5002100

fbshipit-source-id: 4155f61b075d9fe8d1869ad229f4d350571ff4c6

6 years agoAdd full noexcept annotations to Indestructible
Yedidya Feldblum [Fri, 5 May 2017 06:43:22 +0000 (23:43 -0700)]
Add full noexcept annotations to Indestructible

[Folly] Add full `noexcept` annotations to `Indestructible`.

And do it without requiring `<type_traits>`.

Reviewed By: Orvid

Differential Revision: D4999243

fbshipit-source-id: f3521237ef4d03d2b187e9ebd6d0c90887872c42

6 years agoDelete operator=(std::string&&) from StringPiece
Christopher Dykes [Fri, 5 May 2017 01:32:45 +0000 (18:32 -0700)]
Delete operator=(std::string&&) from StringPiece

Summary: This can only ever be used unsafely, so delete it.

Reviewed By: yfeldblum

Differential Revision: D4951294

fbshipit-source-id: bbc266d1550fceb48946c7c48e76af07292b4a53

6 years agoSupport naming a ScopedEventBaseThread
Christopher Dykes [Thu, 4 May 2017 23:46:53 +0000 (16:46 -0700)]
Support naming a ScopedEventBaseThread

The setThreadName API is in the process of being changed to not accept a thread id, which means the thread itself needs to set the name.
There are times where a `ScopedEventBaseThread` needs to be named, and this makes that possible.

Reviewed By: yfeldblum

Differential Revision: D4916781

fbshipit-source-id: dab05b520a715183ce069151ed16864fa1331abc

6 years agoAdd support for getting the current thread's name
Christopher Dykes [Thu, 4 May 2017 23:31:01 +0000 (16:31 -0700)]
Add support for getting the current thread's name

Summary: It's primarily for use in testing, but is useful for log output as well.

Reviewed By: yfeldblum

Differential Revision: D4943072

fbshipit-source-id: 0ca259d6c90f439e733a6179e7cba85dcd1ec9e7

6 years agoAdd thread-safe priority queue with arbitrary priorities using flat combining
Maged Michael [Thu, 4 May 2017 02:57:21 +0000 (19:57 -0700)]
Add thread-safe priority queue with arbitrary priorities using flat combining

Summary: This template uses flat combining and takes any sequential priority queue implementation that supports the `std::priority_queue` interface (`empty()`, `size()`, `push()`, `top()`, `pop()`) and any lock that meets the standard //Lockable// requirements to implement a thread-safe priority queue that supports arbitrary priorities. The template supports both unbounded and bounded size, and blocking, non-blocking, and timed variants of push, pop, and peek operations.

Reviewed By: djwatson

Differential Revision: D4873602

fbshipit-source-id: 96e1548b4f7427ecd2ee2ead7a19993df4441b33

6 years agotest the typeid of the exception before it is potentially moved
Eric Niebler [Thu, 4 May 2017 02:12:10 +0000 (19:12 -0700)]
test the typeid of the exception before it is potentially moved

Summary: Access the RTTI of the incomming exception before it is potentially moved from when testing for slicing

Reviewed By: yfeldblum

Differential Revision: D4999189

fbshipit-source-id: 3e6c0a9f10a27810484330e9b37a5b0ec450ff88

6 years agoHelper utility to construct, returns an Expected<..>
Aravind Anbudurai [Wed, 3 May 2017 22:33:31 +0000 (15:33 -0700)]
Helper utility to construct, returns an Expected<..>

folly::File's throwing constructor results in many try-catches in the callsites
or bugs where the exception is not caught.

This is a helper method to return an Expected with system_error wrapped into an

Reviewed By: yfeldblum

Differential Revision: D4995702

fbshipit-source-id: be0e22b37c21c35bf157ada598916b05dfd32631

6 years agoStore pointers in EliasFanoReader and BitVectorReader only if quantum > 0
Giuseppe Ottaviano [Wed, 3 May 2017 21:58:44 +0000 (14:58 -0700)]
Store pointers in EliasFanoReader and BitVectorReader only if quantum > 0

No need to store the pointers to forward and skip arrays if
they're not used.

Reviewed By: luciang

Differential Revision: D4977014

fbshipit-source-id: 2ed13fdcd1561da1a294f5895f3a5e1b77f1701c

6 years agoTemplate EliasFanoReader on size type
Giuseppe Ottaviano [Wed, 3 May 2017 21:58:42 +0000 (14:58 -0700)]
Template EliasFanoReader on size type

Summary: Shrink the reader type if less than 64 bits are sufficient for sizes. Do the same for `BitVectorCoding`, where we don't need an extra template parameter because the size is limited by the value domain.

Reviewed By: philippv, luciang

Differential Revision: D4976756

fbshipit-source-id: 685047da81a556d049fb924c612f99cea3056a82

6 years agoDo not store inner_ in EliasFanoReader and BitVectorReader
Giuseppe Ottaviano [Wed, 3 May 2017 21:58:40 +0000 (14:58 -0700)]
Do not store inner_ in EliasFanoReader and BitVectorReader

Summary: It is not used anywhere except for `previousValue`, but there it can be computed from the other fields. This reduces the `EliasFanoReader` size by 8 bytes.

Reviewed By: philippv, yfeldblum

Differential Revision: D4976704

fbshipit-source-id: 62bc63248b66649e483b59cb9ddf48dfd2c0e992

6 years agoDo not store the lower bits mask in EliasFanoReader
Giuseppe Ottaviano [Wed, 3 May 2017 21:58:39 +0000 (14:58 -0700)]
Do not store the lower bits mask in EliasFanoReader

Computing the mask on access has negligible cost as it can be
hoisted out of the linear search loop, and furthermore on Haswell we
can use the the `BZHI` instruction.

I also experimented with `BEXTR` but it ended up being slower because
computing the pattern operand requires a shift and an or (it's
probably meant for when the pattern is precomputed).

Reviewed By: philippv

Differential Revision: D4976657

fbshipit-source-id: e4c4ca5f0a785595587e6d6ad4676f5b216291cf

6 years agoDomain destruction fixes
Dave Watson [Wed, 3 May 2017 17:57:29 +0000 (10:57 -0700)]
Domain destruction fixes

If a retired object's destructor retire()s other hazard pointers, currently
these are not cleaned up correctly when the domain destructs.

Retired pointers must be cleaned up before destroying hazptr_recs, and must be done
iteratively until no more garbage is generated.

Reviewed By: magedm

Differential Revision: D4987333

fbshipit-source-id: bcdd61abb47caca0892a8c4dbb864d17d4f2fa30

6 years agoFix a couple of issues with the CMake script
Christopher Dykes [Wed, 3 May 2017 16:28:45 +0000 (09:28 -0700)]
Fix a couple of issues with the CMake script

The first issue is that I was missing a `G` in `LIBGFLAGS_INCLUDE_DIR` meaning that it always claimed it couldn't find gflags even though it did, and worked just fine anyways.
The second issue is that it was passing `/permissive-` to MSVC 2015 builds, even though MSVC 2015 doesn't support the permissive flag.

Reviewed By: yfeldblum

Differential Revision: D4988813

fbshipit-source-id: f1ea009226baee54032409ce7add3c41f1fe7a19

6 years agoFix compiling with PThread support on Windows... Again...
Christopher Dykes [Wed, 3 May 2017 14:43:46 +0000 (07:43 -0700)]
Fix compiling with PThread support on Windows... Again...

Summary: I was bad and didn't follow through on my previous test plan, and so didn't check that it completely fixed the issue, instead only fixing one of the two problems. This fixes the other one.

Reviewed By: yfeldblum

Differential Revision: D4988408

fbshipit-source-id: 44389bc67bcb7d6db984075f3600948460fa8c5a

6 years agoFix ExceptionWrapper under MSVC 2015 Update 3
Christopher Dykes [Wed, 3 May 2017 14:11:09 +0000 (07:11 -0700)]
Fix ExceptionWrapper under MSVC 2015 Update 3

Summary: Besides this code being utterly bizzare, it doesn't work under MSVC 2015 Update 3, so rather than doing a `static_cast<bool>(std::conjunction<>())` just do `std::conjunction<>::value`.

Reviewed By: yfeldblum

Differential Revision: D4988341

fbshipit-source-id: ededdbf3f3d945d9e2f140f4e87643ec3c0d4239

6 years agoFix FBString in MSVC 2015
Christopher Dykes [Tue, 2 May 2017 21:21:15 +0000 (14:21 -0700)]
Fix FBString in MSVC 2015

Summary: MSVC 2015 Update 3 is even worse in this particular case, and requires it to be explicitly referenced as being within the `folly` namespace >_>...

Reviewed By: ot, yfeldblum

Differential Revision: D4988025

fbshipit-source-id: dea311dd42f40b442951b8df3c5f68cf70d13769

6 years agoFix the CMake build on Windows when using PThreads
Christopher Dykes [Tue, 2 May 2017 17:31:18 +0000 (10:31 -0700)]
Fix the CMake build on Windows when using PThreads

Summary: I broke things, so now I have to fix them.

Reviewed By: yfeldblum

Differential Revision: D4981674

fbshipit-source-id: 7df4d78cf4f984df158051a3a8b277a0bcad583b

6 years agoFix FBString under MSVC
Christopher Dykes [Tue, 2 May 2017 01:41:19 +0000 (18:41 -0700)]
Fix FBString under MSVC

Summary: MSVC requires the declaration to match a bit closer than GCC does.

Reviewed By: yfeldblum, ot

Differential Revision: D4981404

fbshipit-source-id: 92ee40c40f66725c09a3087e49d99ebae222c2f2

6 years agoFix a race in Observable context destruction
Andrii Grynenko [Mon, 1 May 2017 21:51:49 +0000 (14:51 -0700)]
Fix a race in Observable context destruction

Summary: In the subscribe callback It's possible that we lock the Context shared_ptr and while update is running, all other shared_ptr's are released. This will result in Context to be destroyed from the wrong thread (thread runnning subcribe callback), which is not desired.

Reviewed By: yfeldblum

Differential Revision: D4964605

fbshipit-source-id: 285327a6873ccb7393fa3067ba7e612c29dbc454

6 years agoMore OpenSSL 1.1.0 compatibility fixes
Anirudh Ramachandran [Mon, 1 May 2017 21:48:15 +0000 (14:48 -0700)]
More OpenSSL 1.1.0 compatibility fixes

Summary: A bunch of changes to make fbcode targets build with OpenSSL 1.1.0

Reviewed By: ivmaykov

Differential Revision: D4949822

fbshipit-source-id: 35eda632d8335c4194352196264afeff69d87519

6 years agoRemove unused `constexpr strlen` check v2017.05.01.00
Ted Percival [Sun, 30 Apr 2017 08:26:27 +0000 (01:26 -0700)]
Remove unused `constexpr strlen` check

Superseded by `<folly/portability/Constexpr.h>`'s `constexpr_strlen()`.

Reviewed By: yfeldblum

Differential Revision: D4973136

Pulled By: Orvid

fbshipit-source-id: ada9bedf53ce219b0924c3f7aaad75bce9605f0f

6 years agoSimplify BackgroundThreads, move them to folly/experimental/ThreadedRepeatingFunction...
Alexey Spiridonov [Fri, 28 Apr 2017 22:52:16 +0000 (15:52 -0700)]
Simplify BackgroundThreads, move them to folly/experimental/ThreadedRepeatingFunctionRunner

- `FunctionScheduler` and `EventBase` are great for sharing one thread for many functions, but one-function-per-thread is messy.
- Both of those implementations are complicated, but `FunctionThreads` is dead-simple.
- I made it even simpler by eliminating the former `incrementalSleep` in favor of `std::future::wait_for`, which allows instant interruption without a tweakable param. h/t aru777 for suggesting `std::future` instead of `std::condition_variable`.

Reviewed By: yfeldblum

Differential Revision: D4742134

fbshipit-source-id: b520bbcd5f218b2276200ffe8926722ae8a8d6ca

6 years agoFix a comment
Giuseppe Ottaviano [Thu, 27 Apr 2017 21:34:29 +0000 (14:34 -0700)]
Fix a comment

Reviewed By: yfeldblum

Differential Revision: D4965608

fbshipit-source-id: db8d67ca7174e0296fbd8da2e1fe90cbbcef9496

6 years agofolly::rvalue_reference_wrapper for store&forward of rvalue references
Philipp Unterbrunner [Thu, 27 Apr 2017 21:03:31 +0000 (14:03 -0700)]
folly::rvalue_reference_wrapper for store&forward of rvalue references

Class template that wraps a reference to an rvalue. Similar to std::reference_wrapper but with three important differences:
1) folly::rvalue_reference_wrappers can only be moved, not copied;
2) the get() function and the conversion-to-T operator are destructive and not const, they invalidate the wrapper;
3) the constructor-from-T is explicit.
These restrictions are designed to make it harder to accidentally create a a dangling rvalue reference, or to use an rvalue reference multiple times. (Using an rvalue reference typically implies invalidation of the target object, such as move-assignment to another object.)

Reviewed By: yfeldblum

Differential Revision: D4931483

fbshipit-source-id: 68453553bf4656ec41976699669a4491fcab79c9

6 years agofix silent eax clobbering in CpuId ctor
Philip Pronin [Thu, 27 Apr 2017 17:06:51 +0000 (10:06 -0700)]
fix silent eax clobbering in CpuId ctor

`cpuid` uses all of `eax`, `ebx`, `ecx`, `edx` for output, but we
aren't providing such information to GCC in a couple of cases, which might
result in incorrect code being produced;

GCC (unlike clang) doesn't allow the same register to appear both in input and
clobber list, so put `eax` into output list where required.

Reviewed By: ot, lbrandy

Differential Revision: D4961841

fbshipit-source-id: 07ca1977373496bfd794d3b0c8a4ba21333820e4

6 years agoDon't return a nullptr from IOBufQueue::split(0)
Otto Ebeling [Thu, 27 Apr 2017 15:49:50 +0000 (08:49 -0700)]
Don't return a nullptr from IOBufQueue::split(0)

Summary: There's a gotcha case for IOBufQueue::split when  n==0, it will then return an unique_ptr wrapping a nullptr, which many call sites do not expect.

Reviewed By: meyering

Differential Revision: D4868228

fbshipit-source-id: 418256dba8ca3bcfbae420b6099baa240055b9bb

6 years agoFlat combining: Add lock holder with deferred option. Minor fixes.
Maged Michael [Thu, 27 Apr 2017 13:59:10 +0000 (06:59 -0700)]
Flat combining: Add lock holder with deferred option. Minor fixes.

Summary: Added a lock holder with deferred option for cases where the caller may want to call try_lock() later.

Reviewed By: djwatson

Differential Revision: D4949736

fbshipit-source-id: 31e0dc349dc3af9d04a33878e26cef1e48cce674

6 years agoCasing consistency for exception_wrapper::throw_exception
Yedidya Feldblum [Thu, 27 Apr 2017 08:18:43 +0000 (01:18 -0700)]
Casing consistency for exception_wrapper::throw_exception

Summary: [Folly] Casing consistency for `exception_wrapper::throw_exception`.

Reviewed By: Orvid

Differential Revision: D4944818

fbshipit-source-id: 72056fb24ab6362e9a0319f73b5bbf8c92d658ca

6 years agofolly::overload and folly::variant_match
Pavel Aslanov [Wed, 26 Apr 2017 21:15:50 +0000 (14:15 -0700)]
folly::overload and folly::variant_match

Summary: Pattern matching like functionality for boost::vairant. See unittests for usage examples.

Reviewed By: yfeldblum, ericniebler

Differential Revision: D4851133

fbshipit-source-id: cda7dc766dac5870bcc4ab1859de0e4e7f0a6599

6 years agosmall_vector improvements
Nick Terrell [Wed, 26 Apr 2017 17:32:25 +0000 (10:32 -0700)]
small_vector improvements

1. `emplace_back()` is broken when there are at least two arguments and one is a reference to inside the vector. See the `ForwardingEmplaceInsideVector` test.
2. Only `push_back(value_type&&)` did exponential growth, every other function grew linearly. The bug is hidden inside of facebook because `goodMallocSize()` grows fast enough to not be horribly slow. When not using jemalloc, it will grow one element at a time.
3. `push_back(value_type const& t)` performed a copy and a move on `t` when `size() == capacity()`. Remove the extra move.


Reviewed By: luciang

Differential Revision: D4875084

fbshipit-source-id: eefa76028c6bfd9d7c73af65e8bb9d4baf49b8cb

6 years agoMake folly pass TSAN checks
Dave Watson [Wed, 26 Apr 2017 17:04:04 +0000 (10:04 -0700)]
Make folly pass TSAN checks

Currently, contbuild has a blanket TSAN suppression for folly.
Fix PicoSpinLock instead

This should fix TSAN errors as an alternative to D4781776

Some of the tests even had TSAN errors, fixed those.

Reviewed By: davidtgoldblatt

Differential Revision: D4795284

fbshipit-source-id: 9f0fc6868399da2f86be355ce3c081990260a649

6 years agoFix virtual struct bug
Dave Watson [Wed, 26 Apr 2017 16:56:26 +0000 (09:56 -0700)]
Fix virtual struct bug

Summary: virtual classes currently don't work in hazard pointers, and get incorrectly reclaimed.

Reviewed By: magedm

Differential Revision: D4951584

fbshipit-source-id: 8200df6bb8d500af2e89086edf7835d4fb90b6a2

6 years agoDelete the non-char integeral forms of fbstring::operator=
Christopher Dykes [Wed, 26 Apr 2017 00:14:26 +0000 (17:14 -0700)]
Delete the non-char integeral forms of fbstring::operator=

Summary: They allow for assignments that make no sense, so make it impossible to do so.

Reviewed By: yfeldblum

Differential Revision: D4919606

fbshipit-source-id: 24d8e036eff33a8c6def4672c0d098f0edd5c5b3

6 years agoGuard SSLContext lock checks with init mutex and add setSSLLockTypesAndInitOpenSSL
Neel Goyal [Tue, 25 Apr 2017 14:31:39 +0000 (07:31 -0700)]
Guard SSLContext lock checks with init mutex and add setSSLLockTypesAndInitOpenSSL

Improve concurrency guards for `setSSLLockTypes` and `isSSLLockDisabled` by using initMutex.  Also verify that openssl has been initialized w/ DCHECK in isSSLLockDisabled.

We also add a method to do the setting of locks and initialization in one shot.

Reviewed By: knekritz

Differential Revision: D4937242

fbshipit-source-id: 308f516c17485281604d4322954c09beb58688e2

6 years agoRemove thread-safety comment from EventBaseLocal
Andrii Grynenko [Tue, 25 Apr 2017 03:04:03 +0000 (20:04 -0700)]
Remove thread-safety comment from EventBaseLocal

Reviewed By: vitaut

Differential Revision: D4940976

fbshipit-source-id: 0c4ebf8f358e6f54a7b5e81f2e73649b030006c9

6 years agoShift the implementation of setThreadName out of the header
Christopher Dykes [Tue, 25 Apr 2017 01:41:06 +0000 (18:41 -0700)]
Shift the implementation of setThreadName out of the header

`folly::setThreadName` is neither performance critical, nor (after this diff) is it a template, so exposing the mess that is its implementation to the world isn't worth it.
The implementation is expected to get even more messy as I add support for getting the current thread's name, and eventually also add support for Windows as well.

This also required exposing whether the current platform supports setting the name of the current or other threads.

Reviewed By: yfeldblum

Differential Revision: D4942401

fbshipit-source-id: 0e3be203995fa6ed667a5fd28dac7ba7fa49d683

6 years agoProperly gate the wchar tests in FBStringTest
Michael Lee [Mon, 24 Apr 2017 17:47:24 +0000 (10:47 -0700)]
Properly gate the wchar tests in FBStringTest

Summary: Using `#ifndef __ANDROID__` does not necessarily handle all cases of gating the wchar tests

Reviewed By: Orvid

Differential Revision: D4938634

fbshipit-source-id: a2184e20b8c382e5a34947c029f7e3746272b407

6 years agoIgnore setSSLLockTypes() calls after SSLContext is initialized. v2017.04.24.00
Neel Goyal [Sat, 22 Apr 2017 16:18:55 +0000 (09:18 -0700)]
Ignore setSSLLockTypes() calls after SSLContext is initialized.

Summary: We set the actual locks on initialization, so attempting to change locks after had no affect, other than making isSSLLockDisabled() report incorrect information.

Reviewed By: yfeldblum

Differential Revision: D4935475

fbshipit-source-id: 7b80cd530801c925ade769163579b86b1a8f0027

6 years agoAlso exclude the wstring test
Michael Lee [Sat, 22 Apr 2017 00:19:25 +0000 (17:19 -0700)]
Also exclude the wstring test

Summary: ^^^

Reviewed By: yangchi

Differential Revision: D4934455

fbshipit-source-id: babf56f4705ae06f46b694df3f2890d4b9506861

6 years agoTurn off failing FBString test for Android
Michael Lee [Fri, 21 Apr 2017 22:08:18 +0000 (15:08 -0700)]
Turn off failing FBString test for Android

Summary: The traitsLength call in the basic_fbstring constructor is returning a bad value.

Reviewed By: Orvid

Differential Revision: D4930106

fbshipit-source-id: 556a61c4496c2af91cb70db6d62cdc7e915edd55

6 years agoUse std::nullptr_t in dynamic
Christopher Dykes [Fri, 21 Apr 2017 18:25:39 +0000 (11:25 -0700)]
Use std::nullptr_t in dynamic

Summary: It was changed to a `void*` previously due to an ICE in GCC 4.7. GCC 4.7 hasn't been supported in quite a while, and newer versions of GCC don't crash, so it's time to switch it back to `nullptr_t`.

Reviewed By: yfeldblum

Differential Revision: D4917389

fbshipit-source-id: fc48642026c7e3aaeadef27bb949f70648c2312c

6 years agoFix issue where compiler cannot determine address of ::free at compile time
Cameron Pickett [Fri, 21 Apr 2017 01:33:05 +0000 (18:33 -0700)]
Fix issue where compiler cannot determine address of ::free at compile time

Reviewed By: Orvid

Differential Revision: D4921738

fbshipit-source-id: 69848cda3638fca4ead73dcc9949af0f600f33bb

6 years agoEventBaseLocal cleanup
Andrii Grynenko [Thu, 20 Apr 2017 21:54:37 +0000 (14:54 -0700)]
EventBaseLocal cleanup

1. Restrict EventBaseLocal API to only be used from EventBase thread to avoid extra locking.
2. Make sure objects stored in EventBaseLocal are destroyed in EventBase thread.

Reviewed By: yfeldblum

Differential Revision: D4918282

fbshipit-source-id: b7cb4c2b62fef85a9b1d796fa71af8af9087479d

6 years agoRemove unpackHack from smallVector
Nicholas Ormrod [Thu, 20 Apr 2017 17:07:21 +0000 (10:07 -0700)]
Remove unpackHack from smallVector

This change removes the unpackHack function from small_vector, which was blocking ##-Waddress-of-packed-member## from being enabled. The fix is split the pointer-getting non-const ##getCapacity## into a normal getter and setter.

(lithium is flakey, according to continuous, and is push-blocking)

Reviewed By: yfeldblum

Differential Revision: D4918188

fbshipit-source-id: 435e030ad659f5dc9c42d90e9bfee9ca564a120a

6 years agoAdded pkg-config as required dependency
Maxim [Wed, 19 Apr 2017 22:01:49 +0000 (15:01 -0700)]
Added pkg-config as required dependency

Faced this problem on Ubuntu 14.04.4 LTS

configure:16581: error: possibly undefined macro: AC_MSG_NOTICE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
Fixed with `apt-get install pkg-config`

Reviewed By: yfeldblum

Differential Revision: D4886216

Pulled By: Orvid

fbshipit-source-id: 88159b70bfcf62d01bef502b3a5da6c9d81499bc

6 years agoImprove string comparisons
Phil Willoughby [Wed, 19 Apr 2017 12:34:26 +0000 (05:34 -0700)]
Improve string comparisons

Any pair of read-compatible (same type, same traits) basic_strings (`basic_fbstring` or `std::basic_string`) can now be compared to each other with the `==`, `!=`, `<`, `>`, `<=`, and `>=` operators.

If you have a C++14 environment this allows you to use the heterogeneous comparison lookup methods from N3657: you can query containers which store either string type with either string type efficiently.

Reviewed By: yfeldblum, ot

Differential Revision: D4905697

fbshipit-source-id: 2ea976ebf40af45d64c1d8c1c08847feb3b9db68

6 years agoInclude <strings.h> in portability/String.h
Andrew Krieger [Wed, 19 Apr 2017 01:01:23 +0000 (18:01 -0700)]
Include <strings.h> in portability/String.h

portabilty/String.h defines functions for Windows which
are provided by <strings.h> on other platforms, but doesn't include
<strings.h> in that case.

Reviewed By: Orvid

Differential Revision: D4908770

fbshipit-source-id: b3326f78509c2aa1acb9c9279f01537b0a243400

6 years agoFail on implicit convert from BOOL on ObjC in folly::dynamic
Marc Horowitz [Tue, 18 Apr 2017 22:21:35 +0000 (15:21 -0700)]
Fail on implicit convert from BOOL on ObjC in folly::dynamic

Summary: On some platforms (iPhone 5C at least), ObjC/Objc++ BOOL is really signed char.  There is code which expects this to be a boolean when converted to dynamic (and then to JSON and into JS), but the old code treated it as a number.  This makes such code (like [mobileConfig getBool:]) fail to compile, so the developer needs to resolve the ambiguity one way or the other.

Reviewed By: yfeldblum

Differential Revision: D4648133

fbshipit-source-id: 76ece7803a1e966dca08bdb857af7990035544a0

6 years agoFix ASAN reported bug
Angelo Failla [Tue, 18 Apr 2017 07:10:48 +0000 (00:10 -0700)]
Fix ASAN reported bug

Reviewed By: yfeldblum

Differential Revision: D4898404

fbshipit-source-id: 82256ae3dcd76444dc1b192d3bb6d50f142cee81

6 years agofix incorrect usage of FOLLY_DISABLE_UNDEFINED_BEHAVIOR_SANITIZER in folly::Histogram
Tianjiao Yin [Tue, 18 Apr 2017 04:28:57 +0000 (21:28 -0700)]
fix incorrect usage of FOLLY_DISABLE_UNDEFINED_BEHAVIOR_SANITIZER in folly::Histogram

Summary: According to [clang documentation](, the format is incorrect. This results unit-test failure with ubsan.

Reviewed By: yfeldblum

Differential Revision: D4901777

fbshipit-source-id: e9d012366c5e1911632e47fa4fb690820b761fc3

6 years agoFlat combining: Update statistics.
Maged Michael [Tue, 18 Apr 2017 00:59:47 +0000 (17:59 -0700)]
Flat combining: Update statistics.

Modified FC stats. Added number of sessions and removed the number of out-of-memory record allocations.
Removed locking from reading stats to avoid deadlock if the lock is already held. Reading stats now assumes exclusive access.

Reviewed By: djwatson

Differential Revision: D4857132

fbshipit-source-id: 81e4f25040af3691f3e82fe3794ee72c7ff53a99