5 years agoFix SimpleBarrier
David Goldblatt [Fri, 9 Dec 2016 01:20:46 +0000 (17:20 -0800)]
Fix SimpleBarrier

Do the barrier completion test in a loop. (std::condition_variable has pthreads-style spurious wakeups).

(Sorry for missing this in review).

Reviewed By: djwatson

Differential Revision: D4302035

fbshipit-source-id: 3322d6a0ffba8c47c46bafb1d88034e1a0a9c652

5 years agoupdate small locks benchmark
Dave Watson [Thu, 8 Dec 2016 18:28:21 +0000 (10:28 -0800)]
update small locks benchmark

Summary: Add fairness benchmark, contended benchmark

Reviewed By: davidtgoldblatt

Differential Revision: D3706680

fbshipit-source-id: 01814fcd6b0cc3dd12815a2b2c248abc6a3771ec

5 years agoFix sorted_vector_set::erase
Qinfan Wu [Thu, 8 Dec 2016 16:38:14 +0000 (08:38 -0800)]
Fix sorted_vector_set::erase

Summary: It deletes things even when input isn't in the container.

Reviewed By: luciang

Differential Revision: D4298340

fbshipit-source-id: 3e8fc04c2c21eb231dcaf82239ac5f6d25e49e2c

5 years agoFix documentation to use correct condition_variable::wait call
David Lam [Wed, 7 Dec 2016 23:32:30 +0000 (15:32 -0800)]
Fix documentation to use correct condition_variable::wait call

`condition_variable::wait_for` takes as second param `std::chrono::duration`
and not a predicate; what we want is `condition_variable::wait`.

Reviewed By: simpkins

Differential Revision: D4295305

fbshipit-source-id: 05f735fe6e7ecb9d8f42cb38a2985b9ce9dad984

5 years agoFix some implicit truncations in the interaction with OpenSSL APIs
Christopher Dykes [Wed, 7 Dec 2016 22:16:59 +0000 (14:16 -0800)]
Fix some implicit truncations in the interaction with OpenSSL APIs

Summary: MSVC has the ability to warn about implicit truncations and places where implicit sign coercions are occuring, so do some cleanup to make it possible to compile with the warnings enabled.

Reviewed By: yfeldblum

Differential Revision: D4288028

fbshipit-source-id: f8330c62b2dcb76f696dfc47888f0e3e1eefc21a

5 years agoCut some includes from Executor.h
Yedidya Feldblum [Wed, 7 Dec 2016 22:14:47 +0000 (14:14 -0800)]
Cut some includes from Executor.h

Summary: [Folly] Cut some includes from `Executor.h`.

Reviewed By: mzlee

Differential Revision: D4256618

fbshipit-source-id: 1728f48b3c0ec4e0c4c84c44bd8afb583d438129

5 years agoUSE_JEMALLOC in the OSS build if we have jemalloc
Wez Furlong [Wed, 7 Dec 2016 20:53:52 +0000 (12:53 -0800)]
USE_JEMALLOC in the OSS build if we have jemalloc

Nothing defines USE_JEMALLOC in the OSS build today and that causes
some portability problems.

Specifically, the homebrew recipe will make libjemalloc available and our
configure script will detect it and add it to the library flags.

Our subsequent check for `malloc_usable_size` then finds this function in

When later attempting to build wangle against the homebrew folly we get
compilation failures because the prototype for `malloc_usable_size` is only
available in the jemalloc headers and nothing in the saved configuration for
folly is set up for this to be pulled in as it it guarded by `USE_JEMALLOC`.

This attempts to resolve the situation by forcing on `USE_JEMALLOC` when
we detect the library in configure.

This is made a little more complicated because we cannot set `USE_JEMALLOC`
in the OSS build; it gets rewritten to have a `FOLLY_` prefix.  Since we
have code outside of folly that requires that this symbol be `USE_JEMALLOC`,
I've changed the conditional to check for both flavors of the symbol, with
and without the prefix.

Reviewed By: yfeldblum

Differential Revision: D4289176

fbshipit-source-id: 756bc815c3ef1fac454e603feb72155d98c5aadd

5 years agoadd folly::FixedString, a constexpr-usable string with a fixed-size internal buffer
Eric Niebler [Wed, 7 Dec 2016 20:43:21 +0000 (12:43 -0800)]
add folly::FixedString, a constexpr-usable string with a fixed-size internal buffer

Summary: Inspired by, folly::BasicFixedString is a std::string replacement that is usable in constexpr contexts. It uses an internal fixed-size buffer to store up to N characters, where N is a template parameter.

Reviewed By: luciang

Differential Revision: D4249529

fbshipit-source-id: 10f12ea2510a8d21ec60a07a8f15ecc3e35c5431

5 years agoRename stdin, etc. in Subprocess to work with MSVC
Christopher Dykes [Wed, 7 Dec 2016 19:42:17 +0000 (11:42 -0800)]
Rename stdin, etc. in Subprocess to work with MSVC

`stdin`, `stdout` and `stderr` are macros that expand to function calls with the MSVC CRT implementation. This is also the case for musl-libc. This means that Subprocess simply cannot be compiled on those platforms without changing the API.
To solve that, we change the API and deprecate the old API.

For more fun, `stdin`, `stdout` and `stderr` are also macros in glibc, they just expand to other identifiers rather than a function call.

Reviewed By: yfeldblum

Differential Revision: D4229544

fbshipit-source-id: 97f1a3b228b83cfdcaffee56d729063ea235e608

5 years agofix FutureTest/RequestContext
Nathan Bronson [Wed, 7 Dec 2016 19:39:00 +0000 (11:39 -0800)]
fix FutureTest/RequestContext

Summary: Fix use-after-destroy of NewThreadExecutor.  Detected by opt-ubsan tests.

Reviewed By: yfeldblum

Differential Revision: D4291900

fbshipit-source-id: 206f1d7b80fa04e1570e4b7a20e50b9a8ceb7bcb

5 years agoincrease writeLen for tests that want to trigger buffering
Nathan Bronson [Wed, 7 Dec 2016 19:20:21 +0000 (11:20 -0800)]
increase writeLen for tests that want to trigger buffering

Freshly opened TCP sockets can have a send buffer size bigger
than wmem_default, because connection parameters are cached in the
route cache.  Some of the async socket tests assumed that writing 8M of
data was enough to guarantee blocking behavior, but since wmem_max is
20M on our systems the resulting tests are flaky.

Reviewed By: marcinpe

Differential Revision: D4292201

fbshipit-source-id: ba5d606d080330e455eee2b17bcae6cf546bf981

5 years agoAdd EvictingCacheMap MoveConstructor
Dan Schatzberg [Wed, 7 Dec 2016 16:08:34 +0000 (08:08 -0800)]
Add EvictingCacheMap MoveConstructor

Add the default move constructor and move operator
to EvictingCacheMap so it can be moved.

Reviewed By: markisaa, luciang

Differential Revision: D4287472

fbshipit-source-id: 130e9d5467d6da14ba95a9e769cf8e8d541a704c

5 years agoIncrease fiber stack size if UBSAN is enabled
Andrii Grynenko [Tue, 6 Dec 2016 23:11:57 +0000 (15:11 -0800)]
Increase fiber stack size if UBSAN is enabled

Summary: UBSAN instrumentation results in more stack being used. Applying the same logic we already have for ASAN there.

Reviewed By: igorsugak

Differential Revision: D4287455

fbshipit-source-id: 1a224cb5a3654c23b15fa298bf80476234a1418c

5 years agoRemove unecessary iostream include
Michael Lee [Tue, 6 Dec 2016 21:58:20 +0000 (13:58 -0800)]
Remove unecessary iostream include

Summary: MacAddress only needs to include ostream and the test header does not need iostream.

Differential Revision: D4286405

fbshipit-source-id: e64fdd4e8428c62279ed7c185188f3dfc14096d3

5 years agoMore iostream removal.
Michael Lee [Tue, 6 Dec 2016 20:08:49 +0000 (12:08 -0800)]
More iostream removal.

We do not need it and it adds a static initialization

This is the last extra one in liger. The other places actually need iostream to print things

Reviewed By: yfeldblum

Differential Revision: D4286095

fbshipit-source-id: 44a827e48e9fb9106626e784592eb194dff83bf6

5 years agoMake bm_min_iters a 32-bit flag
Christopher Dykes [Tue, 6 Dec 2016 18:51:35 +0000 (10:51 -0800)]
Make bm_min_iters a 32-bit flag

The benchmark API only supports `unsigned int` as the iteration number, so this being 64-bit means it has to be truncated for no reason.
This change gets us closer to being able to enable MSVC's implicit truncation warnings.

Reviewed By: yfeldblum

Differential Revision: D4281264

fbshipit-source-id: 27397e3f23bace20f3cc457665ea6f21bf994da5

5 years agofix gbd debugging script
Misha Shneerson [Tue, 6 Dec 2016 04:33:09 +0000 (20:33 -0800)]
fix gbd debugging script

I was getting an error when running commands in

Reviewed By: andriigrynenko

Differential Revision: D4283229

fbshipit-source-id: fe45847d0ec6cadfbce6fe9818066cce3e275a46

5 years agoconstexpr_strlen works for types other than char. Remove bogus check for nullptr.
Eric Niebler [Mon, 5 Dec 2016 21:06:16 +0000 (13:06 -0800)]
constexpr_strlen works for types other than char. Remove bogus check for nullptr.

Summary: overload constexpr_strlen to work with other character types

Reviewed By: yfeldblum, luciang, Orvid, ot

Differential Revision: D4269654

fbshipit-source-id: 2fcd666669efb51d77e847ff31bda3a301e763da

5 years agoReformulate constexpr_min and constexpr_max to achieve stability in sorting as descri...
Eric Niebler [Mon, 5 Dec 2016 20:51:19 +0000 (12:51 -0800)]
Reformulate constexpr_min and constexpr_max to achieve stability in sorting as described in

Summary: There is a famous long-standing "bug" in the standard library regarding the semantics of min and max wrt values that are equivalent wrt op< but not equal. Let's not make the same mistake with constexpr_min and constexpr_max.

Reviewed By: yfeldblum, luciang, Orvid, ot

Differential Revision: D4269635

fbshipit-source-id: 19b464c949dc0cf07afb08eaf657ae8b242ca42d

5 years agoFix potential double close() on exception v2016.12.05.00
Amir Shalem [Sun, 4 Dec 2016 19:15:34 +0000 (11:15 -0800)]
Fix potential double close() on exception

Fix potential double close() on exception when SO_REUSEPORT fails.
The fd will be closed twice, once by close() and second by the scope guard above.

Reviewed By: yfeldblum

Differential Revision: D4272300

fbshipit-source-id: a163be822d7522cadb9dc3c3eddca10df453de14

5 years agoGet ConcurrentSkipList functional
Christopher Dykes [Sat, 3 Dec 2016 00:45:01 +0000 (16:45 -0800)]
Get ConcurrentSkipList functional

MSVC was getting thoroughly confused while trying to eval the constexpr function, so switch it to a template instead.
MSVC was also failing to wrap it's head around what a NodeRecycler is, so delay its resolution via typename.

Reviewed By: yfeldblum

Differential Revision: D3478755

fbshipit-source-id: f687f4538fb12ef8eee525557f4cc988a09e714d

5 years agoBegin making folly compile cleanly with a few of MSVC's sign mismatch warnings enabled
Christopher Dykes [Fri, 2 Dec 2016 22:23:36 +0000 (14:23 -0800)]
Begin making folly compile cleanly with a few of MSVC's sign mismatch warnings enabled

This makes the changes required to allow folly to compile cleanly with the sign/unsigned mismatch warnings 4388 and 4389, as well as with warnings 4804 and 4805, which are about comparisons between scalars and bool.
Most of the changes in this are to `DCHECK_*` calls which are translated to a templated call which does the comparison internally based on the inferred type of the argument, which for a literal `0` is `int`, causing the warnings to get generated when the comparison is done.

Reviewed By: yfeldblum

Differential Revision: D4253427

fbshipit-source-id: cd17973a78e948a62c886a2959f9abf40a69f9f5

5 years agosupport getting timer from eventbase
Scott Michelson [Fri, 2 Dec 2016 19:48:48 +0000 (11:48 -0800)]
support getting timer from eventbase

Summary: This brings the EventBase functionality of getting a timer for the eventbase into the virtual interface

Differential Revision: D4264135

fbshipit-source-id: e5526610eca808e1d7b549a7cd6cd7b2c65d3ce1

5 years agoadd a new writeFileAtomic() function
Adam Simpkins [Thu, 1 Dec 2016 23:45:22 +0000 (15:45 -0800)]
add a new writeFileAtomic() function

Add a utility function to more safely set a file's contents by writing to a
temporary file first, then renaming the temporary file into place.  On Linux
systems where renames are atomic, this ensures that the operation either
succeeds or that the old file state is left unchanged on failure.

Note that unlike most of the other APIs in FileUtil.h, I intentionally made
writeFileAtomic() throw an exception on failure.  This is implemented using a
lower-level writeFileAtomicNoThrow() version.  Callers who care about the
exception overhead can use the lower level version instead.  (Exception
overhead should be relatively low compared to the file I/O operations, though,
so I suspect most users will prefer the throwing APIs.)

Reviewed By: yfeldblum

Differential Revision: D4253964

fbshipit-source-id: 5301e2791b82c6f90b63bb509b0411841c266705

5 years agoFuture<typename>::getTryVia
Yedidya Feldblum [Thu, 1 Dec 2016 20:43:06 +0000 (12:43 -0800)]

[Folly] `Future<typename>::getTryVia`.

We have `waitVia` and `getVia` and `getTry`, but `getTryVia` was missing.

Reviewed By: fugalh

Differential Revision: D4254972

fbshipit-source-id: 403e1a3496ad5dfc93c4c55ab75a83bcc89e6c64

5 years agoFix assertion in unit test
Subodh Iyengar [Thu, 1 Dec 2016 14:39:24 +0000 (06:39 -0800)]
Fix assertion in unit test

Fix test for AsyncSSLSocket. When a timeout
occurs during a handshake it's possible that
invokeConnectError is called with sslState_ ==
CONNECTING. This just removes the assertion in
this case. This doesnt affect prod code, only

Reviewed By: yfeldblum

Differential Revision: D4252677

fbshipit-source-id: 4db3a94ae28aa140546554c087bedcee7f06d201

5 years agoUse singleton EventBasePool in ServiceRouter
Andrii Grynenko [Thu, 1 Dec 2016 01:59:58 +0000 (17:59 -0800)]
Use singleton EventBasePool in ServiceRouter

Switching ServiceRouter code to use VirtualEventBase instead of EventBase allows us to have same thread-pool shared between multiple ServiceRouter instances.

In future this allows us to replace EventBasePoolImpl with some generic thread-pool implementation (e.g. IOThreadPoolExecutor). It also makes it trivial to have ServiceRouter run on a any existing thread-pool if necessary.

Reviewed By: smichelson

Differential Revision: D3935283

fbshipit-source-id: 3275bbace15a0df8b06d12c970ccc098a631658d

5 years agoUse SingletonThreadLocal in folly::Random
Andrii Grynenko [Thu, 1 Dec 2016 00:50:04 +0000 (16:50 -0800)]
Use SingletonThreadLocal in folly::Random

Summary: folly::SingletonThreadLocal should be used for all thread-local singletons to avoid SDOF.

Reviewed By: yfeldblum

Differential Revision: D4253009

fbshipit-source-id: 5b4ca57a7a77b7b54c94630a2a29d13b84a3af27

5 years agoStart fixing implicit truncations
Christopher Dykes [Wed, 30 Nov 2016 19:17:39 +0000 (11:17 -0800)]
Start fixing implicit truncations

Truncations should be explicit, but for some reason, MSVC seems to be the only compiler that will warn you when you implicitly truncate integer or float values.
This allows Folly to be compiled with warnings 4018, 4242, 4244 and 4305 enabled.
Technically 4018 is a sign mismatch warning, but there was only one place it was being triggered so I included it anyways. The other 3 are warnings for implicit truncation.

There is one other implicit truncation warning that currently triggers in Folly, 4267, but there are a lot more places where that triggers so I'll do that in a separate diff.

Reviewed By: yfeldblum

Differential Revision: D4249471

fbshipit-source-id: e18a93d85856c998576934a6229c9edd1638a54e

5 years agoAdd optional Tracepoint for RequestContext switch
Teng Qin [Wed, 30 Nov 2016 19:07:23 +0000 (11:07 -0800)]
Add optional Tracepoint for RequestContext switch

Summary: Using newly added `StaticTracepoint.h`, add a Tracepoint for `RequestContext` switch that could be enabled by compiler flag.

Reviewed By: drarmstr

Differential Revision: D4238658

fbshipit-source-id: 043a035ba8251b48d7b29d63a2219ad2edda164f

5 years agoAdd constexpr to the simple folly::Range accessors (begin, end, data, empty, etc)
Eric Niebler [Wed, 30 Nov 2016 03:42:04 +0000 (19:42 -0800)]
Add constexpr to the simple folly::Range accessors (begin, end, data, empty, etc)

Summary: More constexpr is better!

Reviewed By: yfeldblum, luciang, ot

Differential Revision: D4244996

fbshipit-source-id: 30a9b726c115a92bb18538d7f18e50eccb0a1ef6

5 years agoFix incorrect bytesWritten computation in AsyncSocket
Tiho Tarnavski [Tue, 29 Nov 2016 23:41:06 +0000 (15:41 -0800)]
Fix incorrect bytesWritten computation in AsyncSocket

Summary: If a write request is buffered after a partial write, then bytes written is not updated after subsequent write operations (`performWrite`) for the buffered write request (`BytesWriteRequest`). This results in a wrong value for totalBytesWritten_, which is reported in the error callback in case the write request fails.

Reviewed By: yfeldblum

Differential Revision: D4205743

fbshipit-source-id: f77ca55ccfdceda1008c45e72ec093b00bf250e4

5 years agoDisallow folly::Singletons before main()
Andrii Grynenko [Tue, 29 Nov 2016 23:34:43 +0000 (15:34 -0800)]
Disallow folly::Singletons before main()

Make folly::Singleton fail if singleton is requested before registrationComplete. By doing this we disallow any folly::Singleton to be created before main().

Strict mode is still disabled for Python and Hs.

Reviewed By: yfeldblum

Differential Revision: D4121322

fbshipit-source-id: b66c23e24f6a7324cd12ddb77cad960e0950a1aa

5 years agoEscape backticks in shell script
Guo Xiao [Tue, 29 Nov 2016 20:30:16 +0000 (12:30 -0800)]
Escape backticks in shell script

Summary: Closes

Reviewed By: pixelb

Differential Revision: D4243347

Pulled By: yfeldblum

fbshipit-source-id: cae0b36abdc7807afc188220f7f421f2a3bbc973

5 years agoSupport old LZ4 versions
Nick Terrell [Tue, 29 Nov 2016 19:37:10 +0000 (11:37 -0800)]
Support old LZ4 versions

Summary: D4194834 broke the OSS build.  Ubuntu 14.4 has r114 in its repo, so support it.

Reviewed By: yfeldblum

Differential Revision: D4224129

fbshipit-source-id: c85e95716ee1a08b33455bfe6fc9f7712d226edf

5 years agoUse std::terminate rather than throwing in a noexcept function
Christopher Dykes [Tue, 29 Nov 2016 05:23:33 +0000 (21:23 -0800)]
Use std::terminate rather than throwing in a noexcept function

Summary: Because MSVC isn't happy about it and generates a warning with a lot of context.

Reviewed By: yfeldblum

Differential Revision: D4242688

fbshipit-source-id: b1e26c9e3b58e7bac0e00ab8959358010fa610e8

5 years agofix bootstrap on osx
r8k [Mon, 28 Nov 2016 19:26:46 +0000 (11:26 -0800)]
fix bootstrap on osx

* include all dependencies
 * update `autoconf` & `configure` with correct params
 * include `make` & `make install` in the bootstrap for a better user experience
 * fixes #332

Reviewed By: yfeldblum

Differential Revision: D4177362

Pulled By: Orvid

fbshipit-source-id: c62d6633c382fca57bb06db08724a7355b71bdb3

5 years agoCanonicalize some aspects of the folly/experimental/hazptr test v2016.11.28.00
Yedidya Feldblum [Mon, 28 Nov 2016 06:02:48 +0000 (22:02 -0800)]
Canonicalize some aspects of the folly/experimental/hazptr test

[Folly] Canonicalize some aspects of the `folly/experimental/hazptr` test.

* Remove the custom `main()` and use the provided weak symbol, either from `folly/test/common/TestMain.cpp` or from `gtest` depending on the build.
* Extract some common setup/teardown (just debug logging in this case) to a test fixture.

Reviewed By: Orvid

Differential Revision: D4234154

fbshipit-source-id: 25613cba0ad6c9147714d98150e013fba1a64d46

5 years agoFix termination output on GCC
Phil Willoughby [Sun, 27 Nov 2016 17:41:10 +0000 (09:41 -0800)]
Fix termination output on GCC

Thanks nbronson for suggesting this fix. I don't see why this should make any
difference (and nor does clang) but the important thing is that it works now.

Reviewed By: nbronson

Differential Revision: D4212670

fbshipit-source-id: 08b4313d736f237039a807fbc458d4d581a2ef35

5 years agoAllow the use of an emulated futex for EventCount
Christopher Dykes [Fri, 25 Nov 2016 23:04:03 +0000 (15:04 -0800)]
Allow the use of an emulated futex for EventCount

Otherwise it won't work under MSVC where we don't have Futexes.
This is achieved by using the Futex API already used elsewhere in Folly.

Reviewed By: yfeldblum

Differential Revision: D4233517

fbshipit-source-id: d6ae6a34b2287cf485f8e4a316445a2ba746d1a7

5 years agoRevert D4214296: [Folly] Include init/Init.cpp
Christopher Dykes [Fri, 25 Nov 2016 19:29:21 +0000 (11:29 -0800)]
Revert D4214296: [Folly] Include init/Init.cpp

Summary: This reverts commit 636ed5ae8ad36a323054efaad96d3756f1b7b9d0

Differential Revision: D4214296

fbshipit-source-id: 41fe55a8fcbf41cce44fee7ba65eda5aadbf97b3

5 years agoFix TFO refused case
Subodh Iyengar [Fri, 25 Nov 2016 05:18:22 +0000 (21:18 -0800)]
Fix TFO refused case

When TFO falls back, it's possible that
the fallback can also error out.

We handle this correctly in AsyncSocket,
however because AsyncSSLSocket is so
inter-twined with AsyncSocket, we missed
the case of error as well.

This changes it so that a connect error on
fallback will cause a handshake error

Differential Revision: D4226477

fbshipit-source-id: c6e845e4a907bfef1e6ad1b4118db47184d047e0

5 years agoSuppress deprecation warnings in related tests
Yedidya Feldblum [Thu, 24 Nov 2016 22:56:49 +0000 (14:56 -0800)]
Suppress deprecation warnings in related tests

[Folly] Suppress deprecation warnings in related tests.

When a test specifically exercises a marked-deprecated library or a marked-deprecated part of a library, we do not need to see the deprecation warnings - they are noise.

Specifically, `Singleton` and `Subprocess` have tested but marked-deprecated APIs, so we suppress deprecation warnings in those specific test suites.

Reviewed By: andrewjcg

Differential Revision: D4230826

fbshipit-source-id: 937b078029cde492906088caa3a9e5eee449bc12

5 years agoDon't expect .native() to return a string
Christopher Dykes [Wed, 23 Nov 2016 23:19:57 +0000 (15:19 -0800)]
Don't expect .native() to return a string

Summary: It's called `.native()` for a reason, and returns a `wstring` on windows, so call `string()` instead.

Reviewed By: yfeldblum

Differential Revision: D4229254

fbshipit-source-id: d5f9658b41f45fd719ca3e878a2e61c9dce24f10

5 years agoAdd USDT header file to folly
Teng Qin [Wed, 23 Nov 2016 22:05:39 +0000 (14:05 -0800)]
Add USDT header file to folly

Derived from `sdt.h` in [[ | SystemTap ]]
Performed changes and clean-ups including:
- Get rid of the `sdt-config.h`.
- Get rid of "Running in Assembler" code.
- Replace the `DTRACE_PROBE_1, ... DTRACE_PROBE_N` Macro family with a single Macro using the "count Macro arguments" trick
- Get rid of argument signed-ness calculation. A **lot** of painful code were there only for this, and it has no real usage except for displaying purposes.
- Re-structure the helper methods (Macros) so that the logic of the code is a bit more readable.
- Add some comments so that it would be easier for users and future developers to understand what this header file is actually doing.
- Update license banner.

Reviewed By: meyering

Differential Revision: D3792966

fbshipit-source-id: 564a1011f7946d30be78191f334e072d94fa264e

5 years agoClose sockets properly in the portability headers
Christopher Dykes [Wed, 23 Nov 2016 19:07:11 +0000 (11:07 -0800)]
Close sockets properly in the portability headers

Even when linked against the dynamic runtime.
In truth, the old way was far cleaner, but we do need to be able to close the file descriptors as there is a hard global limit set by the CRT when it's compiled of 8k file descriptors.
This closes it by applying a flag that prevents calls to `CloseHandle` from actually closing the handle, then we call `_close` to get the file descriptor itself closed, then we can call `_closesocket` to close the socket and handle.
This is complicated by the fact that attempting to close a handle that you've marked as being prevented from being closed will trigger an SEH exception, but only if you have a debugger attached. That means that, for anything closing sockets to be debuggable, we have to handle that exception (as a no-op) and then get to have fun trying to get `STATUS_HANDLE_NOT_CLOSABLE`, which for some absurd reason, is only defined as part of the driver developer kit's headers. Some fun ensued where VS was nice enough to point out that the bcrypt headers also defines `NTSTATUS`, and doesn't require building as a driver to use it. For that reason we borrow its definition of `NTSTATUS` rather than declaring it ourselves.
We also have to prevent the main windows headers from defining the base SEH exceptions, because those will be redefined by `ntstatus.h` otherwise :(

Reviewed By: yfeldblum

Differential Revision: D4222625

fbshipit-source-id: 6ed7e91b7a735b5506eb189e452983cd8cace34b

5 years agoSuppress some aborts in debug mode when using already closed file descriptors
Christopher Dykes [Wed, 23 Nov 2016 18:43:24 +0000 (10:43 -0800)]
Suppress some aborts in debug mode when using already closed file descriptors

Summary: The helper exists because MSVC is a pain in this regard, so use it.

Reviewed By: yfeldblum

Differential Revision: D4224037

fbshipit-source-id: 6c6415877785f13ea91618a3042f2470dccd08c1

5 years agoFix fibers gdb utils script
Stepan Palamarchuk [Tue, 22 Nov 2016 22:39:34 +0000 (14:39 -0800)]
Fix fibers gdb utils script

There was a recent change in boost compatibility that changed fibers internals and thus broke this script.
This diff fixes gdb script to properly print stack trace for fibers.

Reviewed By: yfeldblum

Differential Revision: D4214575

fbshipit-source-id: 4bf69e9b297c7539a2b2b71093998c30d6a2d81c

5 years agoTweak zstd autoconf check so the build works with older zstd
Lovro Puzar [Tue, 22 Nov 2016 18:45:34 +0000 (10:45 -0800)]
Tweak zstd autoconf check so the build works with older zstd

Summary: Ubuntu 16.10 has a package for zstd 0.5.1 which is too old to be used by folly.  With this change autoconf will check that one of the newer functions is present, disable zstd if not.

Reviewed By: Orvid, philippv

Differential Revision: D4219964

fbshipit-source-id: 1e64dfb62f81f7e61b097cb7d4fd3810da476625

5 years agoCorrectly bind to the wildcard address in AsyncServerSocket::bind
Christopher Dykes [Tue, 22 Nov 2016 17:48:18 +0000 (09:48 -0800)]
Correctly bind to the wildcard address in AsyncServerSocket::bind

Summary: Because Windows disagrees with everything else about how to specify that you want the wildcard address. It's done with an empty string on Windows, but `nullptr` everywhere else.

Reviewed By: yfeldblum

Differential Revision: D4216970

fbshipit-source-id: b5dc136946d9677a96be3252e44d383a6abca800

5 years agoWork around an MSVC expression SFINAE bug in DynamicParser
Christopher Dykes [Mon, 21 Nov 2016 23:40:54 +0000 (15:40 -0800)]
Work around an MSVC expression SFINAE bug in DynamicParser

Summary: The good news is that it's cleaner than it was to start with.

Reviewed By: yfeldblum

Differential Revision: D4215323

fbshipit-source-id: 6758092f1e76f60b360753026bb7716737a51304

5 years agoDisable the DoubleRegistrationLogging singleton test under MSVC
Christopher Dykes [Mon, 21 Nov 2016 23:39:27 +0000 (15:39 -0800)]
Disable the DoubleRegistrationLogging singleton test under MSVC

Summary: It's the only test in the file that is dependent on Subprocess, which is currently unsupported under MSVC.

Reviewed By: yfeldblum

Differential Revision: D4214812

fbshipit-source-id: 9dcd9763b51d037e0c452f79f134df286a11e718

5 years agoInclude init/Init.cpp
Zach Amsden [Mon, 21 Nov 2016 22:42:11 +0000 (14:42 -0800)]
Include init/Init.cpp

Summary: Anything calling folly::init() will not link with open source build

Reviewed By: yfeldblum

Differential Revision: D4214296

fbshipit-source-id: 636ed5ae8ad36a323054efaad96d3756f1b7b9d0

5 years agoWorkaround a bug resolving decltype'd locals in lambdas v2016.11.21.00
Christopher Dykes [Sat, 19 Nov 2016 05:34:19 +0000 (21:34 -0800)]
Workaround a bug resolving decltype'd locals in lambdas

Then it's time to get food.
The bug report linked in the comment has more details.

Reviewed By: yfeldblum

Differential Revision: D4209389

fbshipit-source-id: 87e72691555992bdf964b0ded1173daadcedffa4

5 years agoDon't explicitly alias dynamic after using the entire folly namespace
Christopher Dykes [Sat, 19 Nov 2016 04:56:29 +0000 (20:56 -0800)]
Don't explicitly alias dynamic after using the entire folly namespace

Summary: Because, to the best of my knowledge, MSVC is quite right to claim it doesn't know which `dynamic` everyone keeps referring to. Is it `folly::dynamic` or `::dynamic`?

Reviewed By: yfeldblum

Differential Revision: D4209535

fbshipit-source-id: 63322a8f960954e1a63fe5c9a4a5d9395c7827d9

5 years agoUse the GTest portability header in shell_test
Christopher Dykes [Sat, 19 Nov 2016 02:35:02 +0000 (18:35 -0800)]
Use the GTest portability header in shell_test

Summary: It was including gtest directly, making MSVC unhappy.

Reviewed By: yfeldblum

Differential Revision: D4208744

fbshipit-source-id: 7100058f3c9fde38744888c99e927c610f11d013

5 years agoDon't attempt to separately close the underlying file descriptor in the format other...
Christopher Dykes [Sat, 19 Nov 2016 01:54:36 +0000 (17:54 -0800)]
Don't attempt to separately close the underlying file descriptor in the format other test

Summary: Windows automatically closes the underlying file descriptor when you call fclose, however fclose is not a function that can be easily overriden in the portability layer, so choose to just not call `close` on Windows instead.

Reviewed By: yfeldblum

Differential Revision: D4190524

fbshipit-source-id: a68edccd04e63f89c178ade584fa7192845773f8

5 years agoUse structs rather than type aliases for Unit::Lift and Unit::Drop
Christopher Dykes [Sat, 19 Nov 2016 01:53:37 +0000 (17:53 -0800)]
Use structs rather than type aliases for Unit::Lift and Unit::Drop

VS 2017 RC brings with it fixes for some things and unfortunately, a few known regressions in expression SFINAE. In this case, alias templates with dependent `decltype()` calls are broken, so switch to a templated struct instead.
It's the very last issue mentioned in:

Reviewed By: yfeldblum

Differential Revision: D4199676

fbshipit-source-id: 9ce157cc891182509a30b000de1b509063387244

5 years agoSynchronized: disable operator= when the type isn't copy assignable
Maxime Boucher [Sat, 19 Nov 2016 00:53:50 +0000 (16:53 -0800)]
Synchronized: disable operator= when the type isn't copy assignable

Summary: The value of std::is_copy_assignable<folly::Synchronized<T>>::value is incorrect when T isn't copy assignable. As a result, it isn't possible to use SFINAE to properly select a function when the base type is a folly::Synchronized. This diff selectively deletes the copy constructor and copy assignment operator when the underlying type T isn't copyable. This is most useful in the case of folly::Synchronized<std::unique_ptr<...>>

Reviewed By: yfeldblum

Differential Revision: D4203081

fbshipit-source-id: 1e811f9e52db26c23b1c6f1907bac9e2854ddb9d

5 years agoDisable a range test under MSVC
Christopher Dykes [Fri, 18 Nov 2016 23:07:58 +0000 (15:07 -0800)]
Disable a range test under MSVC

Summary: Because, as the comment says, MSVC fails miserably at this, producing errors at compile time.

Reviewed By: yfeldblum

Differential Revision: D4207544

fbshipit-source-id: d9a11b72877d22d3d3fe2e2c862d99601ab21431

5 years agoExpose folly::symbolizer::dumpStackTrace().
Martin Martin [Fri, 18 Nov 2016 17:59:37 +0000 (09:59 -0800)]
Expose folly::symbolizer::dumpStackTrace().

Expose folly::symbolizer::dumpStackTrace() for use with
custom signal handlers.

Reviewed By: luciang

Differential Revision: D4174004

fbshipit-source-id: 510b77edef652f3e9d10f0acfb4998b64a15fad5

5 years agoExplain crash when exception is thrown from Scope Guard
Phil Willoughby [Fri, 18 Nov 2016 16:08:19 +0000 (08:08 -0800)]
Explain crash when exception is thrown from Scope Guard

Print a message to `std::cerr` when the current program is about to call `std::terminate` because a `folly::ScopeGuard` callback threw an exception. This goes to `std::terminate` in the (common) cases when the `ScopeGuard` destructor is `noexcept`

This gives the user a small clue as to what just happened, since the default diagnostics for this on some platforms do not help at all.

Reviewed By: nbronson

Differential Revision: D4061096

fbshipit-source-id: c3b534d4a36b095e08e46f375251b6fd416ccd68

5 years agoforce read for doNotOptimizeAway(*ptr_to_small_trivial)
Nathan Bronson [Fri, 18 Nov 2016 16:07:09 +0000 (08:07 -0800)]
force read for doNotOptimizeAway(*ptr_to_small_trivial)

doNotOptimizeAway's "X" input operand constraint is interpreted
more loosely by gcc than by clang, resulting in surprising behavior
for doNotOptimizeAway(*ptr) and a difference in behavior between gcc
and clang benchmarks.  clang also is more aggressive about placing an
input operand into a register even when the constraint would allow it to
be in memory, so an "r,m" constraint has a similar problem.  This diff
changes the input constraint so that register-sized values must actually
be copied into a register, which makes the behavior more intuitive and
more consistent across platforms.

Reviewed By: davidtgoldblatt

Differential Revision: D4199767

fbshipit-source-id: aa56a7b11cb3229b95da87295f0dfc38476959d2

5 years agoFix Build: folly with -Wmissing-braces
Yedidya Feldblum [Fri, 18 Nov 2016 07:01:42 +0000 (23:01 -0800)]
Fix Build: folly with -Wmissing-braces

[Folly] Fix Build: `folly` with `-Wmissing-braces`.

Construction of `std::array` with list-initialization for the contained C array requires double braces, per the standard.

Compilers accept it with single braces, but will reject it when `-Wmissing-braces` is passed.

Reviewed By: igorsugak, meyering

Differential Revision: D4202629

fbshipit-source-id: e5b87a655e7f25e6cddb931dda28b172c768f227

5 years agofolly/portability: move some macro definitions to `CPortability.h`
Andrew Gallagher [Fri, 18 Nov 2016 05:16:07 +0000 (21:16 -0800)]
folly/portability: move some macro definitions to `CPortability.h`

Summary: These macros apply to both C and C++.

Reviewed By: yfeldblum

Differential Revision: D4199905

fbshipit-source-id: 8dc22959d0a6349c6c76415d1a38eda52cab83a5

5 years agoFaster unhexlify
Tom Jackson [Fri, 18 Nov 2016 02:14:14 +0000 (18:14 -0800)]
Faster unhexlify

Using already-available lookup table instead of a bunch of branching, this improves read throughput from ~750MB/s to 2.1GB/s in benchmarks.

before:        (time)   (rate)
BM_unhexlify   1.39ns  719.26M
BM_unhexlify 470.59ps    2.13G

Reviewed By: philippv

Differential Revision: D4201352

fbshipit-source-id: 8393e066c45c402ccb8b537fdb25417e8e6a9511

5 years agoDon't rely on implicit lookup of member names in dependent base classes
Christopher Dykes [Fri, 18 Nov 2016 00:30:31 +0000 (16:30 -0800)]
Don't rely on implicit lookup of member names in dependent base classes

The standard says this shouldn't be done, but GCC, Clang, and MSVC all do, at least, MSVC does if you don't pass the `/permissive-` switch to disable this non-compliant lookup.
This just qualifies it with `this->` which solves the problem.

MSVC plans to eventually (some time after the 2017 release) enable `/permissive-` by default, so let's start compiling with it now.

Reviewed By: yfeldblum

Differential Revision: D4200725

fbshipit-source-id: 8545c6bcda9ba6006733c15f668805cb1260517a

5 years agoInclude atomic in SingletonTestStructs.cpp
Christopher Dykes [Fri, 18 Nov 2016 00:30:12 +0000 (16:30 -0800)]
Include atomic in SingletonTestStructs.cpp

Summary: This was relying on it being transitively included by system headers, which isn't the case under MSVC.

Reviewed By: yfeldblum

Differential Revision: D4199882

fbshipit-source-id: c25dc1e86687e19851923a1a660a91bcf63f0e6d

5 years agoMark a couple more local constexpr values as static
Christopher Dykes [Fri, 18 Nov 2016 00:29:09 +0000 (16:29 -0800)]
Mark a couple more local constexpr values as static

Summary: Because MSVC doesn't let you access it without capturing it from within a lambda otherwise.

Reviewed By: yfeldblum

Differential Revision: D4199867

fbshipit-source-id: 7b829b2cc373edbebe3498901fa323c89a211818

5 years agoUpdate
Srinivas \"Teja\" Rao [Thu, 17 Nov 2016 22:55:03 +0000 (14:55 -0800)]

it seems second is the boolean that we need to compare.

Differential Revision: D4197096

Pulled By: yfeldblum

fbshipit-source-id: 71987dafac0ddbdb7817b55732619edbe9aed81b

5 years agoReplace deprecated LZ4 functions
Nick Terrell [Thu, 17 Nov 2016 21:18:48 +0000 (13:18 -0800)]
Replace deprecated LZ4 functions

Replace deprecated functions with their functionally equivalent counterparts.

See and

Reviewed By: Cyan4973

Differential Revision: D4194834

fbshipit-source-id: aa4f934c46fe764fcec8ea29221e3882da2b5cdf

5 years agoVirtualEventBase
Andrii Grynenko [Thu, 17 Nov 2016 20:44:52 +0000 (12:44 -0800)]

This implements a view onto an EventBase, which can keep track of all tasks created through it and join them on destruction. Multiple VirtualEventBases can be backed by the same EventBase. This can be useful to have the same IO thread/thread-pool be shared between multiple libraries, allowing them to each have it's own VirtualEventBase and control its lifetime.

Since VirtualEventBase also supports LoopKeepAlive and onDestruction functionality, it can be easily integrated with FiberManagerMap.

Reviewed By: yfeldblum

Differential Revision: D4158719

fbshipit-source-id: 7df964f36e5276e2b5665fd8394ea2e187aa298c

5 years agofolly: ExceptionWrapper: remove <iostream> from header
Lucian Grijincu [Thu, 17 Nov 2016 19:06:36 +0000 (11:06 -0800)]
folly: ExceptionWrapper: remove <iostream> from header

Summary: #accept2ship

Reviewed By: yfeldblum

Differential Revision: D4192095

fbshipit-source-id: eb0cad875bcc24d1c87a99890c51aea31f7024c9

5 years agoAdd folly::getCurrentThreadID()
Christopher Dykes [Thu, 17 Nov 2016 03:20:16 +0000 (19:20 -0800)]
Add folly::getCurrentThreadID()

Summary: And also use it in a couple of tests, so that they can be compiled on Windows, where `pthread_t` is a struct rather than a pointer or integer.

Reviewed By: yfeldblum

Differential Revision: D4191560

fbshipit-source-id: 5bcf0a2952109b2a9bc5220c4640d42e2cdf8977

5 years agoRemove unneeded iostream include
Delyan Kratunov [Thu, 17 Nov 2016 00:48:47 +0000 (16:48 -0800)]
Remove unneeded iostream include

Including `iostream` in a header causes anything that uses this header to gain
an extra static initializer for an `std::ios_base::Init` object.
If there are N translation units in a library that use the header, that's N
more static initializers that need to run.

Reviewed By: yfeldblum

Differential Revision: D4191798

fbshipit-source-id: 65b47401b9177177999cff65a47ac8dffa0e0546

5 years agoAdjust the Function::NonCopyableLambda test to use a large struct rather than a C...
Christopher Dykes [Thu, 17 Nov 2016 00:41:51 +0000 (16:41 -0800)]
Adjust the Function::NonCopyableLambda test to use a large struct rather than a C Array

Because MSVC doesn't like it when you attempt to explicitly capture a c-style array in a lambda capture list.

Reviewed By: yfeldblum

Differential Revision: D4191400

fbshipit-source-id: 305f8086c29f079ccf2c322f20da6393235bc76d

5 years agoBroken link to gtest 1.7.0 zip replaced with correct one
Geert Van Laethem [Wed, 16 Nov 2016 22:50:58 +0000 (14:50 -0800)]
Broken link to gtest 1.7.0 zip replaced with correct one

Summary: Closes

Reviewed By: igorsugak

Differential Revision: D4191764

Pulled By: Orvid

fbshipit-source-id: 5ab921bd0df0b9dbaca46cdf9ecdeea9ecda6f5a

5 years agoDisable the CArray RangeFunc tests under MSVC
Christopher Dykes [Wed, 16 Nov 2016 22:50:29 +0000 (14:50 -0800)]
Disable the CArray RangeFunc tests under MSVC

Summary: Because it won't compile due to an MSVC bug. See the link in the comment for more info.

Reviewed By: yfeldblum

Differential Revision: D4191233

fbshipit-source-id: 523deebe12379ff56934a4259b601d4ab677b9b6

5 years agofolly: fbvector: ubsan: avoid memset(nullptr, 0, 0)
Nathan Bronson [Wed, 16 Nov 2016 22:01:49 +0000 (14:01 -0800)]
folly: fbvector: ubsan: avoid memset(nullptr, 0, 0)

Constructing an empty FBVector by length results in a call to
memset with a null destination, which is undefined behavior.  This diff
fixes it.

Reviewed By: luciang, meyering, Gownta

Differential Revision: D4191612

fbshipit-source-id: 3dcc091396fc33ac2230bd2d90906325131b0a3b

5 years agoMark a few constexpr locals in ThreadLocalTest as static
Christopher Dykes [Wed, 16 Nov 2016 21:20:32 +0000 (13:20 -0800)]
Mark a few constexpr locals in ThreadLocalTest as static

Because, as discussed in past diffs, MSVC currently requires them to be static in order to resolve them from within the scope of a lambda when they aren't captured.
The only one that actually needs to be marked as `static` is `numReps`, but I like consistency, so I marked them all as static.

Reviewed By: yfeldblum

Differential Revision: D4191610

fbshipit-source-id: 7246170f30551d2079b4373eefbf3d02aab6dfa9

5 years agoHint that the port is numeric when binding an AsyncServerSocket
Christopher Dykes [Wed, 16 Nov 2016 21:19:59 +0000 (13:19 -0800)]
Hint that the port is numeric when binding an AsyncServerSocket

Summary: Because it had better be numeric or something is very wrong.

Reviewed By: yfeldblum

Differential Revision: D4190568

fbshipit-source-id: 52a5ebfcedb545201191fc48f66a4419eee8f748

5 years agofolly: MemoryMapping: less verbose warning on TRY_LOCK+ENOMEM failures
Lucian Grijincu [Wed, 16 Nov 2016 04:24:38 +0000 (20:24 -0800)]
folly: MemoryMapping: less verbose warning on TRY_LOCK+ENOMEM failures

Reviewed By: philippv

Differential Revision: D4184097

fbshipit-source-id: 2f1f82b845528fea4667af612c92c348f8d9ec25

5 years agoQualify a field name in NotificationQueueTest
Christopher Dykes [Wed, 16 Nov 2016 02:46:23 +0000 (18:46 -0800)]
Qualify a field name in NotificationQueueTest

Summary: MSVC currently has a bug that causes it to incorrectly resolve it to `std::queue`:

Reviewed By: lbrandy

Differential Revision: D4187256

fbshipit-source-id: 207eafa339f7255ae881d8ab80f4847222c3b8c9

5 years agoDon't assume standard library types are relocatable
Christopher Dykes [Wed, 16 Nov 2016 01:30:09 +0000 (17:30 -0800)]
Don't assume standard library types are relocatable

Summary: Although currently the only one of these that isn't relocatable is `std::string`, making assumptions about the standard library is a terrible idea, so disable all of them.

Reviewed By: yfeldblum

Differential Revision: D4186024

fbshipit-source-id: 4d2a54d232df0cb05959a8d9cb1a2d2cf34d1302

5 years agoThread-safe version of loopKeepAlive()
Andrii Grynenko [Tue, 15 Nov 2016 22:52:48 +0000 (14:52 -0800)]
Thread-safe version of loopKeepAlive()

Reviewed By: yfeldblum

Differential Revision: D4152380

fbshipit-source-id: 8b3c6dc4b14b9138bb5012e05f50496e51c0fa4b

5 years agoMark FingerprintPolynomial.size() constexpr
Christopher Dykes [Tue, 15 Nov 2016 19:38:18 +0000 (11:38 -0800)]
Mark FingerprintPolynomial.size() constexpr

Summary: Because it is, and so that MSVC doesn't complain about things in the fingerprint table generator.

Reviewed By: yfeldblum

Differential Revision: D4178562

fbshipit-source-id: 8816f413bc100b42dd72f0e991aec8559b328e9b

5 years agofolly: MemoryMapping: isolate _MSC_VER-related changes
Lucian Grijincu [Tue, 15 Nov 2016 04:39:13 +0000 (20:39 -0800)]
folly: MemoryMapping: isolate _MSC_VER-related changes

Summary: Cleaner to isolate the #ifdefs to a constant than different code based on platform.

Reviewed By: yfeldblum, Orvid

Differential Revision: D4179949

fbshipit-source-id: 5b9975a78cf234f29a379c1dbe489373b7f1c253

5 years agoMove runAfterDelay/tryRunAfterDelay into TimeoutManager
Andrii Grynenko [Tue, 15 Nov 2016 02:13:02 +0000 (18:13 -0800)]
Move runAfterDelay/tryRunAfterDelay into TimeoutManager

Summary: This is useful to add more TimeoutManager implementations.

Reviewed By: yfeldblum

Differential Revision: D4178511

fbshipit-source-id: 9167cfe40e7487da1c35c537f9db8a2bdf085626

5 years agoMake Observer stress test pass a stress run
Andrii Grynenko [Tue, 15 Nov 2016 02:07:46 +0000 (18:07 -0800)]
Make Observer stress test pass a stress run

Reviewed By: yfeldblum

Differential Revision: D4179908

fbshipit-source-id: 493b302cd7e9f7ebc851599b2ca5988af817387d

5 years agocorrect the description about the thread to run
yizhiren [Tue, 15 Nov 2016 00:19:37 +0000 (16:19 -0800)]
correct the description about the thread to run

exchange A and B in this sentence :
"Or, maybe x will execute in Thread B, but y and/or z will execute in Thread A".

I think x in B and y,z in A is impossible. but x in A and y,z in B is possible, in that example.

Reviewed By: yfeldblum

Differential Revision: D4176766

Pulled By: Orvid

fbshipit-source-id: cf3a47a30d7e43e5291d6b6401198025beba33f8

5 years agoRevert D4164236: [EventBase] Move runAfterDelay/tryRunAfterDelay into TimeoutManager v2016.11.14.00
Alejandro Peláez [Mon, 14 Nov 2016 00:19:32 +0000 (16:19 -0800)]
Revert D4164236: [EventBase] Move runAfterDelay/tryRunAfterDelay into TimeoutManager

Summary: This reverts commit 5f2057f6ebfbdc971bc0b5594e3bc4b5a337aaef

Differential Revision: D4164236

fbshipit-source-id: a397e6ba8c9d7a691cc6381b8f60bfcea3eb91b0

5 years agoAdd ecdsa smart ptr
Subodh Iyengar [Sun, 13 Nov 2016 01:13:44 +0000 (17:13 -0800)]
Add ecdsa smart ptr

Summary: Add ecdsa smart ptr.

Reviewed By: knekritz

Differential Revision: D4173310

fbshipit-source-id: abd5f799b3414b70128635c4390af6f2de329e11

5 years agoMove runAfterDelay/tryRunAfterDelay into TimeoutManager
Andrii Grynenko [Sat, 12 Nov 2016 03:49:34 +0000 (19:49 -0800)]
Move runAfterDelay/tryRunAfterDelay into TimeoutManager

Summary: This is useful to add more TimeoutManager implementations.

Reviewed By: yfeldblum

Differential Revision: D4164236

fbshipit-source-id: 5f2057f6ebfbdc971bc0b5594e3bc4b5a337aaef

5 years agotry to improve folly/io/async/test:async_test - AsyncSocketTest.Write
Marcin Pawlowski [Sat, 12 Nov 2016 02:37:38 +0000 (18:37 -0800)]
try to improve folly/io/async/test:async_test - AsyncSocketTest.Write

the test fails a lot as seen on the task.
To kill the connection in said test, we depeneded
on destructor, however this uses a delayed destruction
patter so I guess we did not destroy on time and
we were failing the tests.
I close socket explicitly. No idea if this misses
the point of whole test.

Reviewed By: yfeldblum

Differential Revision: D4171111

fbshipit-source-id: 01b8c97a04a2bcdfaeeea522ca8bcae343d6bb5d

5 years agoRevert DLOG_INFO warnings about RequestContext being overriden
Mirek Klimos [Sat, 12 Nov 2016 02:17:17 +0000 (18:17 -0800)]
Revert DLOG_INFO warnings about RequestContext being overriden

Summary: This is causing a log spew on some services, let's remove it until we figure out where the problem is and fix

Differential Revision: D4171379

fbshipit-source-id: 2afdab6917a2498c376559f9171f6e93ab9c8ad7

5 years agoMake Observer.Stress test not fail under load
Andrii Grynenko [Sat, 12 Nov 2016 02:12:11 +0000 (18:12 -0800)]
Make Observer.Stress test not fail under load

Reviewed By: marcinpe

Differential Revision: D4171655

fbshipit-source-id: e6ef33c50d5d91e05250520171c959a893470460

5 years agoWhen you read from a default-constructed MPMCQueue, assert instead of SIGFPE.
Martin Martin [Sat, 12 Nov 2016 00:08:46 +0000 (16:08 -0800)]
When you read from a default-constructed MPMCQueue, assert instead of SIGFPE.

I accidentally forgot to specify the capacity for my
MPMCQueue.  When I then did a blockingRead(), I got a SIGFPE.  Thanks
to a custom signal handler that doesn't print stack traces, and a few
more comedy of errors, I lost a day to this.  With this patch, I would
have gotten an assertion failure instead.

Reviewed By: yfeldblum

Differential Revision: D4169033

fbshipit-source-id: fab97ea0d5afc3c06885758b31a5e8c91ae75a45

5 years agoAdd warnings when overriding RequestContext
Mirek Klimos [Fri, 11 Nov 2016 19:15:55 +0000 (11:15 -0800)]
Add warnings when overriding RequestContext

Summary: We currently store the previous value on creation of RequestContextScopeGuard and reset it to the previous one when it goes out of scope - this means that if it's not unset properly somewhere, we'll prolong its life by saving it and restoring later. We need to do this because of some edge cases but a RequestContext should generally never be overridden by a different RequestContext - let's add a warning if this happens

Reviewed By: djwatson, palmtenor

Differential Revision: D3971904

fbshipit-source-id: e72b5f01102d18977d8aa5f8dca5a7802545098a

5 years agofolly/test/SingletonTestStructs: move inlined function to impl file
Andrew Gallagher [Fri, 11 Nov 2016 06:44:43 +0000 (22:44 -0800)]
folly/test/SingletonTestStructs: move inlined function to impl file

Reviewed By: yfeldblum

Differential Revision: D4162763

fbshipit-source-id: 25c9bfae2e7679f4b98a3d64ee9f2319eb6e7f4a

5 years agoLet folly::range(const std::array<...>&) be constexpr
Yedidya Feldblum [Fri, 11 Nov 2016 06:02:17 +0000 (22:02 -0800)]
Let folly::range(const std::array<...>&) be constexpr

[Folly] Let `folly::range(const std::array<...>&)` be `constexpr`.

This may be useful for future work.

Reviewed By: simpkins

Differential Revision: D4165608

fbshipit-source-id: 8f1064c3cdc07301e198acd596ff26724d603cdd