From: Christopher Dykes Date: Sat, 19 Nov 2016 04:56:29 +0000 (-0800) Subject: Don't explicitly alias dynamic after using the entire folly namespace X-Git-Tag: v2016.11.21.00~1 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=commitdiff_plain;h=da873b7bd9cc2b01861e8e2b3f35b1da30be6945 Don't explicitly alias dynamic after using the entire folly namespace Summary: Because, to the best of my knowledge, MSVC is quite right to claim it doesn't know which `dynamic` everyone keeps referring to. Is it `folly::dynamic` or `::dynamic`? Reviewed By: yfeldblum Differential Revision: D4209535 fbshipit-source-id: 63322a8f960954e1a63fe5c9a4a5d9395c7827d9 --- diff --git a/folly/experimental/test/DynamicParserTest.cpp b/folly/experimental/test/DynamicParserTest.cpp index 3c18f47b..72dbd5a7 100644 --- a/folly/experimental/test/DynamicParserTest.cpp +++ b/folly/experimental/test/DynamicParserTest.cpp @@ -28,7 +28,6 @@ #include using namespace folly; -using dynamic = folly::dynamic; // NB Auto-conversions are exercised by all the tests, there's not a great // reason to test all of them explicitly, since any uncaught bugs will fail