From: Adam Simpkins Date: Fri, 19 Jan 2018 04:42:48 +0000 (-0800) Subject: demangle: remove an old TODO comment X-Git-Tag: v2018.01.22.00~13 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=commitdiff_plain;h=b0ab09d8df51de1c7040b78742617ef6466b002a demangle: remove an old TODO comment Summary: Both the autoconf and cmake build scripts check for `cplus_demangle_v3_callback()` and define `FOLLY_HAVE_CPLUS_DEMANGLE_V3_CALLBACK` appropriately. Reviewed By: meyering Differential Revision: D6745365 fbshipit-source-id: 3020593c60a21568781b835490b8d64913366cb9 --- diff --git a/folly/Demangle.cpp b/folly/Demangle.cpp index 4709106c..cb80b21f 100644 --- a/folly/Demangle.cpp +++ b/folly/Demangle.cpp @@ -27,8 +27,6 @@ // From libiberty // -// TODO(tudorb): Detect this with autoconf for the open-source version. -// // __attribute__((__weak__)) doesn't work, because cplus_demangle_v3_callback // is exported by an object file in libiberty.a, and the ELF spec says // "The link editor does not extract archive members to resolve undefined weak