From: Wez Furlong Date: Sun, 17 Jul 2016 06:02:32 +0000 (-0700) Subject: folly: fix initialization for CLOCK_PROCESS_CPUTIME_ID emulation on macOS X-Git-Tag: 2016.07.26~39 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=commitdiff_plain;h=4592f5e8e11ae6a5c3443b55ba5edb0425c5f019 folly: fix initialization for CLOCK_PROCESS_CPUTIME_ID emulation on macOS Summary: this fixes TimeTest on macOS. The problem was that `task_info_count` is an in/out parameter and it wasn't correctly initialized due to a typo. The lack of initialization meant that the `task_info()` call would fail at runtime. Reviewed By: yfeldblum Differential Revision: D3576262 fbshipit-source-id: 8388fa3c5020309d64a0fa7e01fd6cea80200219 --- diff --git a/folly/portability/Time.cpp b/folly/portability/Time.cpp index da44db61..bf165f41 100755 --- a/folly/portability/Time.cpp +++ b/folly/portability/Time.cpp @@ -50,8 +50,7 @@ static std::chrono::nanoseconds time_value_to_ns(time_value_t t) { static int clock_process_cputime(struct timespec* ts) { // Get CPU usage for live threads. task_thread_times_info thread_times_info; - mach_msg_type_number_t thread_times_info_count; - TASK_THREAD_TIMES_INFO_COUNT; + mach_msg_type_number_t thread_times_info_count = TASK_THREAD_TIMES_INFO_COUNT; kern_return_t kern_result = task_info( mach_task_self(), TASK_THREAD_TIMES_INFO,