From: Keith Daigle Date: Mon, 8 Jan 2018 19:31:12 +0000 (-0800) Subject: Update cpuid test to expect failure on non intel cpu X-Git-Tag: v2018.01.15.00~41 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=commitdiff_plain;h=24f2ac23ead3707b28a494afc5f55ed50bbfccaf Update cpuid test to expect failure on non intel cpu Summary: Found that testing would fail on aarch64 since mmx is an Intel thing. Changed it to just check for x64. Reviewed By: yfeldblum Differential Revision: D6670050 fbshipit-source-id: 6ce4b45bb5ef02d65305636d6ac28be7631ddf1b --- diff --git a/folly/test/CpuIdTest.cpp b/folly/test/CpuIdTest.cpp index 176f0c7c..dbab554c 100644 --- a/folly/test/CpuIdTest.cpp +++ b/folly/test/CpuIdTest.cpp @@ -1,5 +1,5 @@ /* - * Copyright 2017 Facebook, Inc. + * Copyright 2017-present Facebook, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,7 +21,7 @@ using namespace folly; TEST(CpuId, Simple) { - // All CPUs should support MMX CpuId id; - EXPECT_TRUE(id.mmx()); + // All x64 CPUs should support MMX + EXPECT_EQ(kIsArchAmd64, id.mmx()); }