From: Christopher Dykes Date: Thu, 15 Jun 2017 23:53:09 +0000 (-0700) Subject: Ensure LogWriter::writeMessage(std::string&&) is in the overload set of ImmediateFile... X-Git-Tag: v2017.06.19.00~9 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=commitdiff_plain;h=19859f96226810883e0f967e49d6d73912ae900d;hp=2bb2c015056554c0a1cc0cda2bdeb84bc11672ff Ensure LogWriter::writeMessage(std::string&&) is in the overload set of ImmediateFileWriter Summary: As MSVC correctly warns via C4266, the overload sets of functions in base classes are not part of the overload set in derived classes where you've declared an overload (or override) unless you've explicitly imported it. Reviewed By: simpkins Differential Revision: D5260056 fbshipit-source-id: bbbeeea3c13201a3a6eba6e62cfa5a49a9470d43 --- diff --git a/folly/experimental/logging/ImmediateFileWriter.h b/folly/experimental/logging/ImmediateFileWriter.h index 8f49c1fc..a029e73f 100644 --- a/folly/experimental/logging/ImmediateFileWriter.h +++ b/folly/experimental/logging/ImmediateFileWriter.h @@ -46,6 +46,7 @@ class ImmediateFileWriter : public LogWriter { */ explicit ImmediateFileWriter(folly::File&& file); + using LogWriter::writeMessage; void writeMessage(folly::StringPiece buffer) override; private: