fix UBSAN failure in atomic_shared_ptr_test

Summary: Fix UBSAN failure in atomic_shared_ptr_test by using reinterpret_cast instead of static_cast.

Reviewed By: yfeldblum

Differential Revision: D5314116

fbshipit-source-id: 8479c9c4bdeeb155067a3de75efe4e97c36519e5

diff --git a/folly/experimental/detail/AtomicSharedPtr-detail.h b/folly/experimental/detail/AtomicSharedPtr-detail.h
index bd416cb0ffdd477b574cac893f3e9a2161b0c75b..02d8be02ca5daa38c42be0206f5fd7277e610501 100644 (file)
--- a/folly/experimental/detail/AtomicSharedPtr-detail.h
+++ b/folly/experimental/detail/AtomicSharedPtr-detail.h
@@ -68,8 +68,8 @@ class shared_ptr_internals {
       return (T*)inplace;
     }
     // Could also be a _Sp_counted_deleter, but the layout is the same
       return (T*)inplace;
     }
     // Could also be a _Sp_counted_deleter, but the layout is the same

-    auto ptr =
-        static_cast<std::_Sp_counted_ptr<const void*, std::_S_atomic>*>(base);
+    using derived_type = std::_Sp_counted_ptr<const void*, std::_S_atomic>;
+    auto ptr = reinterpret_cast<derived_type*>(base);

     return (T*)(ptr->*fieldPtr(access_counted_ptr_ptr{}));
   }
 
     return (T*)(ptr->*fieldPtr(access_counted_ptr_ptr{}));
   }