Revert D4618623: Give observer manager threads a name

Summary: This reverts commit 21b86944f513da0700039a3e3736937fd72e8887

Differential Revision: D4618623

fbshipit-source-id: 6ab6498a2ce22895d7052e258d1af216d46ca178

diff --git a/folly/experimental/observer/detail/ObserverManager.cpp b/folly/experimental/observer/detail/ObserverManager.cpp
index aea3eec0d9157c8689c0a18124fae14646cb9346..f14b9092475f759c6b7d98203558fd6642180478 100644 (file)
--- a/folly/experimental/observer/detail/ObserverManager.cpp
+++ b/folly/experimental/observer/detail/ObserverManager.cpp
@@ -16,11 +16,8 @@
 #include <folly/experimental/observer/detail/ObserverManager.h>
 
 #include <folly/ExceptionString.h>
 #include <folly/experimental/observer/detail/ObserverManager.h>
 
 #include <folly/ExceptionString.h>

-#include <folly/FixedString.h>
-#include <folly/Format.h>

 #include <folly/MPMCQueue.h>
 #include <folly/Singleton.h>
 #include <folly/MPMCQueue.h>
 #include <folly/Singleton.h>

-#include <folly/ThreadName.h>

 #include <folly/portability/GFlags.h>
 
 namespace folly {
 #include <folly/portability/GFlags.h>
 
 namespace folly {


@@ -35,9 +32,6 @@ DEFINE_int32(
     4,
     "How many internal threads ObserverManager should use");
 
     4,
     "How many internal threads ObserverManager should use");
 

-static constexpr auto kObserverManagerThreadNamePrefix =
-    folly::makeFixedString("ObserverMngr");
-

 namespace {
 constexpr size_t kCurrentQueueSize{10 * 1024};
 constexpr size_t kNextQueueSize{10 * 1024};
 namespace {
 constexpr size_t kCurrentQueueSize{10 * 1024};
 constexpr size_t kNextQueueSize{10 * 1024};


@@ -51,9 +45,7 @@ class ObserverManager::CurrentQueue {
       FLAGS_observer_manager_pool_size = 1;
     }
     for (int32_t i = 0; i < FLAGS_observer_manager_pool_size; ++i) {
       FLAGS_observer_manager_pool_size = 1;
     }
     for (int32_t i = 0; i < FLAGS_observer_manager_pool_size; ++i) {

-      threads_.emplace_back([this, i]() {
-        folly::setThreadName(
-            folly::sformat("{}{}", kObserverManagerThreadNamePrefix, i));
+      threads_.emplace_back([&]() {

         ObserverManager::inManagerThread_ = true;
 
         while (true) {
         ObserverManager::inManagerThread_ = true;
 
         while (true) {