revert D1985475, clang still borked

Summary:
This reverts commit bb08e2405dc68e6dab1f0066b15faa2821ad3dc7.

Test Plan: revert-hammer

Reviewed By: hans@fb.com

Subscribers: mathieubaudet, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2006283

Signature: t1:2006283:1429556243:41e6b3189ce2da5a0f1a32a663ff8761628ca574

diff --git a/folly/futures/Future-inl.h b/folly/futures/Future-inl.h
index 94930b7b965125e05dddb2cd0b0f423b7a51471f..7a2ffc2b3263351118babc339109faff788af01a 100644 (file)
--- a/folly/futures/Future-inl.h
+++ b/folly/futures/Future-inl.h
@@ -235,16 +235,6 @@ Future<T>::then(R(Caller::*func)(Args...), Caller *instance) {
   });
 }
 
-template <class T>
-template <class... Args>
-auto Future<T>::then(Executor* x, Args&&... args)
-  -> decltype(this->then(std::forward<Args>(args)...))
-{
-  auto oldX = getExecutor();
-  setExecutor(x);
-  return this->then(std::forward<Args>(args)...).via(oldX);
-}
-
 template <class T>
 Future<void> Future<T>::then() {
   return then([] (Try<T>&& t) {});

diff --git a/folly/futures/Future.h b/folly/futures/Future.h
index 455c264e7be1e164b96c59f67738c180fd461ac8..90207dd8a1000a807b9a18a9ba99b1d17d2a2934 100644 (file)
--- a/folly/futures/Future.h
+++ b/folly/futures/Future.h
@@ -325,22 +325,6 @@ class Future {
   Future<typename isFuture<R>::Inner>
   then(R(Caller::*func)(Args...), Caller *instance);
 
-  /// Execute the callback via the given Executor. The executor doesn't stick.
-  ///
-  /// Contrast
-  ///
-  ///   f.via(x).then(b).then(c)
-  ///
-  /// with
-  ///
-  ///   f.then(x, b).then(c)
-  ///
-  /// In the former both b and c execute via x. In the latter, only b executes
-  /// via x, and c executes via the same executor (if any) that f had.
-  template <class... Args>
-  auto then(Executor* x, Args&&... args)
-    -> decltype(this->then(std::forward<Args>(args)...));
-
   /// Convenience method for ignoring the value and creating a Future<void>.
   /// Exceptions still propagate.
   Future<void> then();

diff --git a/folly/futures/test/ViaTest.cpp b/folly/futures/test/ViaTest.cpp
index d17fe575c6324ff4d85874f3c596f23906b99a73..390787d1e3f3395f0f0e6c0548f9e265e7e3f40c 100644 (file)
--- a/folly/futures/test/ViaTest.cpp
+++ b/folly/futures/test/ViaTest.cpp
@@ -184,33 +184,3 @@ TEST(Via, chain3) {
   EXPECT_EQ(42, f.get());
   EXPECT_EQ(3, count);
 }
-
-TEST(Via, then2) {
-  ManualExecutor x1, x2;
-  bool a,b,c;
-  via(&x1)
-    .then([&]{ a = true; })
-    .then(&x2, [&]{ b = true; })
-    .then([&]{ c = true; });
-
-  EXPECT_FALSE(a);
-  EXPECT_FALSE(b);
-
-  x1.run();
-  EXPECT_TRUE(a);
-  EXPECT_FALSE(b);
-  EXPECT_FALSE(c);
-
-  x2.run();
-  EXPECT_TRUE(b);
-  EXPECT_FALSE(c);
-
-  x1.run();
-  EXPECT_TRUE(c);
-}
-
-TEST(Via, then2Variadic) {
-  struct Foo { void foo(Try<void>) {} };
-  Foo f;
-  makeFuture().then(nullptr, &Foo::foo, &f);
-}